Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jul 11, 2025

Adds support for a subset of the DTD Editor service registered by IDEs for use by the widget preview scaffold. Currently, this feature subset includes support for listening for:

  • Source file selection events
  • Editor theme change events

This change does not introduce any new functionality that makes use of these new DTD Editor events.

Adds support for a subset of the DTD `Editor` service registered
by IDEs for use by the widget preview scaffold. Currently, this feature
subset includes support for listening for:

 - Source file selection events
 - Editor theme change events

This change does not introduce any new functionality that makes use of
these new DTD `Editor` events.
@bkonyi bkonyi requested a review from jyameo July 11, 2025 23:17
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. d: examples Sample code and demos labels Jul 11, 2025
@github-actions github-actions bot removed the d: examples Sample code and demos label Jul 11, 2025
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! However, there are a few CI failures on widget_preview_test.dart. please take a look.

@bkonyi
Copy link
Contributor Author

bkonyi commented Jul 14, 2025

Overall looks good! However, there are a few CI failures on widget_preview_test.dart. please take a look.

Should be fixed now 😄

Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 14, 2025
Merged via the queue into master with commit b40f19b Jul 14, 2025
148 checks passed
@auto-submit auto-submit bot deleted the widget_preview_dtd_editor_service_support branch July 14, 2025 20:10
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 15, 2025
flutter/flutter@a930ec1...cc3110c

2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132)
2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145)
2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141)
2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545)
2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031)
2025-07-14 [email protected] Route transition duration (flutter/flutter#171109)
2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136)
2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134)
2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128)
2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130)
2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676)
2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040)
2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123)
2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104)
2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983)
2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120)
2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033)
2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465)
2025-07-14 [email protected] remove `x86` in CI  builder linux_android_emulator (flutter/flutter#170964)
2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966)
2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063)
2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116)
2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111)
2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…utter#172040)

Adds support for a subset of the DTD `Editor` service registered by IDEs
for use by the widget preview scaffold. Currently, this feature subset
includes support for listening for:

 - Source file selection events
 - Editor theme change events

This change does not introduce any new functionality that makes use of
these new DTD `Editor` events.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9631)

flutter/flutter@a930ec1...cc3110c

2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132)
2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145)
2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141)
2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545)
2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031)
2025-07-14 [email protected] Route transition duration (flutter/flutter#171109)
2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136)
2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134)
2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128)
2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130)
2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676)
2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040)
2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123)
2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104)
2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983)
2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120)
2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033)
2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465)
2025-07-14 [email protected] remove `x86` in CI  builder linux_android_emulator (flutter/flutter#170964)
2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966)
2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063)
2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116)
2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111)
2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
…utter#172040)

Adds support for a subset of the DTD `Editor` service registered by IDEs
for use by the widget preview scaffold. Currently, this feature subset
includes support for listening for:

 - Source file selection events
 - Editor theme change events

This change does not introduce any new functionality that makes use of
these new DTD `Editor` events.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…utter#172040)

Adds support for a subset of the DTD `Editor` service registered by IDEs
for use by the widget preview scaffold. Currently, this feature subset
includes support for listening for:

 - Source file selection events
 - Editor theme change events

This change does not introduce any new functionality that makes use of
these new DTD `Editor` events.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…utter#172040)

Adds support for a subset of the DTD `Editor` service registered by IDEs
for use by the widget preview scaffold. Currently, this feature subset
includes support for listening for:

 - Source file selection events
 - Editor theme change events

This change does not introduce any new functionality that makes use of
these new DTD `Editor` events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants