Skip to content

chore: unskip tests cases #172031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedromassango merged 2 commits into from
Jul 14, 2025
Merged

chore: unskip tests cases #172031

pedromassango merged 2 commits into from
Jul 14, 2025

Conversation

@pedromassango
Copy link
Member

@pedromassango pedromassango commented Jul 11, 2025 •
edited
Loading

Issues have been solved, we can now have the tests back

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jul 11, 2025
@pedromassango pedromassango enabled auto-merge July 11, 2025 21:27
@pedromassango pedromassango added this pull request to the merge queue Jul 14, 2025
Merged via the queue into master with commit 50d5f02 Jul 14, 2025
76 checks passed
@pedromassango pedromassango deleted the fix/unskip_test branch July 14, 2025 23:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
4796091
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
affea92
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 15, 2025
@engine-flutter-autoroll
Roll Flutter from a930ec1a6c09 to cc3110c59022 (24 revisions) (#9631)
2a0b7ef 
flutter/flutter@a930ec1...cc3110c

2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132)
2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145)
2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141)
2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545)
2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031)
2025-07-14 [email protected] Route transition duration (flutter/flutter#171109)
2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136)
2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134)
2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128)
2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130)
2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676)
2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040)
2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123)
2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104)
2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983)
2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120)
2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033)
2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465)
2025-07-14 [email protected] remove `x86` in CI  builder linux_android_emulator (flutter/flutter#170964)
2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966)
2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063)
2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116)
2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111)
2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@pedromassango @azatech
chore: unskip tests cases (flutter#172031)
b3435f3 
Issues have been solved, we can now have the tests back


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from a930ec1a6c09 to cc3110c59022 (24 revisions) (flutte…
afa5605 
…r#9631)

flutter/flutter@a930ec1...cc3110c

2025-07-15 [email protected] feat: Tag Fuchsia artifacts by content hash (flutter/flutter#172132)
2025-07-15 [email protected] Marks Linux_android_emu native_assets_android to be unflaky (flutter/flutter#171145)
2025-07-15 [email protected] [ Tool ] Fix `flutter upgrade` stating that an upgrade is available on `main` when up to date (flutter/flutter#172141)
2025-07-15 [email protected] Reland "Add feature flags to the framework" (flutter/flutter#171545)
2025-07-14 [email protected] chore: unskip tests cases (flutter/flutter#172031)
2025-07-14 [email protected] Route transition duration (flutter/flutter#171109)
2025-07-14 [email protected] [Impeller] libImpeller: Correctly release mappings created using the C++ API wrapper. (flutter/flutter#172136)
2025-07-14 [email protected] Roll Skia from 5f7adef2ac25 to 2f4ad5d83704 (3 revisions) (flutter/flutter#172134)
2025-07-14 [email protected] Migrate to arm based firebase test devices for api 26 and 27 (flutter/flutter#172128)
2025-07-14 [email protected] [web] Cleanup unnecessary dart defines and renderer in web tests (flutter/flutter#172130)
2025-07-14 [email protected] Use granular skparagraph targets (flutter/flutter#161676)
2025-07-14 [email protected] [ Widget Preview ] Initial work to support reacting to IDE events (flutter/flutter#172040)
2025-07-14 [email protected] Roll Skia from e95c92d867b5 to 5f7adef2ac25 (8 revisions) (flutter/flutter#172123)
2025-07-14 [email protected] [skia] Set GN flags explicitly for fuchsia build (flutter/flutter#172104)
2025-07-14 [email protected] fix: documentation around led launch broken (flutter/flutter#171983)
2025-07-14 [email protected] [ Tool ] Downgrade and pin DDS to 5.0.3 (flutter/flutter#172120)
2025-07-14 [email protected] Apply superellipse clipping to iOS platform views using an approximated round rect (flutter/flutter#172033)
2025-07-14 [email protected] [Impeller] Fix broken image links in documentation. (flutter/flutter#171465)
2025-07-14 [email protected] remove `x86` in CI  builder linux_android_emulator (flutter/flutter#170964)
2025-07-14 [email protected] remove `x86` in flutter_gdb (flutter/flutter#170966)
2025-07-14 [email protected] fix android studio lint about lambda function (flutter/flutter#172063)
2025-07-14 [email protected] Roll Fuchsia Linux SDK from qw0YTtPhosk3-rr4h... to tQAtsLtpc0oBIqRwC... (flutter/flutter#172116)
2025-07-14 [email protected] Roll Skia from 92354f64e37f to e95c92d867b5 (1 revision) (flutter/flutter#172111)
2025-07-14 [email protected] [web] Delete unused files in the engine (flutter/flutter#172035)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
f31688c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
b4abecc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
1461c6e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
26c4349
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
50d5f022c chore: unskip tests cases (flutter/flutter#172031)
1851bdd
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@pedromassango @ksokolovskyi
chore: unskip tests cases (flutter#172031)
6cb07ed 
Issues have been solved, we can now have the tests back


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@pedromassango @mboetger
chore: unskip tests cases (flutter#172031)
9bd9cb9 
Issues have been solved, we can now have the tests back


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@pedromassango @lucaantonelli
chore: unskip tests cases (flutter#172031)
db43ed5 
Issues have been solved, we can now have the tests back


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedromassango @gspencergoog