[android][tool] Consolidate minimum versions for android projects. #171965

reidbaker · 2025-07-10T15:08:07Z

I discovered we had a duplicate entry for what the min sdk api level flutter supports along with duplicate code for telling the user.
This pr keeps the duplicate warnings but removed duplicate definitions.
Updates the related tests
Updates workflow_test and android_workflow to compare against the compile sdk version since the validation was ensuring that the lastest of the installed sdks was at least what was needed for flutter to compile. This make this pr more than a formatting/refactoring change and an actual user facing change. Requesting re-review.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

mboetger · 2025-07-10T16:10:50Z

packages/flutter_tools/lib/src/android/README.md

 - The flutter min version in `engine/src/flutter/shell/platform/android/io/flutter/Build.java`
 - The versions used when engine testing in `engine/src/flutter/shell/platform/android/test_runner/build.gradle`
 - The versions used when working in engine/shell in `engine/src/flutter/shell/platform/android/build.gradle`
+- The minSdkVersion used in `packages/flutter_tools/lib/src/android/android.dart`


You mean in the packages/flutter_tools/lib/src/android folder?

Changes to this file reverted. I tried to exclude them.

mboetger

LGTM - minor nit

gmackall · 2025-07-10T16:35:13Z

packages/flutter_tools/lib/src/android/android_workflow.dart

    String? sdkVersionText;
    final AndroidSdkVersion? androidSdkLatestVersion = androidSdk.latestVersion;
    if (androidSdkLatestVersion != null) {
-      if (androidSdkLatestVersion.sdkLevel < kAndroidSdkMinVersion ||


I think this is doing something slightly different than checking the minSdk, right? Our min supported minSdk is 24, but this seems to be checking "what is the min version among sdk installations", which is a different value and I assume also why this is being checked against a significantly higher value. Perhaps @bkonyi knows why we have a restriction on the min installed sdk version?

That would make sense and if so will cause me to modify this pr. Holding on a response from @bkonyi

Unfortunately I'm not sure myself. Can we look at the history of packages/flutter_tools/lib/src/android/android.dart and kAndroidSdkMinVersion in this file to try and figure out if there's a particular reason that they're different?

I did some code spelunking. Looks like past flutter teams might have mixed the use of compileSdk and targetSdk but some of code was in place to set a minimum compile sdk version, some other of this code was for minimum build tool version.

#54382
#63517
a2e5e07#diff-c245d623bd123a206f90dc458d73520304e81ff8d1eac06a38e2c5221a859bfa

It also appears that the last time this value was updated was 2020. My choices now are to remove this code, update it to a higher min compile sdk version or to do nothing to it.

I think I am going to move the minimums to be together. Reread the exising code to confirm that the way we enforce compile time and minimum versions are what we want and leave the build tool enforcement alone.

packages/flutter_tools/lib/src/android/android_device.dart

bkonyi · 2025-07-10T18:29:11Z

packages/flutter_tools/test/general.shard/android/android_install_test.dart

  });

-  testWithoutContext('Can install app on API level 16 or greater', () async {
+  testWithoutContext('Can install app on API level minSdk or greater', () async {


Nit: maybe include the minSdk value here in the test name?

Something like:

Can install app on API level ${gradle_utils.minSdkVersion} or greater

or:

Can install app on API level minSdk (${gradle_utils.minSdkVersion}) or greater

bkonyi · 2025-07-10T18:30:28Z

packages/flutter_tools/lib/src/android/android_workflow.dart

    String? sdkVersionText;
    final AndroidSdkVersion? androidSdkLatestVersion = androidSdk.latestVersion;
    if (androidSdkLatestVersion != null) {
-      if (androidSdkLatestVersion.sdkLevel < kAndroidSdkMinVersion ||


Unfortunately I'm not sure myself. Can we look at the history of packages/flutter_tools/lib/src/android/android.dart and kAndroidSdkMinVersion in this file to try and figure out if there's a particular reason that they're different?

packages/flutter_tools/lib/src/android/gradle_utils.dart

mboetger

LGTM

…ojects. (flutter/flutter#171965)

flutter/flutter@9de63a0...92a6bfb 2025-08-07 [email protected] Roll Packages from f0b2726 to 6efb759 (4 revisions) (flutter/flutter#173414) 2025-08-07 [email protected] Provide monitor list, display size, refresh rate, and more for Windows (flutter/flutter#164460) 2025-08-07 [email protected] [android][tool] Consolidate minimum versions for android projects. (flutter/flutter#171965) 2025-08-07 [email protected] Roll Fuchsia Linux SDK from 2Mo76-tiDj4ZCZbPv... to i4vsuEGyP8Xeb5tiy... (flutter/flutter#173409) 2025-08-07 [email protected] Roll Skia from 9a886bdfb716 to a6ccfeafbfba (1 revision) (flutter/flutter#173384) 2025-08-07 [email protected] Fix drawerScrimColor transition. (flutter/flutter#173280) 2025-08-07 [email protected] Roll Skia from dd60ed46a006 to 9a886bdfb716 (2 revisions) (flutter/flutter#173382) 2025-08-06 [email protected] Roll Skia from 05d82af3f4bd to dd60ed46a006 (2 revisions) (flutter/flutter#173376) 2025-08-06 [email protected] Roll Skia from 5518bb27db67 to 05d82af3f4bd (2 revisions) (flutter/flutter#173372) 2025-08-06 [email protected] Roll Skia from 9bb1fc4bc326 to 5518bb27db67 (2 revisions) (flutter/flutter#173363) 2025-08-06 [email protected] Roll Skia from a918c0e08500 to 9bb1fc4bc326 (24 revisions) (flutter/flutter#173355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#171965) I discovered we had a duplicate entry for what the min sdk api level flutter supports along with duplicate code for telling the user. This pr keeps the duplicate warnings but removed duplicate definitions. Updates the related tests Updates workflow_test and android_workflow to compare against the compile sdk version since the validation was ensuring that the lastest of the installed sdks was at least what was needed for flutter to compile. This make this pr more than a formatting/refactoring change and an actual user facing change. Requesting re-review. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…ojects. (flutter/flutter#171965)

…lutter#171965) I discovered we had a duplicate entry for what the min sdk api level flutter supports along with duplicate code for telling the user. This pr keeps the duplicate warnings but removed duplicate definitions. Updates the related tests Updates workflow_test and android_workflow to compare against the compile sdk version since the validation was ensuring that the lastest of the installed sdks was at least what was needed for flutter to compile. This make this pr more than a formatting/refactoring change and an actual user facing change. Requesting re-review. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

delete duplicate entry for minsdk version and update references

a5c3f4f

reidbaker requested review from bkonyi and gmackall July 10, 2025 15:08

reidbaker requested a review from a team as a code owner July 10, 2025 15:08

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-android Owned by Android platform team labels Jul 10, 2025

modify tests to use variable instead of hardcoding device as api 16

b02eceb

mboetger reviewed Jul 10, 2025

View reviewed changes

mboetger requested changes Jul 10, 2025

View reviewed changes

gmackall reviewed Jul 10, 2025

View reviewed changes

Update README.md

425bc14

bkonyi reviewed Jul 10, 2025

View reviewed changes

reidbaker and others added 6 commits August 4, 2025 11:27

add which min api is intented in test

5534e62

Merge branch 'master' into r-template-version-bump-2025-07-10

4f35287

remove obvious types

d04cd01

Merge branch 'master' into r-template-version-bump-2025-07-10

62334bc

Modify min sdk checker to use compile sdk

a9df43d

Fix tests to use compilesdk for minimum installed sdk validation

614f250

reidbaker requested review from bkonyi, gmackall and mboetger August 4, 2025 16:34

reidbaker changed the title ~~[android][tool] delete duplicate entry for minsdk version and update references~~ [android][tool] Consolidate minimum versions for android projects. Aug 4, 2025

bkonyi approved these changes Aug 5, 2025

View reviewed changes

mboetger reviewed Aug 6, 2025

View reviewed changes

packages/flutter_tools/lib/src/android/gradle_utils.dart Show resolved Hide resolved

mboetger approved these changes Aug 6, 2025

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

auto-submit bot added this pull request to the merge queue Aug 7, 2025

Merged via the queue into flutter:master with commit f15262c Aug 7, 2025
141 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

reidbaker deleted the r-template-version-bump-2025-07-10 branch August 7, 2025 14:48

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2025

f15262c9f [android][tool] Consolidate minimum versions for android pr…

7846f9a

…ojects. (flutter/flutter#171965)

engine-flutter-autoroll mentioned this pull request Aug 7, 2025

Roll Flutter from 9de63a03428f to f15262c9f713 (9 revisions) flutter/packages#9767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2025

f15262c9f [android][tool] Consolidate minimum versions for android pr…

f8df1a8

…ojects. (flutter/flutter#171965)

engine-flutter-autoroll mentioned this pull request Aug 7, 2025

Roll Flutter from 9de63a03428f to 0accf67215b9 (10 revisions) flutter/packages#9768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2025

f15262c9f [android][tool] Consolidate minimum versions for android pr…

ca3994e

…ojects. (flutter/flutter#171965)

engine-flutter-autoroll mentioned this pull request Aug 7, 2025

Roll Flutter from 9de63a03428f to 92a6bfbfd6ef (11 revisions) flutter/packages#9769

Merged

Piinks mentioned this pull request Aug 8, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

f15262c9f [android][tool] Consolidate minimum versions for android pr…

6efa3f0

…ojects. (flutter/flutter#171965)

[android][tool] Consolidate minimum versions for android projects. #171965

[android][tool] Consolidate minimum versions for android projects. #171965

Uh oh!

Conversation

reidbaker commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

mboetger Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

mboetger left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bkonyi Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mboetger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reidbaker commented Jul 10, 2025 •

edited

Loading

gmackall Jul 10, 2025 •

edited

Loading

reidbaker Aug 4, 2025 •

edited

Loading