Skip to content

feat: start using the content aware hash for downloading artifacts #171927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jul 21, 2025
Merged

feat: start using the content aware hash for downloading artifacts #171927

auto-submit merged 3 commits into from
Jul 21, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Jul 9, 2025 •
edited
Loading

towards #171790

Use the content aware hash when downloading engine artifacts. These are currently produced when changes to DEPs, engine/, or the release file are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the engine.version for testing. Though Cocoon does not need to actually set it for framework only PRs anymore.

@jtmcdole jtmcdole requested a review from matanlurey as a code owner July 9, 2025 23:50
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-tool Owned by Flutter Tool team d: docs/ flutter/flutter/docs, for contributors labels Jul 9, 2025
@jtmcdole jtmcdole requested a review from chingjun July 9, 2025 23:50
@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 9, 2025

Note: before we remove building of git-sha artifacts, we need to validate rolls into Google.

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 10, 2025

Looks like a real problem with the windows tests; I'll try it out locally.

00:13 +42 ~2 -1: C:/b/s/w/ir/x/w/flutter/dev/tools/test/update_engine_version_test.dart: resolves engine artifacts with git merge-base fallsback to origin/master [E]
  ProcessException: %1 is not a valid Win32 application.
  
    Command: C:\b\s\w\ir\x\t\update_engine_version_test.2b990013\flutter\bin\internal\content_aware_hash.ps1 
  dart:io                                      Process.runSync
  test\update_engine_version_test.dart 57:48   main.run
  test\update_engine_version_test.dart 245:50  main.gitContentHash
  test\update_engine_version_test.dart 352:34  main.<fn>.<fn>

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 10, 2025

Looks like a real problem with the windows tests; I'll try it out locally.

00:13 +42 ~2 -1: C:/b/s/w/ir/x/w/flutter/dev/tools/test/update_engine_version_test.dart: resolves engine artifacts with git merge-base fallsback to origin/master [E]
  ProcessException: %1 is not a valid Win32 application.
  
    Command: C:\b\s\w\ir\x\t\update_engine_version_test.2b990013\flutter\bin\internal\content_aware_hash.ps1 
  dart:io                                      Process.runSync
  test\update_engine_version_test.dart 57:48   main.run
  test\update_engine_version_test.dart 245:50  main.gitContentHash
  test\update_engine_version_test.dart 352:34  main.<fn>.<fn>

Duh... run powershell in powershell...

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 10, 2025

We should wait for stable to be cut before merging.

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 14, 2025

Blocked waiting for #172132 / #171985

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 15, 2025

rebased to get past ci.yaml.

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 16, 2025

I need to hold off on this till we've fixed another bug: android artifacts are not uploaded correctly (right folder, wrong file). The recipes are misleading in their output on LUCI.

Converting to draft.

@jtmcdole jtmcdole marked this pull request as draft July 16, 2025 19:55
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Jul 18, 2025
@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 18, 2025

Ah shoot, that last one is meant for another PR

@github-actions github-actions bot removed platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Jul 18, 2025
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Jul 19, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
40992ec4f feat: start using the content aware hash for downloading ar…
e9626f6 
…tifacts (flutter/flutter#171927)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2025
@jtmcdole
feat: start using the content aware hash for downloading artifacts (#…
ff983d3 
…172552)

reland of #171927
towards #171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: 407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
40992ec4f feat: start using the content aware hash for downloading ar…
038fdd9 
…tifacts (flutter/flutter#171927)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 22, 2025
@engine-flutter-autoroll
Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) (#9662)
63646c6 
flutter/flutter@70cdc0c...ee0cc66

2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@robert-ancell
Copy link
Contributor

robert-ancell commented Jul 24, 2025

This seems to have broken the Dart SDK download on Linux:

$ flutter --version
Downloading Linux x64 Dart SDK from Flutter engine 494bd6a8024b257ab1af875d28581e1fc4dc4465...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   255  100   255    0     0     45      0  0:00:05  0:00:05 --:--:--    53
[/home/bob/git/flutter/flutter/bin/cache/dart-sdk-linux-x64.zip]
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/bob/git/flutter/flutter/bin/cache/dart-sdk-linux-x64.zip or
        /home/bob/git/flutter/flutter/bin/cache/dart-sdk-linux-x64.zip.zip, and cannot find /home/bob/git/flutter/flutter/bin/cache/dart-sdk-linux-x64.zip.ZIP, period.

It appears that the downloaded file is corrupt; please try again.
If this problem persists, please report the problem at:
  https://github.com/flutter/flutter/issues/new?template=01_activation.yml

The hash doesn't appear on the server:

$ wget https://storage.googleapis.com/flutter_infra_release/flutter/494bd6a8024b257ab1af875d28581e1fc4dc4465/dart-sdk-linux-x64.zip
--2025-07-24 13:23:01--  https://storage.googleapis.com/flutter_infra_release/flutter/494bd6a8024b257ab1af875d28581e1fc4dc4465/dart-sdk-linux-x64.zip
Resolving storage.googleapis.com (storage.googleapis.com)... 142.250.76.123, 142.250.204.27, 142.251.221.91, ...
Connecting to storage.googleapis.com (storage.googleapis.com)|142.250.76.123|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2025-07-24 13:23:02 ERROR 404: Not Found.

@robert-ancell
Copy link
Contributor

robert-ancell commented Jul 24, 2025

Workaround I'm currently using:

diff --git a/bin/internal/update_engine_version.sh b/bin/internal/update_engine_version.sh
index d8185cb8db5..2f058bdd658 100755
--- a/bin/internal/update_engine_version.sh
+++ b/bin/internal/update_engine_version.sh
@@ -57,7 +57,17 @@ elif [ -n "$(git -C "$FLUTTER_ROOT" ls-files bin/internal/engine.version)" ]; th
 # the current branch is forked from, which would be the last version of the
 # engine artifacts built from CI.
 else
-  ENGINE_VERSION=$("$FLUTTER_ROOT/bin/internal/content_aware_hash.sh")
+  set +e
+  # We fallback to origin/master if upstream is not detected.
+  git -C "$FLUTTER_ROOT" remote get-url upstream >/dev/null 2>&1
+  exit_code=$?
+  set -e
+
+  if [[ $exit_code -eq 0 ]]; then
+    ENGINE_VERSION=$(git -C "$FLUTTER_ROOT" merge-base HEAD upstream/master)
+  else
+    ENGINE_VERSION=$(git -C "$FLUTTER_ROOT" merge-base HEAD origin/master)
+  fi
 fi
 
 # Write the engine version out so downstream tools know what to look for.

@robert-ancell
Copy link
Contributor

robert-ancell commented Jul 24, 2025

Seems to be working today, assume the server caught up.

@robert-ancell
Copy link
Contributor

robert-ancell commented Jul 24, 2025

Correction - it's working on main, but any branches I have don't work and need the above patch to work.

@jtmcdole
Copy link
Member Author

jtmcdole commented Jul 25, 2025

Correction - it's working on main, but any branches I have don't work and need the above patch to work.

Can you open a bug or follow up here: #171790

Assumption: you have local changes?

azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@jtmcdole @azatech
feat: start using the content aware hash for downloading artifacts (f…
9cf559b 
…lutter#171927)

towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@auto-submit @azatech
Reverts "feat: start using the content aware hash for downloading art…
0e9fab8 
…ifacts (flutter#171927)" (flutter#172505)

<!-- start_original_pr_link -->
Reverts: flutter#171927
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke the tree, due to naughty tests but too
intensive to fix forward.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, chingjun}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@jtmcdole @azatech
feat: start using the content aware hash for downloading artifacts (f…
e115894 
…lutter#172552)

reland of flutter#171927
towards flutter#171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: flutter@407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
@robert-ancell
Copy link
Contributor

robert-ancell commented Jul 30, 2025

Yes, this is:

  1. Get the main branch
  2. Make changes (may or may not be committed)
  3. Build Flutter
  4. Run a Flutter app with flutter run --local-engine-src-path ...

vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 70cdc0c933d6 to ee0cc6652be7 (29 revisions) (flutte…
848a02a 
…r#9662)

flutter/flutter@70cdc0c...ee0cc66

2025-07-22 [email protected] Licenses cpp ignore whitespace (flutter/flutter#172512)
2025-07-22 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#172552)
2025-07-22 [email protected] fix: correct typo in analysis_options.yaml comment (disabeling -> disabling) (flutter/flutter#170206)
2025-07-22 [email protected] Hide `flutter assemble` unless `--verbose` (flutter/flutter#172508)
2025-07-22 [email protected] Fix PopupMenuButton crashes when being hidden immediately (flutter/flutter#171970)
2025-07-22 [email protected] Add hitTestChildren to baseline-aligned stack (flutter/flutter#172485)
2025-07-22 [email protected] Roll Skia from 4aba494b8108 to eea1c33fbe84 (11 revisions) (flutter/flutter#172515)
2025-07-22 [email protected] Replaces legacy licenses check with licenses_cpp (flutter/flutter#172486)
2025-07-22 [email protected] Omit `w` (widget tree), `t` (render tree) from `flutter run --profile` `h` (flutter/flutter#172506)
2025-07-22 [email protected] Refactor checks for `--machine` (flutter/flutter#172504)
2025-07-22 [email protected] feat(IconButton): add property to specify a states controller (flutter/flutter#169821)
2025-07-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "feat: start using the content aware hash for downloading artifacts (#171927)" (flutter/flutter#172505)
2025-07-21 [email protected] Render Flutter in its own EGL context (flutter/flutter#172330)
2025-07-21 [email protected] Feat: Add momentary varient of CupertinoSlidingSegmentedControl (flutter/flutter#164262)
2025-07-21 [email protected] Roll Packages from cb8fef6 to 9c85e5e (10 revisions) (flutter/flutter#172479)
2025-07-21 [email protected] Wrap `ShutdownHook` calls to avoid crashing the tool (flutter/flutter#171917)
2025-07-21 [email protected] fix: macOS Mojave Crash on Flutter Desktop Startup (flutter/flutter#172282)
2025-07-21 [email protected] Roll Skia from 9587301e33bc to 4aba494b8108 (41 revisions) (flutter/flutter#172471)
2025-07-21 [email protected] Add CLA note to tree hygiene (flutter/flutter#172475)
2025-07-21 [email protected] Add `radioInnerRadius` to `RadioListTile` (flutter/flutter#171851)
2025-07-21 [email protected] Use baseUri always when doing a hot reload or hot restart (flutter/flutter#172271)
2025-07-21 [email protected] feat: start using the content aware hash for downloading artifacts (flutter/flutter#171927)
2025-07-21 [email protected] Add support for `/?` to alias to `--help` (flutter/flutter#172328)
2025-07-21 [email protected] Upgrade flutter_lints in project template pubspec.yaml files (flutter/flutter#172400)
2025-07-21 [email protected] Use `$dartSdkVersion` when creating "dummy" pubspec for `create_api_docs` (flutter/flutter#172327)
2025-07-21 [email protected] Adds `(defaults to ___)` when using `flutter config --help` (flutter/flutter#172329)
2025-07-21 [email protected] Add a warning on usage of `dartPluginClass: 'none'`. (flutter/flutter#172315)
2025-07-21 [email protected] Skip [tool] crash reporting on `--local-engine` (flutter/flutter#172326)
2025-07-21 [email protected] Remove IDE validation from `flutter doctor` (flutter/flutter#171924)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@jtmcdole @ksokolovskyi
feat: start using the content aware hash for downloading artifacts (f…
ec5b18b 
…lutter#171927)

towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@auto-submit @ksokolovskyi
Reverts "feat: start using the content aware hash for downloading art…
202f34d 
…ifacts (flutter#171927)" (flutter#172505)

<!-- start_original_pr_link -->
Reverts: flutter#171927
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke the tree, due to naughty tests but too
intensive to fix forward.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, chingjun}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@jtmcdole @ksokolovskyi
feat: start using the content aware hash for downloading artifacts (f…
9af2de2 
…lutter#172552)

reland of flutter#171927
towards flutter#171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: flutter@407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@jtmcdole @mboetger
feat: start using the content aware hash for downloading artifacts (f…
9595c92 
…lutter#171927)

towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@auto-submit @mboetger
Reverts "feat: start using the content aware hash for downloading art…
abe023f 
…ifacts (flutter#171927)" (flutter#172505)

<!-- start_original_pr_link -->
Reverts: flutter#171927
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke the tree, due to naughty tests but too
intensive to fix forward.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, chingjun}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@jtmcdole @mboetger
feat: start using the content aware hash for downloading artifacts (f…
3437980 
…lutter#172552)

reland of flutter#171927
towards flutter#171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: flutter@407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@jtmcdole @korca0220
feat: start using the content aware hash for downloading artifacts (f…
9f36bc0 
…lutter#171927)

towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@auto-submit @korca0220
Reverts "feat: start using the content aware hash for downloading art…
19bc89c 
…ifacts (flutter#171927)" (flutter#172505)

<!-- start_original_pr_link -->
Reverts: flutter#171927
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke the tree, due to naughty tests but too
intensive to fix forward.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, chingjun}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@jtmcdole @korca0220
feat: start using the content aware hash for downloading artifacts (f…
96f177b 
…lutter#172552)

reland of flutter#171927
towards flutter#171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: flutter@407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
40992ec4f feat: start using the content aware hash for downloading ar…
d343687 
…tifacts (flutter/flutter#171927)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@jtmcdole @lucaantonelli
feat: start using the content aware hash for downloading artifacts (f…
f20c2e7 
…lutter#171927)

towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@auto-submit @lucaantonelli
Reverts "feat: start using the content aware hash for downloading art…
cc63562 
…ifacts (flutter#171927)" (flutter#172505)

<!-- start_original_pr_link -->
Reverts: flutter#171927
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke the tree, due to naughty tests but too
intensive to fix forward.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, chingjun}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
towards flutter#171790 

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove `engine.version` being tracked in release
branches as an optimization.

`FLUTTER_PREBUILT_ENGINE_VERSION` will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@jtmcdole @lucaantonelli
feat: start using the content aware hash for downloading artifacts (f…
520576d 
…lutter#172552)

reland of flutter#171927
towards flutter#171790

Use the content aware hash when downloading engine artifacts. These are
currently produced when changes to DEPs, engine/, or the release file
are changed in a not-seen-before way.

We can eventually remove engine.version being tracked in release
branches as an optimization.

FLUTTER_PREBUILT_ENGINE_VERSION will stay for overriding the
engine.version for testing. Though Cocoon does not need to actually set
it for framework only PRs anymore.

fxies post submit tests for content_hash download:
SHARD=framework_tests SUBSHARD=misc dart --enable-asserts
dev/bots/test.dart
SHARD=tool_host_cross_arch_tests dart --enable-asserts
dev/bots/test.dart

```
  ╔═╡ERROR https://github.com/flutter/flutter/pull/1╞════════════════════════════════════════════════════════════════════
  ║ Expected "Flutter Engine Version: 45b085ab2118f30441ae6e2daab4b8eb3e4a063c", but found "Flutter Engine Version: flutter@407c051".
  ╚═══════════════════════════════════════════════════════════════════════════════
```

```
  Expected: contains '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
     Which: does not contain '45b085ab2118f30441ae6e2daab4b8eb3e4a063c'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@chingjun chingjun chingjun approved these changes

Assignees

No one assigned

Labels

d: docs/ flutter/flutter/docs, for contributors team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtmcdole @matanlurey @robert-ancell @chingjun