-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add public postmortem of the 3.32.3 release. #171904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reidbaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both comments are suggestions and not blocking.
|
|
||
| As a result, a manual downgrade and a few other possible workarounds were needed to get a working Flutter SDK on macOS, until 3.32.4 could be published with correctly signed binaries. | ||
|
|
||
| Three parts of the system failed (not including the GCP outage): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider linking to something public that covers the gcp outage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
|
||
| 1. Once we realized we wanted to rollback (release a new version that is actually an older version) we couldn't - the release tool lacked that function. | ||
| 2. Even if the release tool supported rolling back, it's unclear if the `flutter` tool would understand that change. | ||
| 3. Our recipe code (Python code that runs on our VM fleet and builds and tests the SDK) had a bug where if there were 2 or more commits merged into a release branch in a somewhat short timespan (< 2 hours), previous commits that were _not_ the latest would be assumed by the recipe that they did originate from a release branch, and would not sign the artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there was a bug tracking this then consider linking it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, don't feel like looking for it.
flutter/flutter@ac12f66...43657f3 2025-07-10 [email protected] [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 [email protected] Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 [email protected] Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 [email protected] Refactor compositor classes (flutter/flutter#171414) 2025-07-10 [email protected] Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 [email protected] Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 [email protected] Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 [email protected] Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 [email protected] Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 [email protected] Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 [email protected] Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 [email protected] Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 [email protected] Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 [email protected] [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 [email protected] Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 [email protected] feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 [email protected] Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 [email protected] Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 [email protected] Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 [email protected] Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 [email protected] Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 [email protected] Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 [email protected] [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9589) flutter/flutter@ac12f66...43657f3 2025-07-10 [email protected] [web] Add frame number support. (flutter/flutter#171592) 2025-07-10 [email protected] Fix the hitTest issue of reversed SliverMainAxisGroup. (flutter/flutter#171073) 2025-07-10 [email protected] Roll Fuchsia Linux SDK from 0-xqmXWc4cXzw3tfe... to lO64ePNEGrGzs-MFC... (flutter/flutter#171937) 2025-07-10 [email protected] Refactor compositor classes (flutter/flutter#171414) 2025-07-10 [email protected] Give an actionable error to `flutter_test.*tap` of a `RenderSliver` (flutter/flutter#171930) 2025-07-10 [email protected] Fix the issue with `SliverMainAxisGroups` growing in the reverse direction during layout. (flutter/flutter#171005) 2025-07-09 [email protected] Adds a MCP server for working with the engine (flutter/flutter#171738) 2025-07-09 [email protected] Use Async SurfaceHolder Callback to remove need for setting alpha workaround (flutter/flutter#171398) 2025-07-09 [email protected] Update `CHANGELOG` for 3.32.5, 3.32.6 stable hotfix releases (flutter/flutter#171891) 2025-07-09 [email protected] Add `flutter config --enable-omit-legacy-version-file` (flutter/flutter#171903) 2025-07-09 [email protected] Allow flutter attach to discover flutter engine running on Custom Device (flutter/flutter#170635) 2025-07-09 [email protected] Hide the rarely direct used `--sample` argument by default (flutter/flutter#171898) 2025-07-09 [email protected] Support `NO_COLOR` to opt-out of `flutter` tool ANSI colors (flutter/flutter#171892) 2025-07-09 [email protected] [Android 16] Added Docs to Warn Users that SystemChrome.setPreferredOrientations will Not Work (flutter/flutter#171089) 2025-07-09 [email protected] Add analytics events for wasm dry runs on web builds (flutter/flutter#171818) 2025-07-09 [email protected] feat: new builders for size experiment (flutter/flutter#171886) 2025-07-09 [email protected] Update `.gitignore`s (flutter/flutter#171907) 2025-07-09 [email protected] Add total execution time to the flutter upgrade command (flutter/flutter#171475) 2025-07-09 [email protected] Simplify the template for infrastructure requests (flutter/flutter#171905) 2025-07-09 [email protected] Add detailed error message for BorderRadiusDirectional (flutter/flutter#171805) 2025-07-09 [email protected] Add public postmortem of the 3.32.3 release. (flutter/flutter#171904) 2025-07-09 [email protected] Make `labels` field an array (flutter/flutter#171906) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (#171897)" (flutter/flutter#171910) 2025-07-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Packages from cba2e90 to 4a231ae (5 revisions) (#171879)" (flutter/flutter#171897) 2025-07-09 [email protected] [skia] Fix flag fiddling for Fuchsia, FreeType, & friends (flutter/flutter#171874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.