[web] Remove all usages of js_util. #171871

ksokolovskyi · 2025-07-09T13:34:29Z

Description

Removes js_util library usage across the codebase

In order to get rid of dart.library.js_util in kIsWeb constant the dart analyzer has to be updated first. For now, the dart.library.js_util value is hardcoded in the source code: https://github.com/dart-lang/sdk/blob/1a88edceb75f70490827ef845586bf549d5f05b0/pkg/analyzer/lib/src/dart/constant/evaluation.dart#L2908-L2915. So we either have to update this value or wait for the dart-lang/sdk#50045 fix.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

mdebbar

Thanks for helping out with this cleanup!

I'm curious why you reverted the kIsWeb change?

engine/src/flutter/lib/web_ui/test/canvaskit/surface_test.dart

ksokolovskyi · 2025-07-09T17:10:55Z

Thanks for helping out with this cleanup!

I'm curious why you reverted the kIsWeb change?

Hi @mdebbar! First of all, thanks for the review!

This is an interesting moment. While changing the kIsWeb value from dart.library.js_util to dart.library.js_interop works well, the analyzer starts to complain in some widgets.

Basically, for the analyzer, this value is false and the value in the ternary operator is equal to the default value in the constructor, which triggers avoid_redundant_argument_values lint.
We could add an inline analyzer ignore with comments, but I think that it would be better to either update this value in the analyzer source or wait for the dart-lang/sdk#50045 fix.

mdebbar · 2025-07-10T14:23:29Z

@srujzs any idea why this works:

const bool kIsWeb = bool.fromEnvironment('dart.library.js_util');

but this doesn't:

const bool kIsWeb = bool.fromEnvironment('dart.library.js_interop');

ksokolovskyi · 2025-07-10T14:36:35Z

@mdebbar I've added some interop members as you requested.

Regarding your last question, actually kIsWeb with 'dart.library.js_interop' value works as expected and is true when running on web. The issue is that the analyzer treats the kIsWeb value as false, so the Dart team added a special case handling for dart.library.js_interop here: https://github.com/dart-lang/sdk/blob/83d862217e5960cc1e8055312f950d29d7803f7e/pkg/analyzer/lib/src/dart/constant/evaluation.dart#L2909

mdebbar · 2025-07-10T15:46:23Z

@ksokolovskyi Ah I see now. You explained it in your previous comment too but I didn't catch it :P

@mkustermann @srujzs @scheglov could someone help us with the analyzer issue so we can fully migrate off of dart:js_util?

srujzs · 2025-07-10T15:53:43Z

It seems like the ideal fix is waiting for dart-lang/sdk#50045 to be resolved, but it doesn't look like that's an easy/simple fix so we should have a special case for js_interop as well like we did with js_util. @scheglov, any objections?

srujzs · 2025-07-10T17:54:04Z

https://dart-review.googlesource.com/c/sdk/+/439820 has landed to workaround this issue for dart:js_interop.

ksokolovskyi · 2025-07-10T18:06:12Z

@srujzs thanks a lot for your workaround!
I will wait for the roller to pick it up and then update kIsWeb.

mdebbar

Thanks @srujzs for the quick help!

Everything looks good to me. Once the analyzer change rolls into Flutter and kIsWeb is updated, we can go ahead and land this PR.

engine/src/flutter/lib/web_ui/lib/src/engine/js_interop/js_app.dart

engine/src/flutter/lib/web_ui/test/engine/view_embedder/flutter_view_manager_test.dart

engine/src/flutter/lib/web_ui/test/engine/window_test.dart

mdebbar

A couple minor suggestions that I missed previously. Other than that, looks good to me once we address the kIsWeb situation.

engine/src/flutter/lib/web_ui/test/canvaskit/surface_test.dart

srujzs · 2025-07-14T19:04:38Z

@srujzs Can this workaround be back ported to 7.x.x? If it's too much work or not possible to back port, then I'm okay with the lint ignores and a TODO.

This may be more complicated than I imagine but not sure. I suppose one can checkout the latest 7.x.x release, cherry-pick my change, and then release a new minor version and pub should be happy? It'd mess up the version history of main though. @scheglov, thoughts?

scheglov · 2025-07-14T21:44:57Z

The change is very small, so https://dart-review.googlesource.com/c/sdk/+/440263

scheglov · 2025-07-14T22:40:56Z

Published analyzer 7.5.8

ksokolovskyi · 2025-07-15T15:25:02Z

@scheglov, thanks a lot!

@srujzs @mdebbar I've locally updated the pubspec.yaml files in root and in flutter_tools like the following:

...
_fe_analyzer_shared: 85.0.0
analyzer: 7.5.9
...

But I still have analyzer issues in the IDE or when running flutter-dev analyze.
Do you have any thoughts about what I am missing?

mdebbar · 2025-07-15T16:42:48Z

But I still have analyzer issues in the IDE or when running flutter-dev analyze.
Do you have any thoughts about what I am missing?

This may be obvious, but did you also do flutter pub get?

ksokolovskyi · 2025-07-15T17:28:43Z

This may be obvious, but did you also do flutter pub get?

Yep. I am wondering how Linux analyze passed even without updating the analyzer dependency version 🤔

UPD: I removed bin/cache and downloaded all artifacts again. After that analyzer stopped yielding on kIsWeb usages as before. But I still don't know how this worked if analyzer is pinned to v7.4.5 in root pubspec.yaml.

srujzs

Just some small nits. LGTM!

engine/src/flutter/lib/web_ui/lib/src/engine/js_interop/js_loader.dart

engine/src/flutter/lib/web_ui/test/engine/pointer_binding_test.dart

ksokolovskyi · 2025-07-16T13:19:42Z

@srujzs thanks for your comments. Could you please take a quick look at the last commit and confirm that it is what you expected?

srujzs

Looks great, thanks for addressing the nits!

flutter/flutter@c2739f0...9c626d9 2025-07-17 [email protected] Roll Skia from 5b4afa58289a to 3673a1f26a63 (1 revision) (flutter/flutter#172274) 2025-07-17 [email protected] Roll Fuchsia Linux SDK from JRFUXSNXExcfjVYvA... to HXdm7P0a4ZJVm_TE-... (flutter/flutter#172268) 2025-07-17 [email protected] Roll Dart SDK from d71df90177e4 to 486f9c0663bc (1 revision) (flutter/flutter#172269) 2025-07-17 [email protected] Roll Skia from 3ad1aace3e02 to 5b4afa58289a (3 revisions) (flutter/flutter#172264) 2025-07-17 [email protected] Perform OpenGL compositing in the Flutter thread and write to a framebuffer. (flutter/flutter#172090) 2025-07-17 [email protected] Licenses cpp 716 (flutter/flutter#172261) 2025-07-16 [email protected] Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter/flutter#172256) 2025-07-16 [email protected] Roll Skia from bf3f9b77d3a8 to 3ad1aace3e02 (11 revisions) (flutter/flutter#172255) 2025-07-16 [email protected] Sync `CHANGELOG.md` (3.32.7) to `master` branch (flutter/flutter#172253) 2025-07-16 [email protected] Properly lay out and position RenderWebImage (flutter/flutter#171916) 2025-07-16 [email protected] Remove dead link in the doc index. (flutter/flutter#172240) 2025-07-16 [email protected] Roll Dart SDK from 766ee8029b11 to d71df90177e4 (1 revision) (flutter/flutter#172243) 2025-07-16 [email protected] Fix use of `Join-Path` in `last_engine_commit.ps1`(poweshell) (flutter/flutter#172242) 2025-07-16 [email protected] Marks Linux_pixel_7pro integration_ui_driver to be unflaky (flutter/flutter#172213) 2025-07-16 [email protected] [skwasm] Decrease reliance on finalizers/GC (flutter/flutter#172187) 2025-07-16 [email protected] Use `release-*.version` to simplify `last_engine_commit.sh` (no branch operations) (flutter/flutter#172236) 2025-07-16 [email protected] Roll Skia from 59be8479c637 to bf3f9b77d3a8 (7 revisions) (flutter/flutter#172233) 2025-07-16 [email protected] [web] Remove all usages of js_util. (flutter/flutter#171871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9641) flutter/flutter@c2739f0...9c626d9 2025-07-17 [email protected] Roll Skia from 5b4afa58289a to 3673a1f26a63 (1 revision) (flutter/flutter#172274) 2025-07-17 [email protected] Roll Fuchsia Linux SDK from JRFUXSNXExcfjVYvA... to HXdm7P0a4ZJVm_TE-... (flutter/flutter#172268) 2025-07-17 [email protected] Roll Dart SDK from d71df90177e4 to 486f9c0663bc (1 revision) (flutter/flutter#172269) 2025-07-17 [email protected] Roll Skia from 3ad1aace3e02 to 5b4afa58289a (3 revisions) (flutter/flutter#172264) 2025-07-17 [email protected] Perform OpenGL compositing in the Flutter thread and write to a framebuffer. (flutter/flutter#172090) 2025-07-17 [email protected] Licenses cpp 716 (flutter/flutter#172261) 2025-07-16 [email protected] Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter/flutter#172256) 2025-07-16 [email protected] Roll Skia from bf3f9b77d3a8 to 3ad1aace3e02 (11 revisions) (flutter/flutter#172255) 2025-07-16 [email protected] Sync `CHANGELOG.md` (3.32.7) to `master` branch (flutter/flutter#172253) 2025-07-16 [email protected] Properly lay out and position RenderWebImage (flutter/flutter#171916) 2025-07-16 [email protected] Remove dead link in the doc index. (flutter/flutter#172240) 2025-07-16 [email protected] Roll Dart SDK from 766ee8029b11 to d71df90177e4 (1 revision) (flutter/flutter#172243) 2025-07-16 [email protected] Fix use of `Join-Path` in `last_engine_commit.ps1`(poweshell) (flutter/flutter#172242) 2025-07-16 [email protected] Marks Linux_pixel_7pro integration_ui_driver to be unflaky (flutter/flutter#172213) 2025-07-16 [email protected] [skwasm] Decrease reliance on finalizers/GC (flutter/flutter#172187) 2025-07-16 [email protected] Use `release-*.version` to simplify `last_engine_commit.sh` (no branch operations) (flutter/flutter#172236) 2025-07-16 [email protected] Roll Skia from 59be8479c637 to bf3f9b77d3a8 (7 revisions) (flutter/flutter#172233) 2025-07-16 [email protected] [web] Remove all usages of js_util. (flutter/flutter#171871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Remove all usages of js_util.

89165ea

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jul 9, 2025

ksokolovskyi requested review from ditman, harryterkelsen and mdebbar and removed request for harryterkelsen and mdebbar July 9, 2025 13:36

ksokolovskyi added 2 commits July 9, 2025 16:32

Merge branch 'master' into remove-all-usages-of-js-util

7005a07

Revert kIsWeb.

42f9544

mdebbar reviewed Jul 9, 2025

View reviewed changes

Add missing CanvasKit interop members.

fb8e20f

ksokolovskyi added 2 commits July 10, 2025 16:24

Add more interop members.

9288327

Replace jsify call with JsFlutterViewOptions creation.

920d087

mdebbar reviewed Jul 11, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/lib/src/engine/js_interop/js_app.dart Outdated Show resolved Hide resolved

engine/src/flutter/lib/web_ui/test/engine/view_embedder/flutter_view_manager_test.dart Outdated Show resolved Hide resolved

srujzs reviewed Jul 11, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/test/engine/window_test.dart Outdated Show resolved Hide resolved

ksokolovskyi added 3 commits July 14, 2025 09:48

Merge branch 'master' into remove-all-usages-of-js-util

2ab4190

Simplify some calls.

43f48ce

Simplify more calls.

3c7eeed

mdebbar approved these changes Jul 14, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/test/canvaskit/surface_test.dart Outdated Show resolved Hide resolved

engine/src/flutter/lib/web_ui/test/canvaskit/surface_test.dart Outdated Show resolved Hide resolved

ksokolovskyi added 3 commits July 15, 2025 17:03

Merge branch 'master' into remove-all-usages-of-js-util

155c05d

Simplify some tests.

a84ee89

Update kIsWeb.

9c2040a

ksokolovskyi requested a review from srujzs July 15, 2025 17:36

srujzs approved these changes Jul 15, 2025

View reviewed changes

ksokolovskyi added 2 commits July 16, 2025 11:58

Merge branch 'master' into remove-all-usages-of-js-util

0f97f98

Apply review suggestions.

631e665

srujzs approved these changes Jul 16, 2025

View reviewed changes

ksokolovskyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025

auto-submit bot added this pull request to the merge queue Jul 16, 2025

Merged via the queue into flutter:master with commit 66281ce Jul 16, 2025
177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2025

66281ce52 [web] Remove all usages of js_util. (flutter/flutter#171871)

4b165e1

engine-flutter-autoroll mentioned this pull request Jul 17, 2025

Roll Flutter from c2739f0dcc39 to 9c626d9f9afa (18 revisions) flutter/packages#9641

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

66281ce52 [web] Remove all usages of js_util. (flutter/flutter#171871)

428fc0b

[web] Remove all usages of js_util. #171871

[web] Remove all usages of js_util. #171871

Uh oh!

Conversation

ksokolovskyi commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pre-launch Checklist

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksokolovskyi commented Jul 9, 2025

Uh oh!

mdebbar commented Jul 10, 2025

Uh oh!

ksokolovskyi commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdebbar commented Jul 10, 2025

Uh oh!

srujzs commented Jul 10, 2025

Uh oh!

srujzs commented Jul 10, 2025

Uh oh!

ksokolovskyi commented Jul 10, 2025

Uh oh!

mdebbar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

srujzs commented Jul 14, 2025

Uh oh!

scheglov commented Jul 14, 2025

Uh oh!

scheglov commented Jul 14, 2025

Uh oh!

ksokolovskyi commented Jul 15, 2025

Uh oh!

mdebbar commented Jul 15, 2025

Uh oh!

ksokolovskyi commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srujzs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksokolovskyi commented Jul 16, 2025

Uh oh!

srujzs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ksokolovskyi commented Jul 9, 2025 •

edited

Loading

ksokolovskyi commented Jul 10, 2025 •

edited

Loading

mdebbar left a comment •

edited

Loading

ksokolovskyi commented Jul 15, 2025 •

edited

Loading