[Impeller] Optimize scale translate rectangle transforms #171841
Conversation
github-actions
bot
added
engine
|
Thanks for the approval, but I'm still investigating why goldens changed with this. I could imagine that there might be some "bit error" changes, but the goldens reported are actually off by an entire pixel. I'm guessing there is a case of "round to nearest integer" that we are triggering moving from one integer to the next by the math being slightly different, but I want to verify that first (and see if there isn't a way to mitigate it down to "off-by-1-component-step" instead) before I push... |
|
For triage: Jim is stashing this for a bit. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Updating the base commit fixed the goldens, so this is ready to go in. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
removed
the
autosubmit
…10116) Manual roll requested by [email protected] flutter/flutter@b1a28bc...6cc976e 2025-09-25 [email protected] [Impeller] Optimize scale translate rectangle transforms (flutter/flutter#171841) 2025-09-25 [email protected] [time_picker] refactor: Distinguish widgets for dial mode only (flutter/flutter#173188) 2025-09-25 [email protected] Reapply "Update the AccessibilityPlugin::Announce method to account f… (flutter/flutter#174365) 2025-09-25 [email protected] Put Linux firebase_release_smoke_test on bringup (flutter/flutter#176043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Taken partially from flutter#170446 with only the changes to add a ScaleTranslate rectangle transform method brought over. Unlike the original PR, this PR will apply that optimized method for any caller who transforms a rectangle rather than just the matrix/clip tracker for the engine layer tree code. A benchmark for the new methods is also provided to verify their improved performance.
…utter#176061) Reverts flutter#171841 There appear to have been some golden file changes that disappeared as the change was further tested and are now causing problems.
2 participants
Taken partially from #170446 with only the changes to add a ScaleTranslate rectangle transform method brought over. Unlike the original PR, this PR will apply that optimized method for any caller who transforms a rectangle rather than just the matrix/clip tracker for the engine layer tree code.
A benchmark for the new methods is also provided to verify their improved performance.