Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jul 7, 2025

The command was parsing stdout assuming all contents were JSON.

Fixes #58391

…`flutter analyze --watch`

The command was parsing stdout assuming all contents were JSON.

Fixes #58391
@bkonyi bkonyi requested a review from matanlurey July 7, 2025 16:32
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2025

autosubmit label was removed for flutter/flutter/171713, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 7, 2025

autosubmit label was removed for flutter/flutter/171713, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 7, 2025
Merged via the queue into master with commit 9de6f68 Jul 7, 2025
144 of 145 checks passed
@auto-submit auto-submit bot deleted the fix_58391 branch July 7, 2025 21:35
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 8, 2025
flutter/flutter@28a4e85...adffe24

2025-07-08 [email protected] Roll Skia from 0669913308d3 to e159882c6ce0 (1 revision) (flutter/flutter#171766)
2025-07-08 [email protected] Roll Skia from 36b1f71fc14f to 0669913308d3 (4 revisions) (flutter/flutter#171756)
2025-07-08 [email protected] Roll Skia from f35536730dea to 36b1f71fc14f (3 revisions) (flutter/flutter#171751)
2025-07-08 [email protected] Roll Skia from 05374bbe5377 to f35536730dea (1 revision) (flutter/flutter#171744)
2025-07-08 [email protected] Roll Skia from 4968a30d721c to 05374bbe5377 (2 revisions) (flutter/flutter#171742)
2025-07-08 [email protected] Roll Skia from ad5c330487f7 to 4968a30d721c (8 revisions) (flutter/flutter#171739)
2025-07-08 [email protected] feat: Use engine_stamp.json in flutter tool (flutter/flutter#171454)
2025-07-08 [email protected] [ Tool ] Remove long-deprecated `make-host-app-editable` (flutter/flutter#171715)
2025-07-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (#171399)" (flutter/flutter#171736)
2025-07-07 [email protected] Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (flutter/flutter#171399)
2025-07-07 [email protected] [android] release background image readers on <= Android 14 (flutter/flutter#171193)
2025-07-07 [email protected] [ Tool ] Fix crash when SIGQUIT is sent to enable the VM service for `flutter analyze --watch` (flutter/flutter#171713)
2025-07-07 [email protected] Roll Skia from 47a5693d191a to ad5c330487f7 (2 revisions) (flutter/flutter#171716)
2025-07-07 [email protected] Run hot_reload_web_test.dart on Mac/Windows (flutter/flutter#171279)
2025-07-07 [email protected] Roll Fuchsia Linux SDK from 2DeZD1utFrnSwUfVT... to AinHuT0vgOelA1g7_... (flutter/flutter#171700)
2025-07-07 [email protected] [ Tool ] Prepare for enabling `omit_obvious_*_types` and `specify_nonobvious_*_types` (flutter/flutter#171651)
2025-07-07 [email protected] Roll Packages from e4fd6c0 to 2c52f24 (1 revision) (flutter/flutter#171705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…`flutter analyze --watch` (flutter#171713)

The command was parsing stdout assuming all contents were JSON.

Fixes flutter#58391
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
…`flutter analyze --watch` (flutter#171713)

The command was parsing stdout assuming all contents were JSON.

Fixes flutter#58391
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9580)

flutter/flutter@28a4e85...adffe24

2025-07-08 [email protected] Roll Skia from 0669913308d3 to e159882c6ce0 (1 revision) (flutter/flutter#171766)
2025-07-08 [email protected] Roll Skia from 36b1f71fc14f to 0669913308d3 (4 revisions) (flutter/flutter#171756)
2025-07-08 [email protected] Roll Skia from f35536730dea to 36b1f71fc14f (3 revisions) (flutter/flutter#171751)
2025-07-08 [email protected] Roll Skia from 05374bbe5377 to f35536730dea (1 revision) (flutter/flutter#171744)
2025-07-08 [email protected] Roll Skia from 4968a30d721c to 05374bbe5377 (2 revisions) (flutter/flutter#171742)
2025-07-08 [email protected] Roll Skia from ad5c330487f7 to 4968a30d721c (8 revisions) (flutter/flutter#171739)
2025-07-08 [email protected] feat: Use engine_stamp.json in flutter tool (flutter/flutter#171454)
2025-07-08 [email protected] [ Tool ] Remove long-deprecated `make-host-app-editable` (flutter/flutter#171715)
2025-07-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (#171399)" (flutter/flutter#171736)
2025-07-07 [email protected] Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (flutter/flutter#171399)
2025-07-07 [email protected] [android] release background image readers on <= Android 14 (flutter/flutter#171193)
2025-07-07 [email protected] [ Tool ] Fix crash when SIGQUIT is sent to enable the VM service for `flutter analyze --watch` (flutter/flutter#171713)
2025-07-07 [email protected] Roll Skia from 47a5693d191a to ad5c330487f7 (2 revisions) (flutter/flutter#171716)
2025-07-07 [email protected] Run hot_reload_web_test.dart on Mac/Windows (flutter/flutter#171279)
2025-07-07 [email protected] Roll Fuchsia Linux SDK from 2DeZD1utFrnSwUfVT... to AinHuT0vgOelA1g7_... (flutter/flutter#171700)
2025-07-07 [email protected] [ Tool ] Prepare for enabling `omit_obvious_*_types` and `specify_nonobvious_*_types` (flutter/flutter#171651)
2025-07-07 [email protected] Roll Packages from e4fd6c0 to 2c52f24 (1 revision) (flutter/flutter#171705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
…`flutter analyze --watch` (flutter#171713)

The command was parsing stdout assuming all contents were JSON.

Fixes flutter#58391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter tool crashes when you type Ctrl-\

2 participants