Skip to content

Re-combine reload error and restart test cases #171251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 27, 2025
Merged

Re-combine reload error and restart test cases #171251

auto-submit merged 3 commits into from
Jun 27, 2025

Conversation

@nshahan
Copy link
Contributor

@nshahan nshahan commented Jun 26, 2025 •
edited by mdebbar
Loading

Also add an explicit test case for reload rejection error followed by an expression evaluation.

These cases should work as expected now that this Dart SDK change has been rolled into Flutter https://dart-review.googlesource.com/c/sdk/+/434522.

Closes #170062

@nshahan
Re-combine reload error and restart test cases
d99327e 
Add explicit test case for reload rejection error followed by an
expression evaluation.

These cases should work as expected now that this Dart SDK change has
been rolled into Flutter https://dart-review.googlesource.com/c/sdk/+/434522.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 26, 2025
@nshahan nshahan requested review from mdebbar and srujzs June 27, 2025 19:22
@mdebbar mdebbar mentioned this pull request Jun 27, 2025
Closed
srujzs
srujzs approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the expression evaluation test. If the behavior ever regresses, we'll get a consistent failure now instead of a flaky one that arises with the hot restart (which in DWDS may or may not do an expression evaluation before the hot restart).

mdebbar
mdebbar approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the underlying issue and adding a more specific test!

LGTM

@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 27, 2025
Merged via the queue into flutter:master with commit 4a60bf2 Jun 27, 2025
139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
1ffed98 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
76333d9 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
94a5b3f 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
f55427c 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
b71e872 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
672fd46 
…tter#171251)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
41314fc 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
2155d1b 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c9fd847 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
d1b0cd4 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
3ab0b81 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c348659 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
9d99c07 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
a520c73 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c80dbd8 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
2b9635e 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
3171a18 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
aa2ac49 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
2e2d009 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
e43e2dc 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
2ecac84 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
29a1935 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
be0fa3e 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
83e85bb 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
e7b0c0a 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
b058bd2 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
cfdddb6 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
f03ce46 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
e482d9c 
…tter#171251)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@nshahan @mboetger
Re-combine reload error and restart test cases (flutter#171251)
39120df 
Also add an explicit test case for reload rejection error followed by an
expression evaluation.

These cases should work as expected now that this Dart SDK change has
been rolled into Flutter
https://dart-review.googlesource.com/c/sdk/+/434522.

Closes flutter#170062
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c6ef322 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
3ce0395 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c196019 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
3c60554 
…tter#171251)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
4a60bf22a Re-combine reload error and restart test cases (flutter/flu…
c813d94 
…tter#171251)
@nshahan nshahan deleted the add-expression-eval-test branch September 23, 2025 21:07
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@nshahan @lucaantonelli
Re-combine reload error and restart test cases (flutter#171251)
5be9af3 
Also add an explicit test case for reload rejection error followed by an
expression evaluation.

These cases should work as expected now that this Dart SDK change has
been rolled into Flutter
https://dart-review.googlesource.com/c/sdk/+/434522.

Closes flutter#170062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

@srujzs srujzs srujzs approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Hot reload/restart test flaky on Mac and Windows

3 participants

@nshahan @mdebbar @srujzs