Revert "[skwasm] Use transferToImageBitmap instead of createImageBitmap (#163251)"
#171238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itmap` (flutter#163251)" This reverts commit 7d22606. It turns out that in many scenarios, resizing the OffscreenCanvas multiple times per frame is prohibitively expensive. It also turns out that neither API works well enough on non-Chrome browsers to make it viable anyway, so we should switch back to `createImageBitmap`.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
eyebrowsoffire
changed the title
transferToImageBitmap instead of `createImageB…transferToImageBitmap instead of createImageBitmap (#163251)"
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
eyebrowsoffire
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 2, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 3, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 4, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 6, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 7, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…itmap` (flutter#163251)" (flutter#171238) This reverts commit 7d22606. It turns out that in many scenarios, resizing the OffscreenCanvas multiple times per frame is prohibitively expensive. It also turns out that neither API works well enough on non-Chrome browsers to make it viable anyway, so we should switch back to `createImageBitmap`.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…eateImageBitmap` (#163251)" (flutter/flutter#171238)
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…itmap` (flutter#163251)" (flutter#171238) This reverts commit 7d22606. It turns out that in many scenarios, resizing the OffscreenCanvas multiple times per frame is prohibitively expensive. It also turns out that neither API works well enough on non-Chrome browsers to make it viable anyway, so we should switch back to `createImageBitmap`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7d22606.
It turns out that in many scenarios, resizing the OffscreenCanvas multiple times per frame is prohibitively expensive. It also turns out that neither API works well enough on non-Chrome browsers to make it viable anyway, so we should switch back to
createImageBitmap.