Skip to content

[ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) #171002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Jun 23, 2025
Merged

[ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) #171002

auto-submit merged 4 commits into from
Jun 23, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jun 23, 2025

Issue Link:

dart-lang/sdk#60851

Changelog Description:

Fixes unhandled exception on application shutdown in the debug adapter used by IDEs.

Impact Description:

The Debug Adapter (DAP) could crash if it is waiting on specific RPCs from a target application while the application is shutting down.

Workaround:

None.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

This bug is extremely hard to reproduce reliably. Catching RPCError and checking for the correct error code related to the VM service disappearing is simple and low risk.

@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master June 23, 2025 14:17
@flutter-dashboard flutter-dashboard bot requested a review from matanlurey as a code owner June 23, 2025 14:17
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 23, 2025

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically e: impeller Impeller rendering backend issues and features requests d: docs/ flutter/flutter/docs, for contributors labels Jun 23, 2025
@bkonyi bkonyi changed the title [ Tool ] Roll DDS 5.0.3 (#170880) [ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) Jun 23, 2025
@bkonyi bkonyi removed a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 23, 2025
@bkonyi bkonyi added cp: review Cherry-picks in the review queue and removed platform-web Web applications specifically e: impeller Impeller rendering backend issues and features requests d: docs/ flutter/flutter/docs, for contributors labels Jun 23, 2025
@bkonyi bkonyi changed the base branch from master to stable June 23, 2025 14:18
matanlurey
matanlurey requested changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not possible to merge against stable, which is why the bot is trying to prevent you.

See https://github.com/flutter/flutter/blob/master/docs/releases/Flutter-Cherrypick-Process.md.

@bkonyi bkonyi changed the base branch from stable to flutter-3.32-candidate.0 June 23, 2025 16:31
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 23, 2025

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@bkonyi
Copy link
Contributor Author

bkonyi commented Jun 23, 2025

It is not possible to merge against stable, which is why the bot is trying to prevent you.

See https://github.com/flutter/flutter/blob/master/docs/releases/Flutter-Cherrypick-Process.md.

Whoops... switched to flutter-3.32-candidate.0. Not sure why the ci.yaml check is failing now though.

@matanlurey
Copy link
Contributor

matanlurey commented Jun 23, 2025

You'll need to push a blank commit, or recreate this PR, this is a corner-case in our CI infrastructure.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 23, 2025
@matanlurey
Copy link
Contributor

matanlurey commented Jun 23, 2025

@bkonyi Looks like it might be merging cleanly/safely (see test failures)?

@bkonyi
Copy link
Contributor Author

bkonyi commented Jun 23, 2025

Looks like this updated DWDS for some reason... Let me take a look.

@bkonyi
Copy link
Contributor Author

bkonyi commented Jun 23, 2025

Looks like this is good to go now @matanlurey.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@auto-submit auto-submit bot merged commit fdefa52 into flutter-3.32-candidate.0 Jun 23, 2025
148 checks passed
@auto-submit auto-submit bot deleted the dds_5.0.3_cp branch June 23, 2025 20:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll
fdefa52ce [ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) (flutter/flu…
022b48c 
…tter#171002)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2025
@engine-flutter-autoroll
fdefa52ce [ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) (flutter/flu…
ca60f73 
…tter#171002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkonyi @matanlurey @eyebrowsoffire