Fixed RenderFlex overflow in RouteObserver Example #170980

prash4931 · 2025-06-22T08:01:00Z

Fixed RenderOverflow in RouteObserver Example: https://api.flutter.dev/flutter/widgets/RouteObserver-class.html

This PR is about solving render overflow issue in Route Observer Example in Live Website. I've wrapped the body with a Scrollable View to solve this issue


B
A

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

Fixed RenderOverflow in RouteObserver Example: https://api.flutter.dev/flutter/widgets/RouteObserver-class.html

flutter-dashboard · 2025-06-22T08:01:04Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

victorsanni

Hi @prash4931, this PR will need a test. Tests for this file can be added in flutter/examples/api/test/widgets/routes/route_observer.0_test.dart.

examples/api/lib/widgets/routes/route_observer.0.dart

tirth-patel-nc · 2025-06-27T08:47:04Z

@prash4931 you do not need to merge or rebase every time something is pushed to master.

prash4931 · 2025-06-27T08:50:54Z

@prash4931 you do not need to merge or rebase every time something is pushed to master.

Noted

prash4931 · 2025-06-27T08:52:32Z

@tirth-patel-nc test cases already exist for this example at flutter/examples/api/test/widgets/routes/route_observer.0_test.dart. Do I need to add more test cases for this?

tirth-patel-nc · 2025-06-27T09:31:27Z

@tirth-patel-nc test cases already exist for this example at flutter/examples/api/test/widgets/routes/route_observer.0_test.dart. Do I need to add more test cases for this?

yes, as victor mentioned, we’ll need a test for the new change you’ve made. you can prolly add a small overflow test in that same file.

expect(tester.takeException(), isNull);

prash4931 · 2025-06-27T10:55:25Z

Hi @victorsanni, @tirth-patel-nc I've added the required tests. Please check

tirth-patel-nc

LGTM! Thanks for contributing 💙

examples/api/test/widgets/routes/route_observer.0_test.dart

victorsanni

Hi @prash4931, this PR will need a test to move forward. Thanks!

victorsanni · 2025-08-06T20:49:51Z

examples/api/test/widgets/routes/route_observer.0_test.dart

+    addTearDown(tester.binding.window.clearDevicePixelRatioTestValue);
+
+    // Build the RouteObserver example widget.
+    await tester.pumpWidget(


This is pumping a new MaterialApp. Example tests should test the example itself - in this case, by calling

await tester.pumpWidget(const example.RouteObserverApp());

as in the other test.

Is it not possible to test on example.RouteObserverApp()?

I got it working with this test:

testWidgets('RouteObserver example renders without overflow on small screens', ( WidgetTester tester, ) async { // Set the screen size to a smaller value. tester.binding.window.physicalSizeTestValue = const Size(200, 200); tester.binding.window.devicePixelRatioTestValue = 1.0; addTearDown(tester.binding.window.clearPhysicalSizeTestValue); addTearDown(tester.binding.window.clearDevicePixelRatioTestValue); // Build the RouteObserver example widget. await tester.pumpWidget(const example.RouteObserverApp()); await tester.pumpAndSettle(); // Verify there are no layout exceptions. expect(tester.takeException(), isNull); });

Hi @prash4931, this PR is ready to go once this test is replaced with the test in https://github.com/flutter/flutter/pull/170980/files#r2258335551.

victorsanni · 2025-08-06T20:52:59Z

examples/api/test/widgets/routes/route_observer.0_test.dart

+    tester.binding.window.physicalSizeTestValue = const Size(300, 600);
+    tester.binding.window.devicePixelRatioTestValue = 1.0;
+
+    // Rebuild the widget tree with the new window size.


This doesn't rebuild the widget tree with the new window size, it just tells the test framework to restore the window to its original size when the test is done.

flutter-dashboard · 2025-08-26T21:23:11Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

justinmc · 2025-09-16T22:16:38Z

@prash4931 Do you still have plans to finish this PR or should it be closed?

victorsanni · 2025-10-14T18:19:37Z

examples/api/test/widgets/routes/route_observer.0_test.dart

 // found in the LICENSE file.

 import 'package:flutter_api_samples/widgets/routes/route_observer.0.dart' as example;
+import 'package:flutter_api_samples/widgets/routes/route_observer.0.dart' show RouteObserverExample;


Is this import needed?

victorsanni · 2025-10-14T18:19:48Z

examples/api/test/widgets/routes/route_observer.0_test.dart

 import 'package:flutter_api_samples/widgets/routes/route_observer.0.dart' as example;
+import 'package:flutter_api_samples/widgets/routes/route_observer.0.dart' show RouteObserverExample;
 import 'package:flutter_test/flutter_test.dart';
+import 'package:flutter/material.dart';


And this import as well

justinmc · 2025-10-21T22:06:16Z

@prash4931 FYI you have an analyzer failure here, but we'd love to merge this if you have time to update it!

examples/api/test/widgets/routes/route_observer.0_test.dart

prash4931 · 2025-10-30T13:42:46Z

@victorsanni please review the changes

victorsanni

Last comment I have is about the added Material import in the test. Is that needed?

Piinks · 2025-11-11T23:19:13Z

Hey @prash4931 it looks like this comment needs to be addressed before we can merge this: #170980 (comment)

examples/api/test/widgets/routes/route_observer.0_test.dart

Piinks · 2025-12-09T23:24:06Z

@prash4931 it looks like only a few merge conflicts are left to resolve, would you like to return to this?

…/flutter#170980)

…10601) Manual roll Flutter from 6a1f5b7f85a4 to e25d71b086d6 (30 revisions) Manual roll requested by [email protected] flutter/flutter@6a1f5b7...e25d71b 2025-12-10 [email protected] Ensure that the engine converts std::filesystem::path objects to UTF-8 strings on Windows (flutter/flutter#179528) 2025-12-10 [email protected] Fix the issue with pinned headers in nested SliverMainAxisGroup. (flutter/flutter#179132) 2025-12-10 [email protected] added onUserInteractionIfError for form (flutter/flutter#175515) 2025-12-10 [email protected] Fixed RenderFlex overflow in RouteObserver Example (flutter/flutter#170980) 2025-12-10 [email protected] Roll Dart SDK from 17749965ec57 to 077062c5e515 (3 revisions) (flutter/flutter#179691) 2025-12-10 [email protected] Manually roll characters (flutter/flutter#179447) 2025-12-10 [email protected] Roll Packages from 338ecd3 to 74a5a53 (4 revisions) (flutter/flutter#179693) 2025-12-10 [email protected] Marks Mac_ios draw_arcs_all_stroke_styles_perf_ios__timeline_summary to be unflaky (flutter/flutter#179669) 2025-12-10 [email protected] Check for a null cached image in SingleFrameCodec::getNextFrame (flutter/flutter#179483) 2025-12-10 [email protected] Roll Fuchsia Linux SDK from _pSztGZvEA3-Ry-GW... to u5vxWTRT0HlxOP5_r... (flutter/flutter#179652) 2025-12-10 [email protected] Implement flutter/accessibility channel (flutter/flutter#179484) 2025-12-10 [email protected] Roll Skia from 82fff05cc621 to e61cc6d073fd (4 revisions) (flutter/flutter#179646) 2025-12-10 [email protected] Make sure that a CupertinoDialogAction doesn't crash in 0x0 environment (flutter/flutter#178956) 2025-12-10 [email protected] Make SettingsChannel configuration queue not static (flutter/flutter#179636) 2025-12-10 [email protected] Make sure that a CupertinoListSection doesn't crash in 0x0 environment (flutter/flutter#179068) 2025-12-10 [email protected] Make sure that a CupertinoFormSection doesn't crash in 0x0 environment (flutter/flutter#179001) 2025-12-10 [email protected] Make sure that a CupertinoMagnifier doesn't crash in 0x0 environment (flutter/flutter#179206) 2025-12-10 [email protected] Make sure that a Tooltip doesn't crash in 0x0 environment (flutter/flutter#178461) 2025-12-10 [email protected] Make sure that a CupertinoSegmentedControl doesn't crash in 0x0 envir… (flutter/flutter#179544) 2025-12-10 [email protected] Make sure that a CupertinoSlider doesn't crash in 0x0 environment (flutter/flutter#179566) 2025-12-10 [email protected] Make sure that a CupertinoPageScaffold doesn't crash in 0x0 environment (flutter/flutter#179245) 2025-12-09 [email protected] Roll Skia from f9e32c28c5c5 to 82fff05cc621 (2 revisions) (flutter/flutter#179641) 2025-12-09 [email protected] Roll Dart SDK from 019cb923bf62 to 17749965ec57 (5 revisions) (flutter/flutter#179640) 2025-12-09 [email protected] Enhance documentation for `LocalHistoryEntry` class (flutter/flutter#179223) 2025-12-09 [email protected] WebParagrah: ellipsis (flutter/flutter#178748) 2025-12-09 [email protected] Update the doc on Google Testing to reflect the current state (flutter/flutter#177187) 2025-12-09 [email protected] [wimp] Initial Impeller on Web implementation. (flutter/flutter#175442) 2025-12-09 [email protected] Relax assertion for adding semantics locale (flutter/flutter#178140) 2025-12-09 [email protected] Fix Scrollbar drag behavior (flutter/flutter#179199) 2025-12-09 [email protected] Roll Skia from 502ee6f2a0d7 to f9e32c28c5c5 (6 revisions) (flutter/flutter#179632) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

Fixed RenderFlex overflow in RouteObserver Example

0eb03b2

Fixed RenderOverflow in RouteObserver Example: https://api.flutter.dev/flutter/widgets/RouteObserver-class.html

Merge remote-tracking branch 'upstream/master'

0aacb73

justinmc requested a review from victorsanni June 24, 2025 22:10

victorsanni reviewed Jun 25, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/master'

844ffe1

tirth-patel-nc requested changes Jun 26, 2025

View reviewed changes

examples/api/lib/widgets/routes/route_observer.0.dart Show resolved Hide resolved

examples/api/lib/widgets/routes/route_observer.0.dart Show resolved Hide resolved

prash4931 and others added 7 commits June 26, 2025 22:05

Merge branch 'master' into master

32f55c1

Update route_observer.0.dart

9fd6cfc

Merge branch 'master' of https://github.com/prash4931/flutter

33a56fe

Merge branch 'master' into master

ced8921

Update route_observer.0.dart

464abe1

Merge remote-tracking branch 'upstream/master'

7b56bc2

Merge remote-tracking branch 'upstream/master'

1224a17

prash4931 and others added 2 commits June 27, 2025 15:48

Added Test Case for Overflow/Layout Occurrence

fe81cad

Merge branch 'master' into master

19f7273

prash4931 requested a review from tirth-patel-nc June 27, 2025 10:54

prash4931 requested a review from victorsanni June 27, 2025 10:55

tirth-patel-nc approved these changes Jun 27, 2025

View reviewed changes

victorsanni reviewed Jun 27, 2025

View reviewed changes

examples/api/test/widgets/routes/route_observer.0_test.dart Show resolved Hide resolved

victorsanni requested changes Jul 21, 2025

View reviewed changes

victorsanni reviewed Aug 6, 2025

View reviewed changes

prash4931 and others added 2 commits October 14, 2025 10:31

Update route_observer.0_test.dart

92df99f

Merge branch 'master' into master

ed36189

victorsanni reviewed Oct 14, 2025

View reviewed changes

prash4931 and others added 3 commits October 23, 2025 22:34

Fixed Imports

209d69d

Merge branch 'master' of https://github.com/prash4931/flutter

009a4d5

Merge branch 'master' into master

6f2e017

victorsanni reviewed Oct 23, 2025

View reviewed changes

examples/api/test/widgets/routes/route_observer.0_test.dart Outdated Show resolved Hide resolved

victorsanni reviewed Oct 30, 2025

View reviewed changes

victorsanni approved these changes Nov 22, 2025

View reviewed changes

examples/api/test/widgets/routes/route_observer.0_test.dart Outdated Show resolved Hide resolved

victorsanni added 2 commits November 21, 2025 17:12

Update examples/api/test/widgets/routes/route_observer.0_test.dart

b422a90

Merge branch 'master' into master

ce5cc2d

victorsanni added 2 commits December 10, 2025 10:09

Merge branch 'master' into master

1286481

Refactor testWidgets for RouteObserver example

3bac923

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2025

auto-submit bot added this pull request to the merge queue Dec 10, 2025

Merged via the queue into flutter:master with commit 2c4e7eb Dec 10, 2025
44 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 10, 2025

engine-flutter-autoroll mentioned this pull request Dec 10, 2025

Manual roll Flutter from 6a1f5b7f85a4 to e25d71b086d6 (30 revisions) flutter/packages#10601

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 10, 2025

2c4e7ebfd Fixed RenderFlex overflow in RouteObserver Example (flutter…

ac41525

…/flutter#170980)

Fixed RenderFlex overflow in RouteObserver Example #170980

Fixed RenderFlex overflow in RouteObserver Example #170980

Conversation

prash4931 commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 22, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tirth-patel-nc commented Jun 27, 2025

Uh oh!

prash4931 commented Jun 27, 2025 • edited by tirth-patel-nc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prash4931 commented Jun 27, 2025

Uh oh!

tirth-patel-nc commented Jun 27, 2025

Uh oh!

prash4931 commented Jun 27, 2025

Uh oh!

tirth-patel-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Aug 26, 2025

Uh oh!

justinmc commented Sep 16, 2025

Uh oh!

victorsanni Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc commented Oct 21, 2025

Uh oh!

Uh oh!

prash4931 commented Oct 30, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Nov 11, 2025

Uh oh!

Uh oh!

Piinks commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

prash4931 commented Jun 22, 2025 •

edited

Loading

prash4931 commented Jun 27, 2025 •

edited by tirth-patel-nc

Loading