Skip to content

Add --profile-microtasks flag to flutter run #170877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derekxu16 merged 1 commit into from
Jul 3, 2025
Merged

Add --profile-microtasks flag to flutter run #170877

derekxu16 merged 1 commit into from
Jul 3, 2025

Conversation

@derekxu16
Copy link
Contributor

@derekxu16 derekxu16 commented Jun 19, 2025

This PR adds a --profile-microtasks flag to flutter run that can be used to set the Flutter Engine's --profile-microtasks switch.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Jun 19, 2025
@derekxu16 derekxu16 requested a review from bkonyi June 30, 2025 17:50
@derekxu16 derekxu16 marked this pull request as ready for review June 30, 2025 17:50
@derekxu16 derekxu16 requested review from a team as code owners June 30, 2025 17:50
reidbaker
reidbaker reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level why default profile microtasks to true instead of false?

@derekxu16
Copy link
Contributor Author

derekxu16 commented Jun 30, 2025

At a high level why default profile microtasks to true instead of false?

Can you point me to where it's being defaulted to true? If I did that, it was by mistake.

reidbaker
reidbaker approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry on a second read the places I thought were defaults were all either validating the value which was set in a test or responding to the flag being set.

@derekxu16 derekxu16 added this pull request to the merge queue Jul 3, 2025
Merged via the queue into flutter:master with commit d0d68fc Jul 3, 2025
137 checks passed
@derekxu16 derekxu16 deleted the add-profile-microtasks-flag branch July 3, 2025 17:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
b5daa1e 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
bd50aca 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
1994b04 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
2cd7102 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
e44ec2e 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
d8fdbf8 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
e80278b 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
60753d9 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
cb73a2b 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
73e932b 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
129f66e 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
e893fca 
…lutter#170877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
5e008a3 
…lutter#170877)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@derekxu16 @mboetger
Add --profile-microtasks flag to flutter run (flutter#170877)
befe7a6 
This PR adds a `--profile-microtasks` flag to `flutter run` that can be
used to set [the Flutter Engine's `--profile-microtasks`
switch](flutter#170690).
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
@derekxu16 @azatech
Add --profile-microtasks flag to flutter run (flutter#170877)
fa14f4e 
This PR adds a `--profile-microtasks` flag to `flutter run` that can be
used to set [the Flutter Engine's `--profile-microtasks`
switch](flutter#170690).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
960c8e1 
…lutter#170877)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
af70ba2 
…lutter#170877)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
6f38ebe 
…lutter#170877)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
0a59491 
…lutter#170877)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
d0d68fc0c Add --profile-microtasks flag to flutter run (flutter/f…
3459c50 
…lutter#170877)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@derekxu16 @lucaantonelli
Add --profile-microtasks flag to flutter run (flutter#170877)
78deee2 
This PR adds a `--profile-microtasks` flag to `flutter run` that can be
used to set [the Flutter Engine's `--profile-microtasks`
switch](flutter#170690).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekxu16 @reidbaker @bkonyi