Skip to content

Conversation

@robert-ancell
Copy link
Contributor

Defaults to the same black as before, but this makes it easier for this to be overridden if necessary.

Defaults to the same black as before, but this makes it easier for this to be
overridden if necessary.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 18, 2025
@robert-ancell robert-ancell requested a review from mattkae June 18, 2025 22:02
@stuartmorgan-g
Copy link
Contributor

test-exempt: code refactor with no semantic change

Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough :)

@mattkae mattkae added this pull request to the merge queue Jun 20, 2025
Merged via the queue into flutter:master with commit d43d392 Jun 20, 2025
139 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 20, 2025
flutter/flutter@85a9b4f...c7362b4

2025-06-20 [email protected] [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 [email protected] Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 [email protected] Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 [email protected] Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 [email protected] Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 [email protected] Roll pub packages (flutter/flutter#170907)
2025-06-20 [email protected] Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 [email protected] Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 [email protected] Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 [email protected] Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 [email protected] Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 [email protected] [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 [email protected] Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 [email protected] Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@robert-ancell robert-ancell deleted the linux-template-background branch June 22, 2025 23:11
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9466)

flutter/flutter@85a9b4f...c7362b4

2025-06-20 [email protected] [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 [email protected] Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 [email protected] Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 [email protected] Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 [email protected] Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 [email protected] Roll pub packages (flutter/flutter#170907)
2025-06-20 [email protected] Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 [email protected] Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 [email protected] Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 [email protected] Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 [email protected] Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 [email protected] [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 [email protected] Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 [email protected] Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
Defaults to the same black as before, but this makes it easier for this
to be overridden if necessary.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9466)

flutter/flutter@85a9b4f...c7362b4

2025-06-20 [email protected] [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 [email protected] Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 [email protected] Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 [email protected] Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 [email protected] Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 [email protected] Roll pub packages (flutter/flutter#170907)
2025-06-20 [email protected] Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 [email protected] Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 [email protected] Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 [email protected] Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 [email protected] Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 [email protected] [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 [email protected] Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 [email protected] Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants