Clear background in the GTK layer, instead of OpenGL #170840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since OpenGL was being blitted, it would overwrite the color set with clear color anyway. Also fix the software rendering case that was not setting any background. This could cause a black screen to show by default, if you want the previous behaviour set the view background to transparent with: ``` GdkRGBA background_color; gdk_rgba_parse(&background_color, "#00000000"); fl_view_set_background_color(view, &background_color); ```
github-actions
bot
added
engine
Contributor
Author
|
Made #170841 to make it easier for developers to override the background if necessary. |
Contributor
Author
|
Changed the template to show the window on the first frame, to avoid showing a window with black background flashing up: #170844 |
mattkae
approved these changes
Jun 20, 2025
Contributor
mattkae
left a comment
mattkae
left a comment
There was a problem hiding this comment.
One nit, but feel free to merge after :)
Co-authored-by: Matthew Kosarek <[email protected]>
robert-ancell
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 23, 2025
flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
Since OpenGL was being blitted, it would overwrite the color set with clear color anyway. Also fix the software rendering case that was not setting any background. This could cause a black screen to show by default, if you want the previous behaviour set the view background to transparent with: ``` GdkRGBA background_color; gdk_rgba_parse(&background_color, "#00000000"); fl_view_set_background_color(view, &background_color); ``` --------- Co-authored-by: Matthew Kosarek <[email protected]>
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenGL was being blitted, it would overwrite the color set with clear color anyway. Also fix the software rendering case that was not setting any background.
This could cause a black screen to show by default, if you want the previous behaviour set the view background to transparent with: