[web] Roll Chrome to version 138 #170760
[web] Roll Chrome to version 138 #170760
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
| final List<String> args = <String>[ | ||
| '--user-data-dir=$dir', | ||
| kBlankPageUrl, | ||
| url.toString(), |
There was a problem hiding this comment.
Wow, so this was the issue? Nice job tracking it down!!
|
Doesn't seem to work? All of the |
github-actions
bot
added
a: tests
github-actions
bot
removed
a: tests
|
This still doesn't work. I'm trying to debug what's going wrong with Skwasm on the latest Chrome for Testing binaries. I am able to reproduce the timeout locally now. I suspect it has to do with the same problem that was causing the focus tests to break, which is that Chrome Devtools is taking focus from the page under test and causing the OffscreenCanvas to not generate bitmaps. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Greetings from stale PR triage! 👋 |
mdebbar
changed the title
Deconstruct #170760 to land more pieces of it.
Deconstruct flutter#170760 to land more pieces of it.
4 participants
This updates the Chrome version used for testing to 138.
This also updates how we set up Chrome Devtools Protocol to avoid focus issues when the page running the test isn't focused.
Fixes #168686
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.