Update some semantics flags updated to use enum (engine, framework, web) #170696

hannah-hyj · 2025-06-16T20:03:21Z

new Updates :
Add new enum Tristate and CheckedState in for 7 flags.
For CheckState, it used to use 3 bools (hasCheck, isChecked, isCheckStateMixed) to represent check states, replace them with a CheckState enum.
For other 6 flags, each has 2 bools (hasXXState and isXX), replace them with a Tristate enum.

This will be a breaking changes to the SemanticsFlags class , which was added in April in #166101 and #167771 , will write a breaking change doc for this PR

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai

LGTM

ash2moon · 2025-06-25T00:01:04Z

packages/flutter/lib/src/semantics/semantics.dart

  /// Whether the owning [RenderObject] can hold the input focus.
-  bool get isFocusable => _flags.isFocusable;
+  bool get isFocusable => _flags.isFocused != Tristate.none;
  set isFocusable(bool value) {


This part seems a little complex. Would you mind providing some code comments explaining what a true/false value in isFocusable will translate to in the Tristate and why?

flutter-dashboard · 2025-07-15T00:10:43Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

mdebbar

Web changes look good!

jmagman · 2025-08-14T17:26:42Z

@hannah-hyj are you waiting for any other reviews?

hannah-hyj · 2025-08-14T17:28:09Z

This PR is blocked by #170935, I'm fixing some google3 failures for #170935

auto-submit · 2025-08-21T01:42:40Z

autosubmit label was removed for flutter/flutter/170696, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

lint lint 1 Update focus_scope_test.dart Update semantics.dart lint Update semantics.dart Update semantics.dart tristate flags Update semantics.dart fix test fix tests Update accessibility_bridge.cc Update accessibility_bridge.cc Update semantics_test.dart Update semantics.dart web 1 1 embedder-tristate 1 1 Update embedder.h

…amework, web) (flutter/flutter#170696)

flutter/flutter@26bb33b...edd434a 2025-08-23 [email protected] Roll Skia from 6f710e0b38f7 to 61169c1f6f7c (1 revision) (flutter/flutter#174325) 2025-08-23 [email protected] Roll Fuchsia Linux SDK from Z-ZaFQ7jAqJ1OrIBf... to XLSNQCsY1VkIthSjt... (flutter/flutter#174318) 2025-08-23 [email protected] Roll Skia from ebb6051e8bb1 to 6f710e0b38f7 (1 revision) (flutter/flutter#174317) 2025-08-22 [email protected] [web] Expose rasterizers in Renderer (flutter/flutter#174308) 2025-08-22 [email protected] Update some semantics flags updated to use enum (engine, framework, web) (flutter/flutter#170696) 2025-08-22 [email protected] [ Tool ] Don't emit artifact downloading messages when --machine is provided (flutter/flutter#174301) 2025-08-22 [email protected] Roll Skia from cb15e1452399 to ebb6051e8bb1 (5 revisions) (flutter/flutter#174296) 2025-08-22 [email protected] `_downloadArtifacts` (Web SDK) uses content-aware hashing in post-submit (flutter/flutter#174236) 2025-08-22 [email protected] Refactor text and runtime effect to separate skia and impeller implementations. (flutter/flutter#174219) 2025-08-22 [email protected] Roll Packages from 58c02e0 to 092d832 (4 revisions) (flutter/flutter#174295) 2025-08-22 [email protected] [ Widget Preview ] Add support for DevTools configuration (flutter/flutter#174272) 2025-08-22 [email protected] Migrate more files to `WidgetStateProperty` (flutter/flutter#174268) 2025-08-22 [email protected] [ Tool ] Ensure `--dds-port=<port>` is respected when targeting web devices (flutter/flutter#174278) 2025-08-22 [email protected] Marks Mac_ios ios_debug_workflow to be unflaky (flutter/flutter#174104) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…amework, web) (flutter/flutter#170696)

hannah-hyj requested a review from a team as a code owner June 16, 2025 20:03

This comment was marked as resolved.

Sign in to view

hannah-hyj requested review from chunhtai and removed request for a team June 16, 2025 20:03

chunhtai approved these changes Jun 17, 2025

View reviewed changes

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. f: focus Focus traversal, gaining or losing focus labels Jun 18, 2025

ash2moon self-assigned this Jun 24, 2025

jmagman unassigned ash2moon Jun 24, 2025

jmagman requested a review from ash2moon June 24, 2025 22:23

ash2moon reviewed Jun 25, 2025

View reviewed changes

hannah-hyj mentioned this pull request Jun 25, 2025

[a11y] : set isFocused will update isFocusable to true #170935

Merged

9 tasks

mdebbar self-requested a review August 6, 2025 18:11

mdebbar approved these changes Aug 8, 2025

View reviewed changes

hannah-hyj force-pushed the tristate-flags-2 branch from f1bb3e6 to 00d95bc Compare August 18, 2025 18:37

hannah-hyj requested a review from a team as a code owner August 18, 2025 18:37

github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Aug 18, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025

hannah-hyj force-pushed the tristate-flags-2 branch from 002e9e5 to b668759 Compare August 21, 2025 03:01

hannah-hyj force-pushed the tristate-flags-2 branch from b668759 to f438b92 Compare August 21, 2025 16:43

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025

auto-submit bot added this pull request to the merge queue Aug 21, 2025

matanlurey removed this pull request from the merge queue due to a manual request Aug 21, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025

auto-submit bot added this pull request to the merge queue Aug 22, 2025

Merged via the queue into flutter:master with commit 798ff59 Aug 22, 2025
187 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2025

798ff5908 Update some semantics flags updated to use enum (engine, fr…

4e15733

…amework, web) (flutter/flutter#170696)

engine-flutter-autoroll mentioned this pull request Aug 23, 2025

Roll Flutter from 26bb33b9572b to edd434af3e9d (14 revisions) flutter/packages#9873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2025

798ff5908 Update some semantics flags updated to use enum (engine, fr…

2272267

…amework, web) (flutter/flutter#170696)

engine-flutter-autoroll mentioned this pull request Aug 23, 2025

Roll Flutter from 26bb33b9572b to edd434af3e9d (14 revisions) flutter/packages#9874

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

798ff5908 Update some semantics flags updated to use enum (engine, fr…

b2ed46e

…amework, web) (flutter/flutter#170696)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update some semantics flags updated to use enum (engine, framework, web) #170696

Update some semantics flags updated to use enum (engine, framework, web) #170696

Uh oh!

hannah-hyj commented Jun 16, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

chunhtai left a comment

Uh oh!

ash2moon Jun 25, 2025

Uh oh!

flutter-dashboard bot commented Jul 15, 2025

Uh oh!

mdebbar left a comment

Uh oh!

jmagman commented Aug 14, 2025

Uh oh!

hannah-hyj commented Aug 14, 2025

Uh oh!

auto-submit bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Update some semantics flags updated to use enum (engine, framework, web) #170696

Update some semantics flags updated to use enum (engine, framework, web) #170696

Uh oh!

Conversation

hannah-hyj commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as resolved.

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

ash2moon Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jul 15, 2025

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Aug 14, 2025

Uh oh!

hannah-hyj commented Aug 14, 2025

Uh oh!

auto-submit bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hannah-hyj commented Jun 16, 2025 •

edited

Loading