Skip to content

Fix whitespace issue in .ci.yaml. #170615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eyebrowsoffire merged 1 commit into from
Jun 13, 2025
Merged

Fix whitespace issue in .ci.yaml. #170615

eyebrowsoffire merged 1 commit into from
Jun 13, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Jun 13, 2025

Getting failures in CI both presubmit and postsubmit that look like:

[2025-06-13 13:23:25.219514] ERROR: ERROR: Whitespace check failed. The following files have trailing spaces:

/b/s/w/ir/cache/builder/engine/src/flutter/.ci.yaml:62:    bringup: true # LUCI failing KVM access https://github.com/flutter/flutter/issues/170529
Checking C++/ObjC/Shader formatting...

This looks like it was introduced in #170607

@eyebrowsoffire
Fix whitespace issue in .ci.yaml.
91e7345 
Getting failures in CI both presubmit and postsubmit that look like:

```
[2025-06-13 13:23:25.219514] ERROR: ERROR: Whitespace check failed. The following files have trailing spaces:

/b/s/w/ir/cache/builder/engine/src/flutter/.ci.yaml:62:    bringup: true # LUCI failing KVM access flutter#170529
Checking C++/ObjC/Shader formatting...
```

This looks like it was introduced in flutter#170607
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 13, 2025
@reidbaker reidbaker self-requested a review June 13, 2025 21:06
@eyebrowsoffire eyebrowsoffire added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Jun 13, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 13, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@eyebrowsoffire eyebrowsoffire added this pull request to the merge queue Jun 13, 2025
Merged via the queue into flutter:master with commit c3c56d1 Jun 13, 2025
180 of 182 checks passed
@eyebrowsoffire eyebrowsoffire deleted the whitespace_issue branch June 13, 2025 22:26
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
274afd8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
6427a6e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
d264377
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
e2396df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
f32eb29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
4dfb0f6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
98e5b85
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
82631f2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
6790987
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
f318750
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
a755645
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
a7de414
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
7e772d8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
57da50a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
5339a53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
0e86ae5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
3c4da78
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@eyebrowsoffire @mboetger
Fix whitespace issue in .ci.yaml. (flutter#170615)
8f0b8ee 
Getting failures in CI both presubmit and postsubmit that look like:

```
[2025-06-13 13:23:25.219514] ERROR: ERROR: Whitespace check failed. The following files have trailing spaces:

/b/s/w/ir/cache/builder/engine/src/flutter/.ci.yaml:62:    bringup: true # LUCI failing KVM access flutter#170529
Checking C++/ObjC/Shader formatting...
```

This looks like it was introduced in
flutter#170607
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
d804e34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
4249dc3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
ee4767c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
ad8249e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c3c56d116 Fix whitespace issue in .ci.yaml. (flutter/flutter#170615)
280e70d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire @reidbaker