Skip to content

remove --start-paused flag by default and set useDwdsWebSocketConnect… #170612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 16 commits into from
Jun 19, 2025
Merged

remove --start-paused flag by default and set useDwdsWebSocketConnect… #170612

auto-submit merged 16 commits into from
Jun 19, 2025

Conversation

@jyameo
Copy link
Contributor

@jyameo jyameo commented Jun 13, 2025 •
edited
Loading

Related to dart-lang/webdev#2605.
Fixes dart-lang/sdk#60289.

Sibling PR in DWDS: dart-lang/webdev#2629
This PR will need to be submitted before this one. The pubspec must be updated with a new release of DWDS after the changes are submitted

@jyameo
remove --start-paused flag by default and set useDwdsWebSocketConnect…
c951b5a 
…ion in DWDS; also updated logic for adding middleware and generating loadindicator
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 13, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 13, 2025
@jyameo jyameo mentioned this pull request Jun 13, 2025
Merged
srujzs
srujzs reviewed Jun 13, 2025
View reviewed changes
packages/flutter_tools/lib/src/isolated/resident_web_runner.dart Outdated
// we fall back to the default Chrome connection.
final bool useDwdsWebSocketConnection =
supportedWebDeviceIds.isEmpty ||
!supportedWebDeviceIds.contains(globals.deviceManager?.specifiedDeviceId ?? 'chrome');
Copy link
Contributor

@srujzs srujzs Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: GoogleChromeDevice.kChromeDeviceId instead of chrome

Copy link
Contributor

@nshahan nshahan Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic falling back on chrome here is still slightly confusing to me. Is this effectively the same as:

final bool useDwdsWebSocketConnection =
     supportedWebDeviceIds.isEmpty ||
     (globals.deviceManager?.specifiedDeviceId != null &&
     !supportedWebDeviceIds.contains(globals.deviceManager!.specifiedDeviceId!));

Copy link
Contributor Author

@jyameo jyameo Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's quite similar. The main difference is that I'm also handling the case where no device is specified at all. That probably won’t happen in practice since flutter run typically defaults to Chrome, but in the rare case where globals.deviceManager?.specifiedDeviceId is null, I fall back to Chrome as if the user ran flutter -d chrome.

That said, I see how this could be confusing. Your version is cleaner and makes more sense. If globals.deviceManager?.specifiedDeviceId == null, we can just set useDwdsWebSocketConnection to false and skip the fallback logic. I'll make the change now

@jyameo jyameo requested review from nshahan and srujzs June 16, 2025 18:30
srujzs
srujzs approved these changes Jun 16, 2025
View reviewed changes
nshahan
nshahan approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing this along with the changes in DWDS should fix dart-lang/sdk#60289? If so feel free to link with the description so it closes.

LGTM.

@jyameo
Copy link
Contributor Author

jyameo commented Jun 17, 2025 •
edited
Loading

Landing this along with the changes in DWDS should fix dart-lang/sdk#60289? If so feel free to link with the description so it closes.

LGTM.

Yes, that's right. I did a bunch of test locally and it should fix the issue above. However, it would be great if you can run some test as well to validate that all the various path (Amd vs DDLibraryBundle, Chome vs web-server) work as expected and make sure we didn't miss something. @nshahan @srujzs Thank you

@srujzs
Copy link
Contributor

srujzs commented Jun 17, 2025

Tried it out locally and it looks like AMD vs DDC library bundle/web-server (with Chrome/Safari/Firefox) vs Chrome all work correctly! LGTM!

@jyameo
Copy link
Contributor Author

jyameo commented Jun 17, 2025 •
edited
Loading

@bkonyi Hey Ben, I'm seeing some CI failures related to test/integration.shard/widget_preview_test.dart: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8711802314632568497/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_9_9/stdout

It seems the test flutter widget-preview start: can connect to an existing DTD instance is timing out. Have you seen this failure before and do you have more context on what could be causing this?

@jyameo
Copy link
Contributor Author

jyameo commented Jun 18, 2025

@nshahan @srujzs: I updated the logic for useDwdsWebSocketConnection and shouldEnableMiddleware to use local device information instead of globals.deviceManager?.specifiedDeviceId, which can be null when running in subprocess contexts (e.g., widget_preview_test). Now it uses chromiumLauncher != null and device!.device is ChromiumDevice for more reliable device detection. This should fix the test that was broken @nshahan @srujzs Does this make sense to you?

Also I am no longer able to test the DdcLibraryBundle + Webserver path for some reason.... Is there a flag I should be using? I tried with --web-experimental-hot-reload but doesn't look like it's using the DdcLibraryBundle anymore as the value of ddcmodulesystem is false with or without the flag.... can you please confirm if there is a way to test this configuration with my latest changes to make sure it's still working as expected?

srujzs
srujzs approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that sounds okay generally, but I'm not sure how device.device and globals.DeviceManager differ.

I believe you'll need to revert Nick's changes in https://github.com/flutter/flutter/pull/170610/commits (which always uses AMD when using web-server) in this PR.

packages/flutter_tools/lib/src/isolated/resident_web_runner.dart Outdated
nonWebServerConnectedDeviceIds.isEmpty ||
(globals.deviceManager?.specifiedDeviceId != null &&
!nonWebServerConnectedDeviceIds.contains(globals.deviceManager!.specifiedDeviceId));
!(device!.device is ChromiumDevice &&
Copy link
Contributor

@srujzs srujzs Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just check if _chromiumLauncher != null here as well as its assigned above?

Copy link
Contributor Author

@jyameo jyameo Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated code to use _chromiumLauncher! Thanks

Copy link
Contributor Author

@jyameo jyameo Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reverted Nick's changes and tested locally that all configs are working

Copy link
Contributor

@nshahan nshahan Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan-g This change fixes the issues and reverts the workaround I landed for the -d web-server issue you ran into.

@jyameo jyameo added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 18, 2025

autosubmit label was removed for flutter/flutter/170612, because - The status or check suite Linux gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jyameo jyameo added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 19, 2025
Merged via the queue into flutter:master with commit b757dab Jun 19, 2025
138 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
5bbdbed 
…ketConnect… (flutter/flutter#170612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
5cc4f2a 
…ketConnect… (flutter/flutter#170612)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
b72d5a2 
…ketConnect… (flutter/flutter#170612)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) (#9457)
0ec4053 
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
@nshahan nshahan mentioned this pull request Jun 24, 2025
Closed
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) (flutte…
6f669b7 
…r#9457)

Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
@jyameo jyameo mentioned this pull request Jun 25, 2025
Closed
@quyenlv-unicloud
Copy link

quyenlv-unicloud commented Jul 21, 2025 •
edited
Loading

Sorry I not understand, this MR lead to issue #171221, when run web-server it not wait click Dart Debug Extension so can not debug when run web-server.
Issue resolved by 3.34.0-0.1.pre but happen again at 3.35.0-0.0.pre.
My question is will #171648 resolve issue #171221 again and can debug when run web-server?

my mistake, It is behavior change/known issue, I will wait release and check later.
before: start web-server > blank page > click Extension > load > debug
now: start web-server > load > click Extension > debug

mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@jyameo @mboetger
remove --start-paused flag by default and set useDwdsWebSocketConnect… (
fa04787 
flutter#170612)

- Removed --start-paused flag by default and set
useDwdsWebSocketConnection in DWDS
- Updated logic for adding middleware and generating loadindicator
- Revert changes in flutter#170610

Related to dart-lang/webdev#2605.
Fixes dart-lang/sdk#60289. 

Sibling PR in DWDS: dart-lang/webdev#2629
This PR will need to be submitted before this one. The pubspec must be
updated with a new release of DWDS after the changes are submitted
@bkonyi
Copy link
Contributor

bkonyi commented Jul 25, 2025

@jyameo are you familiar with the issue @quyenlv-unicloud is referring to?

@jyameo
Copy link
Contributor Author

jyameo commented Jul 25, 2025

Sorry I not understand, this MR lead to issue #171221, when run web-server it not wait click Dart Debug Extension so can not debug when run web-server. Issue resolved by 3.34.0-0.1.pre but happen again at 3.35.0-0.0.pre. My question is will #171648 resolve issue #171221 again and can debug when run web-server?

@quyenlv-unicloud It sounds like what you're experiencing might be a separate issue from the one originally tracked here. Could you please create a new issue and include the specific steps to reproduce the problem you're seeing when running the web server? This will help us investigate it properly and track it independently.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 28, 2025
Closed
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions) (flutte…
96611fa 
…r#9457)

Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
nshahan added a commit to nshahan/packages that referenced this pull request Jul 30, 2025
@nshahan
flutter drive for web should no longer need this workaround.
f96ce17 
See dart-lang/sdk#60289
See flutter/flutter#170612

Add charset to some index.html files which is needed in the new DDC
module system.
@nshahan nshahan mentioned this pull request Jul 30, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 31, 2025
@nshahan
[tool] Remove web drive hot reload workaround (#9704)
db6988d 
flutter drive for web should no longer need this workaround.

See dart-lang/sdk#60289
See flutter/flutter#170612

Add charset to some index.html files which is needed in the new DDC module system.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
e24826b 
…ketConnect… (flutter/flutter#170612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
1f712b4 
…ketConnect… (flutter/flutter#170612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
9ff407d 
…ketConnect… (flutter/flutter#170612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
d14e9bf 
…ketConnect… (flutter/flutter#170612)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
b757dab0e remove --start-paused flag by default and set useDwdsWebSoc…
1b7a2d6 
…ketConnect… (flutter/flutter#170612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshahan nshahan nshahan approved these changes

@srujzs srujzs srujzs approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web hot reload breaks app when running as Web Server (-d web-server)

5 participants

@jyameo @srujzs @quyenlv-unicloud @bkonyi @nshahan