Run pub get post-processing for each package in workspace #170517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
bkonyi
reviewed
Jun 12, 2025
| if (list == null) { | ||
| return <String>[]; | ||
| } | ||
| if (list is! List<Object?>) { |
Contributor
There was a problem hiding this comment.
I think this function can just be if section not being present is an error:
if (map case {section: final List<String>? list when map.containsKey(section)) {
return list ?? <String>[];
}
throw FormatException('Expected `$section` to be `List<String>?`, got `${map[section]}');
Contributor
Author
There was a problem hiding this comment.
When trying that i get: Key expressions in map patterns must be constants.
Contributor
There was a problem hiding this comment.
Oh that's annoying... Honestly, I'd remove this helper and just use the pattern above in its place with the constant keys. This helper function is doing a lot of unnecessary checks.
Contributor
Author
There was a problem hiding this comment.
One more thing. When you read json the List doesn't become a List<String> it is a List<Object?>, and you need to validate each item separately and cast the list. I don't think that can be done with pattern matching...
Contributor
There was a problem hiding this comment.
This definitely works with pattern matching:
final json = <String, Object?>{
'foo': <String>['bar', 'baz'],
};
final jsonWithNull = <String, Object?>{
'foo': <String?>['bar', 'baz', null],
};
void main() {
if (json case {'foo': final List<String> list}) {
print('Destructured JSON list: $list Runtime type: ${list.runtimeType}');
} else {
print('Failed to destructure $json');
}
if (jsonWithNull case {'foo': final List<String> list}) {
print('Destructured JSON list: $list Runtime type: ${list.runtimeType}');
} else {
print('Failed to destructure $jsonWithNull');
}
if (jsonWithNull case {'foo': final List<String?> list}) {
print('Destructured JSON list: $list Runtime type: ${list.runtimeType}');
} else {
print('Failed to destructure $jsonWithNull');
}
}Outputs:
Destructured JSON list: [bar, baz] Runtime type: List<String>
Failed to destructure {foo: [bar, baz, null]}
Destructured JSON list: [bar, baz, null] Runtime type: List<String?>
Contributor
Author
There was a problem hiding this comment.
Yes, but when you read json, it doesn't type the lists as <String>[]. but List<dynamic> (which matches List<Object?>).
import 'dart:convert';
main() {
switch (jsonDecode('["A", "B", "C"]')) {
case final List<String> a:
print('List of String');
case final List<Object?> a:
print('List of Object');
case final a:
print('Something else ${a.runtimeType}');
}
}
Contributor
There was a problem hiding this comment.
Ah, good point... that's really annoying behavior since map patterns are supposed to be most useful for JSON destructuring...
Anyway, this approach would be less verbose than the current one:
List<String> _parseList(Map<String, Object?> map, String section) {
final Object? result = map[section];
try {
return (result as List<Object?>?)?.cast<String>() ?? <String>[];
} on TypeError {
throw FormatException(
'Expected `$section` to be `List<String>`, got ${result.runtimeType}',
);
}
}
matanlurey
reviewed
Jun 16, 2025
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
LGTM, but defer final approval to Ben.
Contributor
|
Once we remove |
bkonyi
approved these changes
Jun 20, 2025
Contributor
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
Thanks for humoring me 😅 LGTM!
sigurdm
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Contributor
Author
|
@bkonyi thanks! Yeah - async code review is tough sometimes. But thanks for being insistent on code quality! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 23, 2025
flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 [email protected] Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 [email protected] [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 [email protected] Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 [email protected] License cpp jun20 (flutter/flutter#170948) 2025-06-23 [email protected] Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 [email protected] Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 [email protected] Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 [email protected] Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 [email protected] Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 [email protected] Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 [email protected] Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 [email protected] Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 [email protected] Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 [email protected] Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 [email protected] Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
1 task
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161927