Skip to content

Conversation

@chinmaygarde
Copy link
Member

Also cleans up out-of-date iOS/Android guidance.

Fixes #170074

@chinmaygarde chinmaygarde requested a review from loic-sharma June 5, 2025 18:21
To **disable** Impeller on iOS, update your `Info.plist` file to add the following
under the top-level `<dict>` tag:
Impeller is the **default** on Android. Impeller will attempt to use Vulkan first and then
fall back to OpenGL rendering depending on device capabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to call out that Impeller requires API level 29? I don't feel strongly about this, up to you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #170080 to followup.

Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 5, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 5, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 5, 2025

autosubmit label was removed for flutter/flutter/170077, because - The status or check suite Linux_tool-tests-general has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde chinmaygarde force-pushed the custom_embedders_readme branch from d238bca to 3565196 Compare June 5, 2025 19:47
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jun 5, 2025
@chinmaygarde chinmaygarde force-pushed the custom_embedders_readme branch from 3565196 to 16c09fd Compare June 13, 2025 22:02
@jason-simmons
Copy link
Member

This is failing CI due to a formatting issue that was fixed by c3c56d1

The PR needs to be rebased.

@jason-simmons jason-simmons force-pushed the custom_embedders_readme branch from 16c09fd to fb25bfa Compare June 16, 2025 18:04
@chinmaygarde
Copy link
Member Author

CI is running into #166845 repeatedly. Going to try again later.

Also cleans up out-of-date iOS/Android guidance.

Fixes flutter#170074
@chinmaygarde chinmaygarde force-pushed the custom_embedders_readme branch from fb25bfa to cbd4679 Compare June 18, 2025 17:16
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 18, 2025
Merged via the queue into flutter:master with commit edc792e Jun 18, 2025
174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 19, 2025
Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9457)

Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9457)

Roll Flutter from 8303a96a0a99 to 85a9b4f38906 (93 revisions)

flutter/flutter@8303a96...85a9b4f

2025-06-19 [email protected] Roll Skia from af242598f14d to 794936b23812 (2 revisions) (flutter/flutter#170875)
2025-06-19 [email protected] Drop support for 21/22 Lollipop (flutter/flutter#170748)
2025-06-19 [email protected] Roll Dart SDK from 6020126c10e8 to bce9abe03175 (1 revision) (flutter/flutter#170872)
2025-06-19 [email protected] Roll Skia from df97f7f407db to af242598f14d (4 revisions) (flutter/flutter#170867)
2025-06-19 [email protected] Roll Skia from 1d8f7ebd23cc to df97f7f407db (5 revisions) (flutter/flutter#170864)
2025-06-19 [email protected] Roll Dart SDK from 4ab716b09e9d to 6020126c10e8 (1 revision) (flutter/flutter#170862)
2025-06-19 [email protected] Roll Skia from 291d41414fa7 to 1d8f7ebd23cc (2 revisions) (flutter/flutter#170857)
2025-06-19 [email protected] Roll Dart SDK from b32559bca3cc to 4ab716b09e9d (9 revisions) (flutter/flutter#170855)
2025-06-19 [email protected] remove --start-paused flag by default and set useDwdsWebSocketConnect… (flutter/flutter#170612)
2025-06-18 [email protected] Engine builders no longer require `is_fusion` (flutter/flutter#170849)
2025-06-18 [email protected] Roll Skia from 5f110d5f48a3 to 291d41414fa7 (2 revisions) (flutter/flutter#170836)
2025-06-18 [email protected] Use a shared vertex buffer for rendering layers. (flutter/flutter#170717)
2025-06-18 [email protected] fixes deeplinking in uiscenedelegate migrated projects (flutter/flutter#170452)
2025-06-18 [email protected] [Impeller] fix array uniforms on GLES backend. (flutter/flutter#170710)
2025-06-18 [email protected] [Impeller] Update README to add section about custom embedders. (flutter/flutter#170077)
2025-06-18 [email protected] Escape the forbidden strings in the regex used to check test command output (flutter/flutter#170702)
2025-06-18 [email protected] License cpp jun16 (flutter/flutter#170716)
2025-06-18 [email protected] Work around newer compilers requiring the satisfaction of three-way comparison of EncodableValue. (flutter/flutter#170822)
2025-06-18 [email protected] Update didUnmountRenderObject text description (flutter/flutter#169628)
2025-06-18 [email protected] Roll Skia from 297dbc32a6c7 to 5f110d5f48a3 (2 revisions) (flutter/flutter#170821)
2025-06-18 [email protected] Add an initial "Using feature flags" doc for the team. (flutter/flutter#170767)
2025-06-18 [email protected] Feat: Add mouse cursor for CupertinoDialogAction (flutter/flutter#169051)
2025-06-18 [email protected] Update `Engine-artifacts.md` to reflect flutter/cocoon/4785 (flutter/flutter#170751)
2025-06-18 [email protected] `CupertinoPicker` new onChanged behaviour (flutter/flutter#170202)
2025-06-18 [email protected] Rename `entryPointBaseUrl` to `entrypointBaseUrl` (flutter/flutter#170166)
2025-06-18 [email protected] Roll Skia from 1cb13a21b547 to 297dbc32a6c7 (4 revisions) (flutter/flutter#170809)
2025-06-18 [email protected] Roll Packages from 25d4fa4 to 715a0a5 (2 revisions) (flutter/flutter#170808)
2025-06-18 [email protected] Roll Skia from 0a106c038cd0 to 1cb13a21b547 (1 revision) (flutter/flutter#170801)
2025-06-18 [email protected] Add `--profile-microtasks` switch (flutter/flutter#170690)
2025-06-18 [email protected] Roll Skia from ff7fffa5dac5 to 0a106c038cd0 (3 revisions) (flutter/flutter#170795)
2025-06-18 [email protected] Add example for CupertinoExpansionTile transition modes (flutter/flutter#170335)
2025-06-18 [email protected] feat: Add radius to DividerThemeData. (flutter/flutter#169739)
2025-06-18 [email protected] Roll Skia from 75af9450b121 to ff7fffa5dac5 (3 revisions) (flutter/flutter#170772)
2025-06-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "add run_gradle_lock_files_check.dart for new PR's that modify gradle files (#169245)" (flutter/flutter#170770)
2025-06-17 [email protected] Started bridging the scene delegate to the lifecycle delegate for shortcuts (flutter/flutter#170180)
2025-06-17 [email protected] [ui] npot display_list allocation. (flutter/flutter#170447)
2025-06-17 [email protected] Prefer .of over .from (flutter/flutter#170750)
2025-06-17 [email protected] Fix RawGestureDetector semantics (flutter/flutter#170549)
2025-06-17 [email protected] Use correct type for filterIdentifier (flutter/flutter#170343)
2025-06-17 [email protected] Remove and inline `license_header.txt` (flutter/flutter#170475)
2025-06-17 [email protected] add run_gradle_lock_files_check.dart for new PR's that modify gradle files (flutter/flutter#169245)
2025-06-17 [email protected] Roll Dart SDK from 4fad61257b29 to b32559bca3cc (3 revisions) (flutter/flutter#170746)
2025-06-17 [email protected] [release] Sync stable changelog to master (flutter/flutter#170691)
2025-06-17 [email protected] Roll Packages from 03a6abb to 25d4fa4 (5 revisions) (flutter/flutter#170743)
2025-06-17 [email protected] [ Widget Preview ] Remove support for synthetic package:flutter_gen (flutter/flutter#170602)
2025-06-17 [email protected] Roll Skia from 8879db3b3319 to 75af9450b121 (4 revisions) (flutter/flutter#170739)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Impeller] Add section to the readme on how custom embedders can try Impeller.

3 participants