Use own EGL context for Flutter #170045
Closed
Use own EGL context for Flutter #170045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
Previously we were using GdkGLContext from GtkGLArea. This would not work if we wanted to start a Flutter engine without a view, as we can't created a GdkGLContext without a GdkWindow. Flutter now renders into its own context(s), and then we access these in the GtkGLArea using EGLImage. It is expected that EGLImage is widely available in all drivers. We also now composite and copy the framebuffer received from Flutter, as GTK will not present it until it is ready. This adds an additional copy, but should have probably always been done in case Flutter wrote to this framebuffer before GTK had used it.
robert-ancell
force-pushed
the
linux-egl-no-window
branch
from
d9585d2 to
656eb56
Compare
Contributor
Author
|
This is crashing in the driver when running under X11 currently... It otherwise is working on Wayland. |
Contributor
Author
|
The crash on X11 is due to it using GLX instead of EGL, so EGLImage is not available. Trying to work out alternative ways to get this to work on X11 or if we limit X11 to single window. |
Contributor
Would |
Contributor
Author
I don't think so, as the pixmap would be in the GLX context and not accessible from the EGL context. |
Contributor
|
Ok then you'll want to create a new context and look at |
This was referenced Jul 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…added (#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by #170045
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 9, 2025
…added (flutter#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by flutter#170045
Contributor
Author
|
#172090 contains the use of EGLImage, which is part of what this PR was doing. I'll refactor this PR to build on that when it lands. |
Contributor
Author
|
Replaced by #172330 |
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…added (flutter#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by flutter#170045
azatech
pushed a commit
to azatech/flutter
that referenced
this pull request
Jul 28, 2025
…added (flutter#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by flutter#170045
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…added (flutter#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by flutter#170045
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…added (flutter#171409) Software rendering was added in a79827a. It accidentally removed the different GL initialization for secondary views (which need to copy the contents from the primary view). This is not a heavily used feature yet, as multi-window support is still in progress. This secondary codepath is in the process of being removed by flutter#170045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using GdkGLContext from GtkGLArea. This would not work if we wanted to start a Flutter engine without a view, as we can't created a GdkGLContext without a GdkWindow.
Flutter now renders into its own context(s), and then we access these in the GtkGLArea using EGLImage. It is expected that EGLImage is widely available in all drivers.
We also now composite and copy the framebuffer received from Flutter, as GTK will not present it until it is ready. This adds an additional copy, but should have probably always been done in case Flutter wrote to this framebuffer before GTK had used it.