Manually roll material_color_utilities #170000
Conversation
github-actions
bot
added
tool
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/170000, because - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label. |
github-actions
bot
added
the
f: material design
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
This will need to be rolled up in a guide on the website for users that won't want these colors to change out from under them. See similar doc on the website linked below.
Also cc @QuncCccccc
|
I almost want to make a branch on material at the last merge and apply the fixes so we don't have to throw the baby out with the bath water. Will ponder... |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Piinks – so, this is interesting. I've updated the description of this PR. The changes made in August seem to have been only half of the changes to make things consistent. This is the other half of the changes that align with the Aug 2024 update. Specifically these changes: material-foundation/material-color-utilities@03336bf#diff-f0d491177f9e42cf45baea3a37a1694c493d60d17855101af426848634d410eb |
|
FYI: this change does drop the code size of the material sample (minified, uncompressed JS) around ~2k. The changes eliminated several dynamic calls and make things final which allows more more optimization in the compiler |
|
Ok! All that needs doing IMO is creating a one pager on the website to help folks maintain the colors they have when this reaches stable and breaks them. I shared an example above. |
|
@Piinks happy to help, BUT I'm a bit confused how to do it. See the linked diff from the repo. It's not a matter of switching color A for color B. The algorithm used to calculate colors changed. If I understand correctly, the color roll we did in the fall left us out of sync w/ the algorithm change being brought in here. |
This aligns the docs with the changes in flutter/flutter#170000
|
@Piinks – FYI/interesting - no goldens are affected here? Hrm... |
|
Catching up after uber OOO time. Left feedback on website PR: https://github.com/flutter/website/pull/12125/files#r2196250198 |
|
Also, heads up on merge conflicts here. |
|
Is this still something we'd like to move forward with? |
|
@bkonyi I think so, yes. Just need to get back to it. |
bkonyi
removed
the
tool
github-actions
bot
added
the
tool
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Pub roller has been fixed now. This will need a rebase, but LGTM!
flutter-dashboard
bot
removed
the
autosubmit
flutter/flutter@d438df3...c8cfb2b 2025-11-22 [email protected] Revert "[ios] Dynamic Content Resizing" (flutter/flutter#178958) 2025-11-22 [email protected] Make sure that a SearchAnchor doesn't crash in 0x0 environment (flutter/flutter#177749) 2025-11-22 [email protected] Make sure that a Stepper doesn't crash in 0x0 environment (flutter/flutter#178068) 2025-11-22 [email protected] Remove deprecated `activeColor` in `switch.0.dart` example (flutter/flutter#178293) 2025-11-22 [email protected] Make sure that a UserAccountsDrawerHeader doesn't crash in 0x0 enviro… (flutter/flutter#178516) 2025-11-22 [email protected] Make sure that a TimePickerDialog doesn't crash in 0x0 environment (flutter/flutter#178451) 2025-11-22 [email protected] Make sure that a CupertinoLinearActivityIndicator doesn't crash in 0x… (flutter/flutter#178566) 2025-11-22 [email protected] Make sure that a CupertinoTabBar doesn't crash in 0x0 environment (flutter/flutter#178613) 2025-11-22 [email protected] Make sure that a CupertinoContextMenu doesn't crash in 0x0 environment (flutter/flutter#178722) 2025-11-22 [email protected] Sort entries in TESTOWNERS (flutter/flutter#178939) 2025-11-22 [email protected] [ios] Dynamic Content Resizing (flutter/flutter#177410) 2025-11-21 [email protected] Roll Skia from dc88b21ce7d2 to 3018c3053490 (2 revisions) (flutter/flutter#178947) 2025-11-21 [email protected] Manually roll material_color_utilities (flutter/flutter#170000) 2025-11-21 [email protected] Roll Fuchsia Linux SDK from Y-cMdgKy3d6EnibWR... to 4ul9jvZ7jnDGIjtCD... (flutter/flutter#178934) 2025-11-21 [email protected] Roll Dart SDK from c788b6a7aefd to 5af71c736b0a (1 revision) (flutter/flutter#178932) 2025-11-21 [email protected] Roll Skia from c588bb60d5da to dc88b21ce7d2 (2 revisions) (flutter/flutter#178933) 2025-11-21 [email protected] Update .ci.yaml and TESTOWNERS for arc macrobenchmark tests (flutter/flutter#178891) 2025-11-21 [email protected] Use interactive mode with `devicectl` to redirect stdout (flutter/flutter#178405) 2025-11-21 [email protected] Update .ci.yaml in flutter/flutter to use either macOS 15.5 or macOS … (flutter/flutter#178666) 2025-11-21 [email protected] Roll Skia from d4e9d2873bfd to c588bb60d5da (1 revision) (flutter/flutter#178928) 2025-11-21 [email protected] Roll Packages from b1e2fb0 to e67b6be (7 revisions) (flutter/flutter#178927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This aligns the docs with the changes in flutter/flutter#170000 --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: Brett Morgan <[email protected]>
This updates Flutter to the latest release, which includes a bunch of code cleanup that should improve compiled code size and (hopefully) runtime performance. The changes in flutter#153385 (discussed in https://docs.flutter.dev/release/breaking-changes/material-design-3-token-update) seem to have been incomplete. This PR effectively catches up with these changes by updating the "math" behind primary, secondary, tertiary, error colors. There is a pending PR on the site to update the corresponding docs: flutter/website#12125 Fixes flutter#177285
This updates Flutter to the latest release, which includes a bunch of code cleanup that should improve compiled code size and (hopefully) runtime performance. The changes in flutter#153385 (discussed in https://docs.flutter.dev/release/breaking-changes/material-design-3-token-update) seem to have been incomplete. This PR effectively catches up with these changes by updating the "math" behind primary, secondary, tertiary, error colors. There is a pending PR on the site to update the corresponding docs: flutter/website#12125 Fixes flutter#177285
4 participants
This updates Flutter to the latest release, which includes a bunch of code cleanup that should improve compiled code size and (hopefully) runtime performance.
The changes in #153385 (discussed in https://docs.flutter.dev/release/breaking-changes/material-design-3-token-update) seem to have been incomplete.
This PR effectively catches up with these changes by updating the "math" behind primary, secondary, tertiary, error colors.
There is a pending PR on the site to update the corresponding docs: flutter/website#12125
Fixes #177285