Skip to content

Conversation

@mravn-google
Copy link
Contributor

Cocoapods changes:

  • flutter doctor now warns, if Cocoapods 1.5.0 or later is not installed
  • iOS build and run workflows
    • still accept earlier Cocoapods versions, but warn that it may not work with some types of plugin
    • execute pod install, if Podfile.lock is older than Podfile.

Tests added, test code simplified.

Fixes #16930
Fixes #16734

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Apr 28, 2018

fyi @tvolkert

@mravn-google mravn-google merged commit 6e26cc2 into flutter:master Apr 30, 2018
@mravn-google mravn-google deleted the cocoapods branch April 30, 2018 09:24
@mravn-google
Copy link
Contributor Author

Reverting. Seems this cannot land until we have Cocoapods 1.5.0 on the device lab, because we'd now report an error exit code from flutter doctor.

mravn-google added a commit that referenced this pull request Apr 30, 2018
mravn-google added a commit that referenced this pull request Apr 30, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter doctor should require cocoapods 1.5.0 Changing ios/Podfile ignored on re-run, pod install not invoked

4 participants