Skip to content

Engine tests kvm=1 is required for some fuchsia #169614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 28, 2025
Merged

Engine tests kvm=1 is required for some fuchsia #169614

auto-submit merged 1 commit into from
May 28, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented May 28, 2025

Undoes some changes from #168106 as these tests are looking for a KVM specifically for hardware accelerating the emulators. Tests are timing out as "infra failures" and making the tree go red.

KVM path /dev/kvm does not exist. Running without acceleration; emulator will be extremely slow and may not establish a connection with ffx in the allotted time.

@jtmcdole
Engine tests kvm=1 is required for some fuchsia
67d7e80 
Undoes some changes from flutter#168106 as these tests are looking for a KVM
specifically for hardware accelerating the emulators.
@jtmcdole jtmcdole requested review from matanlurey and zanderso May 28, 2025 19:53
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label May 28, 2025
@matanlurey
Copy link
Contributor

matanlurey commented May 28, 2025

Might want to emergency slam it since the tree is red.

@jtmcdole
Copy link
Member Author

jtmcdole commented May 28, 2025

Might want to emergency slam it since the tree is red.

Makes sense. There is no code change, just infra.

@jtmcdole jtmcdole added the emergency Jump the queue; land PR in front of all others; only use for emergencies label May 28, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 28, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit bot added this pull request to the merge queue May 28, 2025
Merged via the queue into flutter:master with commit a5b51db May 28, 2025
181 of 182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
b391d0b 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
0268ca9 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
c4194f4 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
c97dd4b 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
91c172a 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
a036033 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
101becc 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
930b442 
…utter#169614)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
af95047 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
8383f43 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
145164f 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
4e774dc 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
43ddce6 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
03875c6 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
0f6fed8 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
bc8846b 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
7e0d92a 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
6d04b4e 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
ea81f4b 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
7158789 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
def01d5 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
2286cae 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
e14eddb 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
c01b8b7 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
5013f50 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
cd06787 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
74ac2ad 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
5d17fbc 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
78437a4 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
f687f1f 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
760c8ba 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
19df353 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
c9756a4 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
537fd9e 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
aa3fe58 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
804884f 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
b4906a9 
…utter#169614)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
a5b51dbf2 Engine tests kvm=1 is required for some fuchsia (flutter/fl…
2ea4671 
…utter#169614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@zanderso zanderso Awaiting requested review from zanderso

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtmcdole @matanlurey