Skip to content

Fix minify logic #169607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 29, 2025
Merged

Fix minify logic #169607

auto-submit merged 2 commits into from
May 29, 2025

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 28, 2025

It's meant to be ignored unless explicitly set.

Introduced in cb3150f

@flutter-dashboard

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 28, 2025
@kevmoo kevmoo added platform-web Web applications specifically team-web Owned by Web platform team labels May 28, 2025
@kevmoo kevmoo marked this pull request as draft May 28, 2025 19:03
@kevmoo
Fix minify logic
159e576 
It's meant to be ignored unless explicitly set.

Introduced in cb3150f
@github-actions github-actions bot removed platform-web Web applications specifically team-web Owned by Web platform team labels May 28, 2025
@kevmoo kevmoo marked this pull request as ready for review May 28, 2025 19:38
kevmoo
kevmoo commented May 28, 2025
View reviewed changes
packages/flutter_tools/lib/src/web/compiler_config.dart
/// Returns which target this compiler outputs (js or wasm)
CompileTarget get compileTarget;
final WebRendererMode renderer;
List<String> toCommandOptions(BuildMode buildMode);
Copy link
Contributor Author

@kevmoo kevmoo May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this abstract. It's in both implementations

kevmoo
kevmoo commented May 28, 2025
View reviewed changes
packages/flutter_tools/lib/src/web/compiler_config.dart
'noFrequencyBasedMinification': noFrequencyBasedMinification,
'minify': minify,
'sourceMaps': sourceMaps,
WebCompilerConfig.kSourceMapsEnabled: sourceMaps,
Copy link
Contributor Author

@kevmoo kevmoo May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well use the constants if we got 'em

kevmoo
kevmoo commented May 28, 2025
View reviewed changes
packages/flutter_tools/lib/src/web/compiler_config.dart
...super._buildKeyMap,
'stripWasm': stripWasm,
'sourceMaps': sourceMaps,
kStripWasm: stripWasm,
Copy link
Contributor Author

@kevmoo kevmoo May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well use the constants if we got 'em

kevmoo
kevmoo commented May 28, 2025
View reviewed changes
packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart
expect(target, isA<WebServiceWorker>());
final List<WebCompilerConfig> configs = (target as WebServiceWorker).compileConfigs;
expect(configs.length, 2);
expect(configs, hasLength(2));
Copy link
Contributor Author

@kevmoo kevmoo May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more conventional

mdebbar
mdebbar approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtmcdole
Copy link
Member

jtmcdole commented May 28, 2025

I suspect this increased the flakiness of the web_tools_test.

@jtmcdole jtmcdole mentioned this pull request May 28, 2025
Closed
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 28, 2025
Merged via the queue into master with commit f262575 May 29, 2025
148 checks passed
@auto-submit auto-submit bot deleted the fix_minify branch May 29, 2025 03:35
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
47f5e91
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
85768a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
d04e5e9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
1a123e8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
83f778e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
30d7018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
015ebef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
451b044
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
f2c0afb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
77f0e98
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
a6cb12d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
e65864c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
1232c14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
37afece
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
a6fa5ef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
13beaa4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
fc1adf8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
4689c60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
f941b69
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
91b27f2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
5788ea4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
2964c3d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
f162c34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
5059f31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
c38b1e7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
841d515
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
a0a8847
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
0d07ab2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
b4eeaaf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
cc1d1ac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
6b81724
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
4f5b224
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
f2625754b Fix minify logic (flutter/flutter#169607)
1662116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevmoo @jtmcdole @mdebbar