[macOS] Fix TextInputPlugin crash when no viewId is provided #169583

knopp · 2025-05-28T13:48:48Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma

Thanks for fixing this!

TimWhiting · 2025-06-02T13:58:00Z

I believe people have reported the issue on Windows as well (see issue this fixes), but this doesn't seem to touch windows?

chinmaygarde · 2025-06-02T18:00:36Z

This should be good to go. May I add the autosubmit label?

flutter/flutter#169583)

[macOS] Fix TextInputPlugin crash when no viewId is provided

eeef8a5

github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels May 28, 2025

knopp requested a review from cbracken May 29, 2025 21:17

loic-sharma approved these changes May 29, 2025

View reviewed changes

knopp added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025

auto-submit bot added this pull request to the merge queue Jun 3, 2025

Merged via the queue into flutter:master with commit b804448 Jun 3, 2025
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to cf007b91d360 (101 revisions) flutter/packages#9363

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

9fae64f

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to 03dbf1a99c0a (102 revisions) flutter/packages#9364

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

c6d5baf

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to ec17f9b29776 (103 revisions) flutter/packages#9365

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

12d6586

flutter/flutter#169583)

This was referenced Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to f61ef2d2a75d (104 revisions) flutter/packages#9366

Closed

Roll Flutter from 0e536eb9fe4b to d2e4017f8174 (105 revisions) flutter/packages#9367

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

a16f4aa

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to 5f7f3d021713 (106 revisions) flutter/packages#9369

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

843e166

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to 8ff75be5504c (107 revisions) flutter/packages#9370

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

6b03849

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 3, 2025

Roll Flutter from 0e536eb9fe4b to 2d9977c14ebe (108 revisions) flutter/packages#9371

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

a1bb1b3

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to d966d99b680a (127 revisions) flutter/packages#9374

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

11f49b5

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 0c0406a6158e (128 revisions) flutter/packages#9375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

56263cc

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 99a5b3fb4ec6 (129 revisions) flutter/packages#9376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

07d033d

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9377

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

86ab536

flutter/flutter#169583)

engine-flutter-autoroll mentioned this pull request Jun 4, 2025

Roll Flutter from 0e536eb9fe4b to 1fcd888704ea (130 revisions) flutter/packages#9378

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

1005146

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

926984a

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

e55323a

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

7afff5e

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

55db149

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

a0448ce

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

cf57fb9

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

1c3c92f

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

0166980

flutter/flutter#169583)

MatthiasLichter mentioned this pull request Jun 17, 2025

Compatibility with Flutter 3.32.2 [Windows] singerdmx/flutter-quill#2591

Open

1 task

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

c9b95b8

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

5f2b9ce

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

a3bd979

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

b2efa6d

flutter/flutter#169583)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

b804448bd [macOS] Fix TextInputPlugin crash when no viewId is provided (

c96032f

flutter/flutter#169583)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[macOS] Fix TextInputPlugin crash when no viewId is provided #169583

[macOS] Fix TextInputPlugin crash when no viewId is provided #169583

Uh oh!

knopp commented May 28, 2025

Uh oh!

loic-sharma left a comment

Uh oh!

TimWhiting commented Jun 2, 2025

Uh oh!

chinmaygarde commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[macOS] Fix TextInputPlugin crash when no viewId is provided #169583

[macOS] Fix TextInputPlugin crash when no viewId is provided #169583

Uh oh!

Conversation

knopp commented May 28, 2025

Pre-launch Checklist

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

TimWhiting commented Jun 2, 2025

Uh oh!

chinmaygarde commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants