Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" #169581

auto-submit · 2025-05-28T12:34:25Z

Reverts: #169298

Initiated by: matanlurey

Reason for reverting: Broke mac/iOS integration tests.

Original PR Author: matanlurey

Reviewed By: {vashworth, bkonyi}

This change reverts the following previous change:
Closes #169160.
Closes #165803.

…tion test. (#169298)" This reverts commit 5759401.

…dds integration test. (#169298)" (flutter/flutter#169581)

flutter/flutter@4372bfb...0e536eb 2025-05-28 [email protected] Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 [email protected] Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 [email protected] Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 [email protected] Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 [email protected] dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 [email protected] Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 [email protected] Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 [email protected] Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 [email protected] [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 [email protected] Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 [email protected] Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 [email protected] Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 [email protected] Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 [email protected] 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 [email protected] Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 [email protected] [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 [email protected] Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 [email protected] Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 [email protected] Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 [email protected] Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 [email protected] Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 [email protected] Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 [email protected] Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 [email protected] Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 [email protected] Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 [email protected] Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…s integration test. (flutter#169298)" (flutter#169581)" This reverts commit 5d013c7.

…r#9334) flutter/flutter@4372bfb...0e536eb 2025-05-28 [email protected] Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 [email protected] Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 [email protected] Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 [email protected] Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 [email protected] dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 [email protected] Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 [email protected] Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 [email protected] Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 [email protected] [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 [email protected] Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 [email protected] Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 [email protected] Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 [email protected] Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 [email protected] 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 [email protected] Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 [email protected] [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 [email protected] Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 [email protected] Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 [email protected] Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 [email protected] Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 [email protected] Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 [email protected] Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 [email protected] Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 [email protected] Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 [email protected] Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 [email protected] Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…dds integration test. (#169298)" (flutter/flutter#169581)

Revert "Initialize default-flavor in FlutterCommand, adds integra…

3a8232a

…tion test. (#169298)" This reverts commit 5759401.

auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 28, 2025

auto-submit bot assigned matanlurey May 28, 2025

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 28, 2025

fluttergithubbot approved these changes May 28, 2025

View reviewed changes

auto-submit bot added this pull request to the merge queue May 28, 2025

Merged via the queue into master with commit 5d013c7 May 28, 2025
9 of 12 checks passed

auto-submit bot deleted the revert_5759401447fb8e769f0fc58fb3d8ef45cb2e45ad branch May 28, 2025 13:07

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 5d013c73baa7 (26 revisions) flutter/packages#9333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

546b056

…dds integration test. (#169298)" (flutter/flutter#169581)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 0e536eb9fe4b (27 revisions) flutter/packages#9334

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

7347453

…dds integration test. (#169298)" (flutter/flutter#169581)

matanlurey mentioned this pull request May 28, 2025

"Initialize default-app-flavor (#169581)" fails flavors_test_macos #169598

Closed

matanlurey added a commit to matanlurey/flutter that referenced this pull request May 28, 2025

Revert "Reverts "Initialize default-flavor in FlutterCommand, add…

685cf79

…s integration test. (flutter#169298)" (flutter#169581)" This reverts commit 5d013c7.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

1b69316

…dds integration test. (#169298)" (flutter/flutter#169581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

2cd5cfb

…dds integration test. (#169298)" (flutter/flutter#169581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

3e2be75

…dds integration test. (#169298)" (flutter/flutter#169581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

acf7760

…dds integration test. (#169298)" (flutter/flutter#169581)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

5d013c73b Reverts "Initialize default-flavor in FlutterCommand, a…

c0cc04b

…dds integration test. (#169298)" (flutter/flutter#169581)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" #169581

Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" #169581

Uh oh!

auto-submit bot commented May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Initialize default-flavor in FlutterCommand, adds integration test. (#169298)" #169581

Reverts "Initialize default-flavor in FlutterCommand, adds integration test. (#169298)" #169581

Uh oh!

Conversation

auto-submit bot commented May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" #169581

Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" #169581