[stable] Roll package:dds to 5.0.2 (#169471)
#169515
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
github-actions
bot
added
a: text input
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
removed
a: text input
github-actions
bot
removed
d: api docs
eyebrowsoffire
added
the
autosubmit
2 participants
Fixes #156793
Issue Link:
#156793
Changelog Description:
Fix flaky crash when targeting web applications via IDEs using the DAP.
Impact Description:
The
flutter debug-adapterprocess started by IDEs can crash when requesting isolate information from a Flutter web application that has disposed its isolate (i.e., at shutdown or due to a hot restart).This is the top crasher for
flutter_tools, accounting for ~66% of all crashes for 3.32.0.Workaround:
Is there a workaround for this issue?
No.
Risk:
This CP is low risk as only additional exception handling was added to the DAP logic in
package:dds(see https://dart-review.googlesource.com/c/sdk/+/431060) to handle the specific case outlined in the issue.Test Coverage:
This issue is difficult to reproduce without injecting test-only code via custom VM service RPCs across multiple repositories. Testing was done manually with this approach, but the testing code is not committed.
Validation Steps:
IDE extensions don't crash when interacting with Flutter Web applications during hot restart / application shutdown.