-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix wrong path in 'archives' for release mode iOS DDM artifacts. #169448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahaog
approved these changes
May 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 26, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 26, 2025
flutter/flutter@60050a0...4372bfb 2025-05-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add workspace (#169451)" (flutter/flutter#169468) 2025-05-26 [email protected] Add workspace (flutter/flutter#169451) 2025-05-26 [email protected] Fix wrong path in 'archives' for release mode iOS DDM artifacts. (flutter/flutter#169448) 2025-05-26 [email protected] Roll Fuchsia Linux SDK from -eo2JqnJBauuGSzoW... to 5mpmPsuD8rpeiJizT... (flutter/flutter#169446) 2025-05-25 [email protected] Roll Fuchsia Linux SDK from XtPp9bBW49iDJ0wbA... to -eo2JqnJBauuGSzoW... (flutter/flutter#169424) 2025-05-24 [email protected] Roll Skia from 91dc88dc70e5 to 443f5257f382 (1 revision) (flutter/flutter#169422) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stan-at-work
pushed a commit
to stan-at-work/flutter
that referenced
this pull request
May 26, 2025
…tter#169448) This is intended to fix a bug where DDM iOS builds were not working in release mode and failing at runtime with an error like: ``` Failed to find snapshot at /private/var/containers/Bundle/Application/CA6AA16E-2C5E-4C1F-A650-E48AC9AC68BD/my_app.app/Frameworks/ios.framework/ios.assets/kernel_blob.bin: Error Domain=NSCocoaErrorDomain Code=260 "The file “kernel_blob.bin” couldn’t be opened because there is no such file." UserInfo={NSURL=kernel_blob.bin -- file:///private/var/containers/Bundle/Application/CA6AA16E-2C5E-4C1F-A650-E48AC9AC68BD/my_app.app/Frameworks/ios.framework/ios.assets/, NSFilePath=/private/var/containers/Bundle/Application/CA6AA16E-2C5E-4C1F-A650-E48AC9AC68BD/my_app.app/Frameworks/ios.framework/ios.assets/kernel_blob.bin, NSUnderlyingError=0x302f3b480 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}} ``` I think what was happening is the Google internal build infra was trying to create a release mode app with no kernel_blob.bin etc, but it actually contained a flutter.so built for debug mode which was expecting to find kernel_blob.bin. See internal bug b/419694561 for full context.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…#9322) flutter/flutter@60050a0...4372bfb 2025-05-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add workspace (#169451)" (flutter/flutter#169468) 2025-05-26 [email protected] Add workspace (flutter/flutter#169451) 2025-05-26 [email protected] Fix wrong path in 'archives' for release mode iOS DDM artifacts. (flutter/flutter#169448) 2025-05-26 [email protected] Roll Fuchsia Linux SDK from -eo2JqnJBauuGSzoW... to 5mpmPsuD8rpeiJizT... (flutter/flutter#169446) 2025-05-25 [email protected] Roll Fuchsia Linux SDK from XtPp9bBW49iDJ0wbA... to -eo2JqnJBauuGSzoW... (flutter/flutter#169424) 2025-05-24 [email protected] Roll Skia from 91dc88dc70e5 to 443f5257f382 (1 revision) (flutter/flutter#169422) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…#9322) flutter/flutter@60050a0...4372bfb 2025-05-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add workspace (#169451)" (flutter/flutter#169468) 2025-05-26 [email protected] Add workspace (flutter/flutter#169451) 2025-05-26 [email protected] Fix wrong path in 'archives' for release mode iOS DDM artifacts. (flutter/flutter#169448) 2025-05-26 [email protected] Roll Fuchsia Linux SDK from -eo2JqnJBauuGSzoW... to 5mpmPsuD8rpeiJizT... (flutter/flutter#169446) 2025-05-25 [email protected] Roll Fuchsia Linux SDK from XtPp9bBW49iDJ0wbA... to -eo2JqnJBauuGSzoW... (flutter/flutter#169424) 2025-05-24 [email protected] Roll Skia from 91dc88dc70e5 to 443f5257f382 (1 revision) (flutter/flutter#169422) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix a bug where DDM iOS builds were not working in release mode and failing at runtime with an error like:
I think what was happening is the Google internal build infra was trying to create a release mode app with no kernel_blob.bin etc, but it actually contained a flutter.so built for debug mode which was expecting to find kernel_blob.bin.
See internal bug b/419694561 for full context.