Skip to content

[CP-stable]Fixes tab semantics gets dropped if the child produce a semantics node #169362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 28, 2025
Merged

[CP-stable]Fixes tab semantics gets dropped if the child produce a semantics node #169362

auto-submit merged 1 commit into from
May 28, 2025

Conversation

@flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented May 23, 2025 •
edited by chunhtai
Loading

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#169175

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

Fixed unexpected crash when using Tab and TabBar widgets.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

app crash

Workaround:

Is there a workaround for this issue?

Wrap the Tab widget with a MergeSemantics widget will mitigate the issue.

Risk:

What is the risk level of this cherry-pick?

  • [O] Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • [O] Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

create a TabBar that has a Tab with image widget

TabBar(
  tabs: <Widget>[
      Tab(icon: Image.network('https://some-url')),
      Tab(icon: Icon(Icons.beach_access_sharp)),
      Tab(icon: Icon(Icons.brightness_5_sharp)),
  ],
),

@chunhtai
Fixes tab semantics gets dropped if the child produce a semantics node (
0242b7f 
flutter#169233)

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes flutter#169175

the bug is due to the image widget will create it own semanitc node and
force the semantics widget in the stack to form its own node instead of
merge up. Modify the code so that it works correctly.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label May 23, 2025
@flutteractionsbot
Copy link
Author

flutteractionsbot commented May 23, 2025

@chunhtai please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 23, 2025

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels May 23, 2025
@chunhtai chunhtai mentioned this pull request May 23, 2025
Closed
@matanlurey
Copy link
Contributor

matanlurey commented May 23, 2025

Assigning to @justinmc to review.

@matanlurey matanlurey requested a review from justinmc May 23, 2025 16:49
@chunhtai chunhtai requested review from Piinks and hannah-hyj and removed request for Piinks May 28, 2025 16:23
hannah-hyj
hannah-hyj approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025
@auto-submit auto-submit bot merged commit 7d3efe4 into flutter:flutter-3.32-candidate.0 May 28, 2025
143 checks passed
@matanlurey
Copy link
Contributor

matanlurey commented May 29, 2025 •
edited
Loading

LGTM

This was OK (it would have been approved), but in the future the release team is supposed to LGTM changes into the release branches, not the initiating team.

@chunhtai @hannah-hyj

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2025
@engine-flutter-autoroll
7d3efe4 [CP-stable]Fixes tab semantics gets dropped if the child prod…
d0205a1 
…uce a semantics node (flutter/flutter#169362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannah-hyj hannah-hyj hannah-hyj approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flutteractionsbot @matanlurey @hannah-hyj @chunhtai