Remove patching of `package_config.json` from Flutter Pub wrapper. #169306

matanlurey · 2025-05-22T20:34:30Z

This PR removes the mechanics around generateSyntheticPackage from Flutter's pub wrapper (DefaultPub).

The feature it supported (package:flutter_gen) was deprecated (opt-in 3.29, opt-out 3.32) and is now being removed:

https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source

One integration test (flutter_gen_test.dart) will fail at this PR until it is deleted in (pending) #169283.

/cc @sigurdm yay!

auto-submit · 2025-05-23T02:53:07Z

autosubmit label was removed for flutter/flutter/169306, because - The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-05-23T03:01:25Z

autosubmit label was removed for flutter/flutter/169306, because - The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-05-23T03:08:05Z

autosubmit label was removed for flutter/flutter/169306, because - The status or check suite Linux tool_integration_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

sigurdm · 2025-05-23T07:24:31Z

Yeah!!! I didn't know we were this far already!

…rapper. (flutter/flutter#169306)

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…r#9315) Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…rapper. (flutter/flutter#169306)

flutter/flutter#169306

Remove patching of package_config.json from Flutter Pub wrapper.

9e250ba

matanlurey requested a review from bkonyi May 22, 2025 20:34

matanlurey changed the title ~~Remove patching of package_config.json from Flutter Pub wrapper.~~ Remove patching of package_config.json from Flutter Pub wrapper. May 22, 2025

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 22, 2025

bkonyi approved these changes May 22, 2025

View reviewed changes

matanlurey and others added 2 commits May 22, 2025 17:01

Reduce what was removed, oops, thanks tests

2243be1

Merge branch 'master' into remove-package-config-patching-pub

946dd1e

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot added this pull request to the merge queue May 23, 2025

Merged via the queue into master with commit e529d32 May 23, 2025
150 checks passed

auto-submit bot deleted the remove-package-config-patching-pub branch May 23, 2025 04:43

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to d5ae7839620b (38 revisions) flutter/packages#9314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

337e3dc

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/packages#9315

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

579f204

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

8e2cad2

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

bfbdcf6

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

711c4a6

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

ef1edd9

…rapper. (flutter/flutter#169306)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

e529d32db Remove patching of package_config.json from Flutter Pub w…

ea63e73

…rapper. (flutter/flutter#169306)

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 9, 2025

Add missing argument to Pub

9cb77d0

flutter/flutter#169306

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 9, 2025

Remove generateSyntheticPackage argument in Pub

221ee6b

flutter/flutter#169306

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025

Add missing argument to Pub

feaabc0

flutter/flutter#169306

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Sep 19, 2025

Remove generateSyntheticPackage argument in Pub

3f0ce78

flutter/flutter#169306

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove patching of `package_config.json` from Flutter Pub wrapper. #169306

Remove patching of `package_config.json` from Flutter Pub wrapper. #169306

Uh oh!

matanlurey commented May 22, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Uh oh!

sigurdm commented May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove patching of package_config.json from Flutter Pub wrapper. #169306

Remove patching of package_config.json from Flutter Pub wrapper. #169306

Uh oh!

Conversation

matanlurey commented May 22, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Uh oh!

sigurdm commented May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove patching of `package_config.json` from Flutter Pub wrapper. #169306

Remove patching of `package_config.json` from Flutter Pub wrapper. #169306