Increase sub-task timeout for `web_tool_tests_1_2` #169277

mdebbar · 2025-05-22T15:52:33Z

For more details, @flar did a great job explaining it in #169168.

This PR is a one-off fix for the web_tool_tests_1_2 shard that has been timing out and bringing the tree down with it. The shard was marked bringup here. After increasing the sub-task timeout, let's watch it and if it becomes consistently green, we will remove the bringup status.

Partial fix for #168863
(partial because I still want to remove bringup before I consider the issue fixed)

@flar

For more details, @flar did a great job explaining it in #169168. This PR is a one-off fix for the `web_tool_tests_1_2` shard that has been timing out and bringing the tree down with it. The shard is marked `bringup` [here](#168871). After increasing the sub-task timeout, let's watch it and if it becomes consistently green, we will remove the `bringup` status. Partial fix for #168863 (partial because I still want to remove `bringup` before I consider the issue fixed)

flar

LGTM. It would (also) be nice to have the sub-timeout track the global timeout (or just not enforce itself in the presence of the global timeout).

mdebbar · 2025-05-22T16:34:31Z

It would (also) be nice to have the sub-timeout track the global timeout

Agreed, but I couldn't find where the default is being set or where test_timeout_secs is being consumed (I looked in cocoon and recipes).

DanTup · 2025-05-22T17:31:24Z

Could this affect other platforms too? My PR #169198 is having the Mac web tests bot time out. It's very possible it's my change (I need to get my Macbook set back up to test locally), but there are open issues about this also timing out on Linux (#162714, #86370).

…/flutter#169277)

flar · 2025-05-22T20:05:59Z

Could this affect other platforms too? My PR #169198 is having the Mac web tests bot time out. It's very possible it's my change (I need to get my Macbook set back up to test locally), but there are open issues about this also timing out on Linux (#162714, #86370).

As mentioned in #169168, any entry in .ci.yaml that has a timeout entry (in the case of Mac web_tool_tests it is set to 60 minutes) and is timing out in less than that time is likely timing out because of the sub-timeout, so it likely needs the same treatment as was applied in this PR.

In my PR flutter#169198 the Mac web_tool_tests are timing out after around 45 minutes. The global timeout has been set to 60 minutes but the sub-task timeout was lower. This increases the sub-task timeout to match the global timeout (as discussed in flutter#169277).

DanTup · 2025-05-22T20:38:22Z

@flar thanks for the explanation! There is indeed a mismatch between those values and the timeouts I'm seeing are after the lower sub-task period. I have opened #169307 to do the same for that one.

In my PR #169198 the Mac web_tool_tests are timing out after around 45 minutes. The global timeout has been set to 60 minutes but the sub-task timeout was lower. This increases the sub-task timeout to match the global timeout (see #169277 and #169168).

…/flutter#169277)

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

Reverts #168871 The timeout was [fixed](#169277) and some slow tests have been [disabled](#169305). The builder has been consistently green for the past 20+ runs: https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Windows%20web_tool_tests_1_2 Closes #168863

…r#9315) Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…/flutter#169277)

mdebbar requested a review from flar May 22, 2025 15:56

flar approved these changes May 22, 2025

View reviewed changes

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2025

auto-submit bot added this pull request to the merge queue May 22, 2025

matanlurey mentioned this pull request May 22, 2025

Unpin test/test_core/test_api packages #169198

Merged

Merged via the queue into master with commit 43b6bf6 May 22, 2025
158 checks passed

auto-submit bot deleted the mdebbar-patch-1 branch May 22, 2025 17:31

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2025

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to 5fd7aa2ed70d (16 revisions) flutter/packages#9309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

8f8dbb9

…/flutter#169277)

matanlurey mentioned this pull request May 22, 2025

Restore DDC Expression Evaluation tests (#168017): Causing suite timeouts #169304

Closed

DanTup mentioned this pull request May 22, 2025

Increase sub-task timeout for Mac web_tool_tests #169307

Merged

mdebbar mentioned this pull request May 22, 2025

Increase sub-task timeout for Mac web_tool_tests #169309

Closed

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to d5ae7839620b (38 revisions) flutter/packages#9314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

81005b8

…/flutter#169277)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/packages#9315

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

a072d8d

…/flutter#169277)

This was referenced May 23, 2025

Mark web_tool_tests_1_2 as bringup. #168871

Merged

Revert "Mark web_tool_tests_1_2 as bringup." #169361

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

bfe001e

…/flutter#169277)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

fef0fbf

…/flutter#169277)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

7dd5321

…/flutter#169277)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

3f960fa

…/flutter#169277)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

43b6bf67e Increase sub-task timeout for web_tool_tests_1_2 (flutter…

d792401

…/flutter#169277)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Increase sub-task timeout for `web_tool_tests_1_2` #169277

Increase sub-task timeout for `web_tool_tests_1_2` #169277

Uh oh!

mdebbar commented May 22, 2025

Uh oh!

flar left a comment

Uh oh!

mdebbar commented May 22, 2025

Uh oh!

DanTup commented May 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

flar commented May 22, 2025

Uh oh!

DanTup commented May 22, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Increase sub-task timeout for web_tool_tests_1_2 #169277

Increase sub-task timeout for web_tool_tests_1_2 #169277

Uh oh!

Conversation

mdebbar commented May 22, 2025

Uh oh!

flar left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar commented May 22, 2025

Uh oh!

DanTup commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

flar commented May 22, 2025

Uh oh!

DanTup commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Increase sub-task timeout for `web_tool_tests_1_2` #169277

Increase sub-task timeout for `web_tool_tests_1_2` #169277

DanTup commented May 22, 2025 •

edited

Loading

DanTup commented May 22, 2025 •

edited

Loading