dev/bots: improve service worker test code #169231

kevmoo · 2025-05-21T19:44:30Z

Use foundError instead of throwing - as is recommended
DRASTICALLY improve the error output by copying (more) from pkg:matcher

Use `foundError` instead of throwing - as is recommended DRASTICALLY improve the error output by copying (more) from pkg:matcher

kevmoo · 2025-05-21T22:35:58Z

before

╔═╡ERROR #2╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ 
║ #0      expect (file:///b/s/w/ir/x/w/flutter/dev/bots/service_worker_test.dart:225:3)
║ #1      WebTestsSuite._runWebTreeshakeTest (file:///b/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_web_tests.dart:429:5)
║ <asynchronous suspension>
║ #2      runShardRunnerIndexOfTotalSubshard (file:///b/s/w/ir/x/w/flutter/dev/bots/utils.dart:612:5)
║ <asynchronous suspension>
║ #3      WebTestsSuite.webLongRunningTestsRunner (file:///b/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_web_tests.dart:307:5)
║ <asynchronous suspension>
║ #4      _runFromList (file:///b/s/w/ir/x/w/flutter/dev/bots/utils.dart:718:7)
║ <asynchronous suspension>
║ #5      main (file:///b/s/w/ir/x/w/flutter/dev/bots/test.dart:123:5)
║ <asynchronous suspension>
║ 
║ The test.dart script should be corrected to catch this error and call foundError().
║ Some tests are likely to have been skipped.
╚═══════════════════════════════════════════════════════════════════════════════

after

╔═╡ERROR #4╞════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════
║ Expected: {
║             'index.html': 2,
║             'flutter.js': 1,
║             'main.dart.js': 1,
║             'flutter_service_worker.js': 1,
║             'flutter_bootstrap.js': 1,
║             'assets/FontManifest.json': 1,
║             'assets/AssetManifest.bin.json': 1,
║             'assets/fonts/MaterialIcons-Regular.otf': 1,
║             'CLOSE': 1
║           }
║   Actual: {
║             'index.html': 2,
║             'flutter.js': 1,
║             'manifest.json': 1,
║             'favicon.png': 1,
║             'flutter_service_worker.js': 1,
║             'main.dart.js': 1,
║             'flutter_bootstrap.js': 1,
║             'assets/AssetManifest.bin.json': 1,
║             'assets/FontManifest.json': 1,
║             'assets/fonts/MaterialIcons-Regular.otf': 1,
║             'CLOSE': 1
║           }
║    Which: has different length and has extra map key 'manifest.json'
║
║ #0      expect (file:///Users/kevmoo/github/flutter/dev/bots/service_worker_test.dart:234:53)
║ #1      _expectRequestCounts (file:///Users/kevmoo/github/flutter/dev/bots/service_worker_test.dart:186:3)
║ #2      runWebServiceWorkerTest.expectRequestCounts (file:///Users/kevmoo/github/flutter/dev/bots/service_worker_test.dart:269:7)
║ #3      runWebServiceWorkerTest (file:///Users/kevmoo/github/flutter/dev/bots/service_worker_test.dart:350:5)
║ <asynchronous suspension>
║ #4      runShardRunnerIndexOfTotalSubshard (file:///Users/kevmoo/github/flutter/dev/bots/utils.dart:612:5)
║ <asynchronous suspension>
║ #5      WebTestsSuite.webLongRunningTestsRunner (file:///Users/kevmoo/github/flutter/dev/bots/suite_runners/run_web_tests.dart:307:5)
║ <asynchronous suspension>
║ #6      _runFromList (file:///Users/kevmoo/github/flutter/dev/bots/utils.dart:718:7)
║ <asynchronous suspension>
║ #7      main (file:///Users/kevmoo/github/flutter/dev/bots/test.dart:123:5)
║ <asynchronous suspension>
║
╚═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════

auto-submit · 2025-05-27T23:52:53Z

autosubmit label was removed for flutter/flutter/169231, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…#169231)

flutter/flutter@4372bfb...0e536eb 2025-05-28 [email protected] Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 [email protected] Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 [email protected] Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 [email protected] Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 [email protected] dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 [email protected] Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 [email protected] Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 [email protected] Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 [email protected] [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 [email protected] Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 [email protected] Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 [email protected] Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 [email protected] Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 [email protected] 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 [email protected] Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 [email protected] [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 [email protected] Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 [email protected] Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 [email protected] Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 [email protected] Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 [email protected] Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 [email protected] Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 [email protected] Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 [email protected] Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 [email protected] Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 [email protected] Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9334) flutter/flutter@4372bfb...0e536eb 2025-05-28 [email protected] Introduces FlutterPluginRegistrant protocol. (flutter/flutter#169399) 2025-05-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Initialize `default-flavor` in `FlutterCommand`, adds integration test. (#169298)" (flutter/flutter#169581) 2025-05-28 [email protected] Initialize `default-flavor` in `FlutterCommand`, adds integration test. (flutter/flutter#169298) 2025-05-28 [email protected] Update DEPS to add dart-lang/ai repo (flutter/flutter#169540) 2025-05-28 [email protected] Roll Skia from 92311f2ba0b7 to 82d326fc2148 (1 revision) (flutter/flutter#169552) 2025-05-28 [email protected] dev/bots: improve service worker test code (flutter/flutter#169231) 2025-05-28 [email protected] Make Android team platform view TESTOWNERS (flutter/flutter#169297) 2025-05-28 [email protected] Roll Skia from 044f58f78a73 to 92311f2ba0b7 (9 revisions) (flutter/flutter#169542) 2025-05-27 [email protected] Roll Skia from 443f5257f382 to 044f58f78a73 (16 revisions) (flutter/flutter#169530) 2025-05-27 [email protected] [web] Fix unresponsive input above SelectionArea in Safari and Firefox. (flutter/flutter#167275) 2025-05-27 [email protected] Set pause_isolates_on_start flag if --start-paused (flutter/flutter#169392) 2025-05-27 [email protected] Roll Packages from af0b9a9 to 6eebe72 (24 revisions) (flutter/flutter#169514) 2025-05-27 [email protected] Roll Fuchsia Linux SDK from 5mpmPsuD8rpeiJizT... to nC9hLWjYVlChDTEPh... (flutter/flutter#169498) 2025-05-27 [email protected] Split hint from label and expose it via aria-description or aria-describedby (flutter/flutter#169157) 2025-05-26 [email protected] 🐛 Normalize generated file paths for the l10n generator (flutter/flutter#169467) 2025-05-26 [email protected] Roll Dart SDK from d811152316e4 to 6aeb798bdbe2 (2 revisions) (flutter/flutter#169478) 2025-05-26 [email protected] [Cupertino] Apply RSuperellipse to most Cupertino widgets (flutter/flutter#167784) 2025-05-26 [email protected] Roll `package:dds` to 5.0.2 (flutter/flutter#169471) 2025-05-26 [email protected] Use `.flutter-plugins-dependencies` for crash reporting. (flutter/flutter#169319) 2025-05-26 [email protected] Remove now disabled code that would generate `.flutter-plugins`. (flutter/flutter#169320) 2025-05-26 [email protected] Roll Dart SDK from 7dab9bffe1f7 to d811152316e4 (1 revision) (flutter/flutter#169473) 2025-05-26 [email protected] Precise browser resizing with integration_test and driver (flutter/flutter#160678) 2025-05-26 [email protected] Add `/coverage/` to `.gitignore.tmp` (flutter/flutter#169387) 2025-05-26 [email protected] Make test output with encoded `dart-defines=...` human readable. (flutter/flutter#169353) 2025-05-26 [email protected] Use at most `PROC~/2` tasks to transform assets. (flutter/flutter#169386) 2025-05-26 [email protected] Forward exit code from dart test to flutter test (flutter/flutter#168604) 2025-05-26 [email protected] Fix warning when building for macOS desktop (flutter/flutter#165996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#169231)

dev/bots: improve service worker test code

555abe0

Use `foundError` instead of throwing - as is recommended DRASTICALLY improve the error output by copying (more) from pkg:matcher

kevmoo marked this pull request as ready for review May 21, 2025 22:07

kevmoo requested a review from matanlurey as a code owner May 21, 2025 22:07

Merge branch 'master' into better_flutter_web_bot_silly

376eabd

mdebbar approved these changes May 22, 2025

View reviewed changes

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2025

Merge branch 'master' into better_flutter_web_bot_silly

ba5ad15

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 27, 2025

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025

auto-submit bot added this pull request to the merge queue May 28, 2025

Merged via the queue into flutter:master with commit 398fdee May 28, 2025
151 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2025

kevmoo deleted the better_flutter_web_bot_silly branch May 28, 2025 03:13

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 5d013c73baa7 (26 revisions) flutter/packages#9333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

7707d6a

…#169231)

engine-flutter-autoroll mentioned this pull request May 28, 2025

Roll Flutter from 4372bfbc6c23 to 0e536eb9fe4b (27 revisions) flutter/packages#9334

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 28, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

543f592

…#169231)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

eef0fbf

…#169231)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

989af9c

…#169231)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

835e35a

…#169231)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

3a34dbc

…#169231)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

398fdee2a dev/bots: improve service worker test code (flutter/flutter…

f4a1d77

…#169231)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dev/bots: improve service worker test code #169231

dev/bots: improve service worker test code #169231

Uh oh!

kevmoo commented May 21, 2025

Uh oh!

kevmoo commented May 21, 2025

Uh oh!

auto-submit bot commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dev/bots: improve service worker test code #169231

dev/bots: improve service worker test code #169231

Uh oh!

Conversation

kevmoo commented May 21, 2025

Uh oh!

kevmoo commented May 21, 2025

Uh oh!

auto-submit bot commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants