Skip to content

[cp][Impeller] separate immutable sampler descriptors. (#169011) #169085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 19, 2025
Merged

[cp][Impeller] separate immutable sampler descriptors. (#169011) #169085

auto-submit merged 1 commit into from
May 19, 2025

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented May 19, 2025

Manual cherry-pick into flutter-3.33-candidate.0

The descriptor set for the immutable sampler may need to be different than the non-immutable sampler variant. Make the pipeline key signed and use the sign bit to indicate immutable sampler.

Fixes #168114

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@mboetger
[Impeller] separate immutable sampler descriptors. (flutter#169011)
c84565a 
The descriptor set for the immutable sampler may need to be different
than the non-immutable sampler variant. Make the pipeline key signed and
use the sign bit to indicate immutable sampler.

Fixes flutter#168114
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 19, 2025

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@mboetger mboetger requested a review from jonahwilliams May 19, 2025 18:53
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 19, 2025
@mboetger mboetger requested a review from reidbaker May 19, 2025 18:53
jonahwilliams
jonahwilliams approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2025
@matanlurey matanlurey removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2025
matanlurey
matanlurey requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelled auto-submit.

Please do not land this until after the stable release - we are resource constrained in the release builder environment, and merging this to 3.33 means that we will have less resources available to run and test 3.32.

Please work with the Flutter Release Hotline team on the best time to merge this PR.

@matanlurey matanlurey mentioned this pull request May 19, 2025
Closed
@matanlurey
Copy link
Contributor

matanlurey commented May 19, 2025

Thanks for your patience - we have no more release builds for today, so this one is fine to add.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2025
@auto-submit auto-submit bot merged commit f43bd5c into flutter:flutter-3.33-candidate.0 May 19, 2025
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@reidbaker reidbaker Awaiting requested review from reidbaker

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mboetger @matanlurey @jonahwilliams