Skip to content

Include go_router label in framework triage links #168947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 16, 2025
Merged

Include go_router label in framework triage links #168947

auto-submit merged 1 commit into from
May 16, 2025

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented May 15, 2025

We decided to do go_router triage as a part of framework triage.

@justinmc
Include go_router labels in framework triage links
3ed5ae4 
We decided to do go_router triage as a part of framework triage.
@github-actions github-actions bot added the d: docs/ flutter/flutter/docs, for contributors label May 15, 2025
@justinmc justinmc changed the title Include go_router labels in framework triage links Include go_router label in framework triage links May 15, 2025
Piinks
Piinks approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! LGTM!

hannah-hyj
hannah-hyj approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunhtai
chunhtai approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit 9ab8eb6 May 16, 2025
13 checks passed
@auto-submit auto-submit bot deleted the justinmc-patch-1 branch May 16, 2025 03:33
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
004f45a 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
9833a53 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
496694f 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
151e7ab 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
3ec7aa7 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
124ceec 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
006a21b 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
e9ecb8b 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
6410348 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
a9aff02 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
9b6c65e 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
a95a994 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
69cdd2c 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
4311c6d 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
fc98975 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
264bf59 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
80dfedb 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
d742f9d 
…flutter#168947)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
360696a 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
3edcfcb 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
470bc36 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
46bc368 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
78d243d 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
4e0b76a 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
2ba71ed 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
db0857b 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
575a93a 
…flutter#168947)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
9ab8eb660 Include go_router label in framework triage links (flutter/…
279e2e4 
…flutter#168947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

d: docs/ flutter/flutter/docs, for contributors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinmc @Piinks @chunhtai @hannah-hyj