Skip to content

[Impeller] Use PathSource for DrawDiffRoundRect #168942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 16, 2025
Merged

[Impeller] Use PathSource for DrawDiffRoundRect #168942

auto-submit merged 2 commits into from
May 16, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented May 15, 2025

We avoid the expense and memory churn of allocating a path by using stack allocated path source objects to render the DiffRoundRect call.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 15, 2025
@flar flar requested a review from jonahwilliams May 15, 2025 22:51
jonahwilliams
jonahwilliams approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 16, 2025
Merged via the queue into flutter:master with commit c685293 May 16, 2025
181 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
29cdda3 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
b522008 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
b39f0f1 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
ccca221 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
20f4214 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
537f283 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
b2043f7 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
82d308d 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
87b3468 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
7a98d42 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
704c622 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
a7a554e 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
687234e 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
da50da8 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
8a175e3 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
6acbf0c 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
a2173d6 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
ef3e391 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
8e94d03 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
5915342 
…utter#168942)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
27cf010 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
5f795cd 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
8e1040e 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
4f53e8d 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
83a24e3 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
4ea0f8b 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
a83cb07 
…utter#168942)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c685293fc [Impeller] Use PathSource for DrawDiffRoundRect (flutter/fl…
c44cedf 
…utter#168942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @jonahwilliams