Mark web_tool_tests_1_2 as bringup. #168871

matanlurey · 2025-05-14T22:18:41Z

Unblocks the tree (>10% failure rate in prod): #168863.

flutter-dashboard · 2025-05-14T22:18:45Z

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

jonahwilliams

LGTM

flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@flar

For more details, @flar did a great job explaining it in #169168. This PR is a one-off fix for the `web_tool_tests_1_2` shard that has been timing out and bringing the tree down with it. The shard is marked `bringup` [here](#168871). After increasing the sub-task timeout, let's watch it and if it becomes consistently green, we will remove the `bringup` status. Partial fix for #168863 (partial because I still want to remove `bringup` before I consider the issue fixed)

@flar

For more details, @flar did a great job explaining it in #169168. This PR is a one-off fix for the `web_tool_tests_1_2` shard that has been timing out and bringing the tree down with it. The shard was marked `bringup` [here](#168871). After increasing the sub-task timeout, let's watch it and if it becomes consistently green, we will remove the `bringup` status. Partial fix for #168863 (partial because I still want to remove `bringup` before I consider the issue fixed)

mdebbar · 2025-05-23T16:16:41Z

Reason for revert: The timeout was fixed and the builder has been consistently green for the past 20+ runs: https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Windows%20web_tool_tests_1_2

auto-submit · 2025-05-23T16:17:11Z

Time to revert pull request flutter/flutter/168871 has elapsed.
You need to open the revert manually and process as a regular pull request.

This reverts commit 6891d5c.

Reverts #168871 The timeout was [fixed](#169277) and some slow tests have been [disabled](#169305). The builder has been consistently green for the past 20+ runs: https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Windows%20web_tool_tests_1_2 Closes #168863

…r#9259) flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Mark web_tool_tests_1_2 as bringup.

2fdbdd1

matanlurey requested a review from jtmcdole May 14, 2025 22:18

matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label May 14, 2025

jonahwilliams approved these changes May 14, 2025

View reviewed changes

matanlurey added this pull request to the merge queue May 14, 2025

jtmcdole approved these changes May 14, 2025

View reviewed changes

Merged via the queue into flutter:master with commit 6891d5c May 14, 2025
14 of 152 checks passed

matanlurey deleted the bringup-web_tool_tests_1_2 branch May 14, 2025 22:48

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 1d8078552d99 (21 revisions) flutter/packages#9253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

ebb6870

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

d67f895

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to d69edc303b49 (22 revisions) flutter/packages#9255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

1927041

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to a164f6538603 (23 revisions) flutter/packages#9256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

fe17312

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 94c661082cc3 (24 revisions) flutter/packages#9257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

4739592

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9214ed12dbae (25 revisions) flutter/packages#9258

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

8d19b09

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9a78af5eb067 (26 revisions) flutter/packages#9259

Merged

mdebbar mentioned this pull request May 22, 2025

Increase sub-task timeout for web_tool_tests_1_2 #169277

Merged

mdebbar added the revert Autorevert PR (with "Reason for revert:" comment) label May 23, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label May 23, 2025

mdebbar added a commit that referenced this pull request May 23, 2025

Revert "Mark web_tool_tests_1_2 as bringup. (#168871)"

af019d1

This reverts commit 6891d5c.

mdebbar mentioned this pull request May 23, 2025

Revert "Mark web_tool_tests_1_2 as bringup." #169361

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

90e5780

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

3a85df3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

ef19482

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

226e14b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

6891d5cf0 Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871)

9d2f577

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Mark web_tool_tests_1_2 as bringup. #168871

Mark web_tool_tests_1_2 as bringup. #168871

Uh oh!

matanlurey commented May 14, 2025

Uh oh!

flutter-dashboard bot commented May 14, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

Uh oh!

mdebbar commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mark web_tool_tests_1_2 as bringup. #168871

Mark web_tool_tests_1_2 as bringup. #168871

Uh oh!

Conversation

matanlurey commented May 14, 2025

Uh oh!

flutter-dashboard bot commented May 14, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdebbar commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants