Reverts "Use live region in error text input decorator for Android (#165531)" #168848

auto-submit · 2025-05-14T17:46:20Z

Initiated by: matanlurey

Reason for reverting: Breaks google client tests

Original PR Author: ash2moon

Reviewed By: {chunhtai, reidbaker, hannah-hyj}

This change reverts the following previous change:
Resolves partly #165510

Context: This issue originates from #99715, where it was reported that liveRegion alone was insufficient for announcing form validation errors. While liveRegion announces the first error encountered, subsequent submissions with the same error message on Android would not trigger a re-announcement.

Original Solution: Pull request #123373 addressed this by implementing the announce event to ensure error messages were consistently announced, even for repeated submissions.

Native Android Behavior (Jetpack Compose): In native Android development using Jetpack Compose, setting the isError property of a TextField to true triggers Talkback to announce "Error invalid input." This announcement occurs only on the initial change to the error state. Subsequent errors, even if the isError property remains true, are not re-announced. This behavior closely mirrors the functionality of liveRegion, with the key difference being that liveRegion also announces the specific error text, in addition to the general error state. Testing in a native Jetpack Compose application confirms this behavior and provides a valuable comparison point against the current Flutter form example.

Suggested Action: Fork the behavior in #123373. Reinstate the use of liveRegion for error announcements within widgets/Form for Android and keep other platforms the same.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…65531)" This reverts commit f3a1806.

…Android (#165531)" (flutter/flutter#168848)

flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9259) flutter/flutter@0b9f928...9a78af5 2025-05-15 [email protected] Manual pub package roll (flutter/flutter#168916) 2025-05-15 [email protected] Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 [email protected] Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 [email protected] Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 [email protected] Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 [email protected] Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 [email protected] Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 [email protected] Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 [email protected] [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 [email protected] iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 [email protected] Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 [email protected] CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 [email protected] [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 [email protected] Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 [email protected] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 [email protected] Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 [email protected] Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 [email protected] Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 [email protected] Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 [email protected] Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 [email protected] Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 [email protected] Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 [email protected] macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 [email protected] Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…Android (#165531)" (flutter/flutter#168848)

Revert "Use live region in error text input decorator for Android (#1…

5b219d3

…65531)" This reverts commit f3a1806.

auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 14, 2025

auto-submit bot requested review from cbracken, chinmaygarde and loic-sharma as code owners May 14, 2025 17:46

auto-submit bot assigned matanlurey May 14, 2025

fluttergithubbot approved these changes May 14, 2025

View reviewed changes

auto-submit bot added this pull request to the merge queue May 14, 2025

Merged via the queue into master with commit 606bb06 May 14, 2025
9 of 12 checks passed

auto-submit bot deleted the revert_f3a180656274819d6b5dfaba392aa1fd6198fcf9 branch May 14, 2025 18:19

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

5c3ce24

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 1d8078552d99 (21 revisions) flutter/packages#9253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

f0302fd

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to d69edc303b49 (22 revisions) flutter/packages#9255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

418fb0f

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to a164f6538603 (23 revisions) flutter/packages#9256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

fcb444a

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 94c661082cc3 (24 revisions) flutter/packages#9257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

cfc38d5

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9214ed12dbae (25 revisions) flutter/packages#9258

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

85bf66c

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9a78af5eb067 (26 revisions) flutter/packages#9259

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

a3e3683

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

a46fd6b

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

8a8404d

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

70b90c6

…Android (#165531)" (flutter/flutter#168848)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

606bb06c0 Reverts "Use live region in error text input decorator for …

4d0cb35

…Android (#165531)" (flutter/flutter#168848)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reverts "Use live region in error text input decorator for Android (#165531)" #168848

Reverts "Use live region in error text input decorator for Android (#165531)" #168848

Uh oh!

auto-submit bot commented May 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Use live region in error text input decorator for Android (#165531)" #168848

Reverts "Use live region in error text input decorator for Android (#165531)" #168848

Uh oh!

Conversation

auto-submit bot commented May 14, 2025

Pre-launch Checklist

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants