Skip to content

Homogenize themes documentation #168808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 15, 2025
Merged

Homogenize themes documentation #168808

auto-submit merged 1 commit into from
May 15, 2025

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented May 14, 2025

Description

This PR homogenizes xxxTheme and xxxThemeData classes documentation.
Mainly:

  • Points to xxxTheme.of from xxxThemeData documentation instead of using pseudo code (and add a code block in xxxTheme.of documentation when it was missing.
  • Fix xxxTheme.of documentation when the comment did not specify the correct return type.

Tests

Documentation only

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels May 14, 2025
@bleroux bleroux force-pushed the themes_documentation_homogenization branch from 2bab414 to 515fc8c Compare May 14, 2025 15:46
@dkwingsmt dkwingsmt self-requested a review May 14, 2025 18:35
@bleroux bleroux requested a review from QuncCccccc May 15, 2025 18:28
QuncCccccc
QuncCccccc approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you:)

packages/flutter/lib/src/material/menu_theme.dart
/// child: child,
/// );
/// }
/// MenuThemeData theme = MenuTheme.of(context);
Copy link
Contributor

@QuncCccccc QuncCccccc May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 15, 2025
Merged via the queue into flutter:master with commit 701385d May 15, 2025
75 of 76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2025
@bleroux bleroux deleted the themes_documentation_homogenization branch May 16, 2025 06:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
73e981f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
f453ed3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
44b3f1d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
85af578
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
51d8a25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
871a784
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
f86e542
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
2263a60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
9285bb3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
6bc8907
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
a6da2bf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
00ccd7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
2426ab7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
fa130dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
6903ee7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
ff6ca41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
7aabf14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
b86fbe6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
4f80b81
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
e2c15e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
8e4be1f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
fae1cf2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
d11ebee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
b3c59d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
f75f5fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
13c755b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
c2e9f58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
701385d5b Homogenize themes documentation (flutter/flutter#168808)
0b32bbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bleroux @QuncCccccc