Skip to content

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented May 14, 2025

This PR makes the FlutterGeneratedPluginSwiftPackage swift package an Xcode root package. A root package is one that is within the Xcode project as a file reference. See image below:

Screenshot 2025-05-14 at 2 54 28 PM

This change makes it so that when the FlutterGeneratedPluginSwiftPackage changes, if Xcode is also open, Xcode will automatically re-resolve the package. This makes Xcode use the new version instead of whatever it had cached.

Fixes #162399 and incremental change towards #166489.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels May 14, 2025
@vashworth vashworth marked this pull request as ready for review May 15, 2025 15:19
@vashworth vashworth requested a review from a team as a code owner May 15, 2025 15:19
@vashworth vashworth requested a review from loic-sharma May 15, 2025 15:19
@jmagman jmagman requested a review from hellohuanlin May 15, 2025 21:10
@loic-sharma
Copy link
Member

As part of this change, don't forget to also update the doc's Add SwiftPM to app manually guide too :)

projectInfo,
logErrorIfNotMigrated: logErrorIfNotMigrated,
);
final bool pacakgeFileReferenceMigrated = _isFileReferenceMigrated(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final bool pacakgeFileReferenceMigrated = _isFileReferenceMigrated(
final bool packageFileReferenceMigrated = _isFileReferenceMigrated(

Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, excellent tests!

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 19, 2025
Merged via the queue into flutter:master with commit 63f9060 May 19, 2025
145 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 21, 2025
Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…r#9305)

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9305)

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop platform-ios iOS applications specifically team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SwiftPM] Plugin not found right after adding

2 participants