Skip to content

Replace SizedBox spacing with spacing parameter in Row usages #168688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 16, 2025
Merged

Replace SizedBox spacing with spacing parameter in Row usages #168688

auto-submit merged 1 commit into from
May 16, 2025

Conversation

@tilucasoli
Copy link
Contributor

@tilucasoli tilucasoli commented May 12, 2025 •
edited
Loading

This PR refactors Flutter widgets that use SizedBox for spacing between children in Row into using the spacing parameter instead.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 12, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 12, 2025
@dkwingsmt dkwingsmt self-requested a review May 14, 2025 18:32
@justinmc justinmc requested a review from loic-sharma May 15, 2025 20:07
justinmc
justinmc approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for cleaning this up. You'll have to get a test exemption for this, see the bot's message above. I agree that this probably should not have tests. It would be possible to check for the absence of SizeBox, but I think that's not valuable.

loic-sharma
loic-sharma approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@loic-sharma
Copy link
Member

loic-sharma commented May 15, 2025

FYI I asked for test exemption here: https://discord.com/channels/608014603317936148/608018585025118217/1372676378662666270

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented May 16, 2025

test-exempt: code refactor with no semantic change

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 16, 2025
Merged via the queue into flutter:master with commit a2c2d2c May 16, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
e2fb8ef 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
be68717 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
b0f2d4b 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
9532d48 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
ee0b5a8 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
d2e94f9 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 17, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
29734ac 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 17, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
f3a81ca 
…es (flutter/flutter#168688)
This was referenced May 19, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
b33ebf4 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
57d988d 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
1ff668c 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
23efc49 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
c3ae692 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 19, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
ad8ad52 
…es (flutter/flutter#168688)
This was referenced May 19, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
583c809 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
4674dde 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
13ea422 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
9677e3f 
…es (flutter/flutter#168688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
1bf07b7 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
037de3a 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
32d26c5 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
66b745f 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
a650c6e 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
224e475 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
6f38243 
…es (flutter/flutter#168688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
a2c2d2c8d Replace SizedBox spacing with spacing parameter in Row usag…
38dd134 
…es (flutter/flutter#168688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tilucasoli @loic-sharma @stuartmorgan-g @justinmc