Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented May 8, 2025

Bumped targetsdk to Android API 36 in a different PR in case we have to rollback this change.

This is a part of bumping all necessary framework defaults for Android API 36 here.

Partially Addresses #163071

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 8, 2025
@jesswrd jesswrd requested a review from a team May 9, 2025 17:58
@jesswrd jesswrd marked this pull request as ready for review May 9, 2025 17:58
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168577 at sha 9ca670c

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label May 9, 2025
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 12, 2025
Merged via the queue into flutter:master with commit 4ac6f4d May 12, 2025
143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 12, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 12, 2025
flutter/flutter@992ad74...54de32d

2025-05-12 [email protected] Update hello_world example to current layout flutter create uses (flutter/flutter#168571)
2025-05-12 [email protected] Roll Skia from cb1646ca59db to 9f9e1f37917e (1 revision) (flutter/flutter#168656)
2025-05-12 [email protected] Fix Selected DropdownMenuItem isn't highlighted on mobile (flutter/flutter#167874)
2025-05-12 [email protected] Api docs: Add Widget of the Week video to DropdownMenu (flutter/flutter#168254)
2025-05-12 [email protected] Bumping Framework Default TargetSdk to 36 (flutter/flutter#168577)
2025-05-11 [email protected] Roll Fuchsia Linux SDK from VIG5-P9wwXgQkCkeX... to 6vjKe0bfYDVaECqBL... (flutter/flutter#168646)
2025-05-11 [email protected] Roll Skia from 0feee17aeaca to cb1646ca59db (1 revision) (flutter/flutter#168642)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…#9243)

flutter/flutter@992ad74...54de32d

2025-05-12 [email protected] Update hello_world example to current layout flutter create uses (flutter/flutter#168571)
2025-05-12 [email protected] Roll Skia from cb1646ca59db to 9f9e1f37917e (1 revision) (flutter/flutter#168656)
2025-05-12 [email protected] Fix Selected DropdownMenuItem isn't highlighted on mobile (flutter/flutter#167874)
2025-05-12 [email protected] Api docs: Add Widget of the Week video to DropdownMenu (flutter/flutter#168254)
2025-05-12 [email protected] Bumping Framework Default TargetSdk to 36 (flutter/flutter#168577)
2025-05-11 [email protected] Roll Fuchsia Linux SDK from VIG5-P9wwXgQkCkeX... to 6vjKe0bfYDVaECqBL... (flutter/flutter#168646)
2025-05-11 [email protected] Roll Skia from 0feee17aeaca to cb1646ca59db (1 revision) (flutter/flutter#168642)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jesswrd jesswrd changed the title Bumping Framework Default TargetSdk to 36 [Android 16] Bumping Framework Default TargetSdk to 36 Jun 10, 2025
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…#9243)

flutter/flutter@992ad74...54de32d

2025-05-12 [email protected] Update hello_world example to current layout flutter create uses (flutter/flutter#168571)
2025-05-12 [email protected] Roll Skia from cb1646ca59db to 9f9e1f37917e (1 revision) (flutter/flutter#168656)
2025-05-12 [email protected] Fix Selected DropdownMenuItem isn't highlighted on mobile (flutter/flutter#167874)
2025-05-12 [email protected] Api docs: Add Widget of the Week video to DropdownMenu (flutter/flutter#168254)
2025-05-12 [email protected] Bumping Framework Default TargetSdk to 36 (flutter/flutter#168577)
2025-05-11 [email protected] Roll Fuchsia Linux SDK from VIG5-P9wwXgQkCkeX... to 6vjKe0bfYDVaECqBL... (flutter/flutter#168646)
2025-05-11 [email protected] Roll Skia from 0feee17aeaca to cb1646ca59db (1 revision) (flutter/flutter#168642)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants