Skip to content

Conversation

@yiiim
Copy link
Member

@yiiim yiiim commented May 8, 2025

Fixes #168545.
Fixes #168445.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 8, 2025
final ModalRoute<dynamic>? route = ModalRoute.of(context);
if (route?.secondaryAnimation != null && route!.secondaryAnimation!.isAnimating) {
visible = false;
if (_listenedRouteSecondaryAnimation != route.secondaryAnimation) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This looks like it will successfully ensure that when the route's secondary animation stops, the Tooltip widget gets rebuilt so that it can put the two listener widgets in place.

But what about when the route begins a secondary animation in the first place? (So that route?.secondaryAnimation?.isAnimating changes from null or false to true.) It's not clear to me what would ensure that this widget gets rebuilt for the transition in that direction. I'm not sure how to easily set up something to listen for that, either.

I think that suggests that this whole secondaryAnimation logic shouldn't be in the build method. For any data the build method depends on, we should make sure the dependency is recorded one way or another to guarantee the widget gets rebuilt when the data changes; and this condition seems hard to do that for.

Instead, I think we can leave the two listener widgets in place unconditionally (well, conditioned only on _visible); and this condition can be checked instead at the top of the three pointer callbacks from those widgets. That way we'd always use the up-to-date value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or simplifying further: can this look at ModalRoute.isCurrentOf(context) (aka route?.isCurrent), instead of looking at secondaryAnimation at all? (/cc @rkishan516) If I'm correctly understanding the point of this secondaryAnimation logic, then that expresses the same information as we're ultimately aiming to get from secondaryAnimation here.

Copy link
Contributor

@rkishan516 rkishan516 May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnprice Main idea behind adding secondaryAnimation was, we shouldn't show tooltip while transition is happening. If we are able to achieve that w/o it, we can go for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the statusListener does not need to save a reference to the secondaryAnimation, and could just watch for a change in the status, and set a bool to true or false based on the status. secondaryAnimation is a ProxyAnimation that sometimes has it's parent animation swapped, so it's possible that it's identity doesn't change when this code might expect. But the status should always be correct on if it's animating or not.

And isCurrent should be false mid-transition, so I believe that using it might work for these two issues as well.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also seems to fix #168445. I agree with @gnprice's concerns, but we should double check that this PR continues to fix that issue after any changes are made. I left a minimal repro on the issue.

@yiiim
Copy link
Member Author

yiiim commented May 20, 2025

It has been changed to use ModalRoute.isCurrentOf(context). Apologies for the delayed response due to the time zone difference.

Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! This logic LGTM. Glad to see it passes the same regression test you wrote in the original revision of the PR, plus the existing regression test that #167614 added for the previous issue #167359.

Before we merge, it'd be good for someone to also verify that this fixes the repro @justinmc posted at #168445 (comment) for the current issue #168445.

Comment on lines +939 to 946
if (_visible) {
result = _ExclusiveMouseRegion(
onEnter: _handleMouseEnter,
onExit: _handleMouseExit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight change in behavior this causes is that _handleMouseExit no longer gets suppressed when there's another route on top (including during its transition animation / this route's secondary animation).

My suggestion above (#168546 (comment)) was to put the new condition at the top of all three of _handlePointerDown, _handleMouseEnter, and _handleMouseExit, because that matches most closely the effect of suppressing these listener widgets entirely. This version of the PR adds the condition to only the first two of those, therefore causing that slight change in behavior.

This way seems fine to me. It means that even when the route is hidden by another, if there's already a tooltip visible, it'll be possible to hide it by moving the mouse out (or in and then out) of the region. If that situation can happen (and looking at the code, I suspect it can), then that seems like a problem anyway — the tooltip should probably get suppressed by that. This change making _handleMouseExit available doesn't solve that problem… but the change is harmless and will sometimes be helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to Google test failures, I also added a condition in _handleMouseExit.

@gnprice
Copy link
Member

gnprice commented May 20, 2025

(I've edited the description to say this fixes #168445 too, in order to make that connection explicit, because I believe this will. But that should still get confirmed using the #168445 repro before actually merging this.)

@yiiim
Copy link
Member Author

yiiim commented May 20, 2025

Google tests are still failing, assistance from a Google employee is needed.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Confirmed that #168445 is fixed at aa7e230.

The Google tests failure was an infra problem, I've triggered a rerun.

@justinmc
Copy link
Contributor

Google testing continues to have infra trouble, I've filed an issue: #169159.

I'll run the Google tests manually or otherwise set this to passing.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 20, 2025
Merged via the queue into flutter:master with commit 86f6c72 May 21, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025
MTtankkeo pushed a commit to MTtankkeo/flutter that referenced this pull request May 21, 2025
…tter#169007)

This PR introduces two new widgets:

- `DisableWidgetInspectorScope`, which hides its children from the
widget inspector
- `EnableWidgetInspectorScope`, which makes its children available to
the widget inspector

These widgets are used to inform the `WidgetInspectorService`'s
`InspectorSerializationDelegate` when it should be omitting
`DiagnosticableNodes` from the response when building the root widget
tree for the inspector.

This functionality is meant to be used by developer tooling and packages
that want to prevent unnecessary implementation details from polluting
the inspector and possibly confusing end users.

This change also includes some minor updates to the Widget Preview
scaffolding template to hide the scaffold's implementation details and
only show details for the previews defined by the user.

Part of flutter#166423

**Widget Previewer Demo**
<img width="1606" alt="image"
src="https://github.com/user-attachments/assets/eb23160e-01c5-413f-b1d2-97985ced9ef9"
/>

[flutter_tool] Remove unused environment flags in JS compiler (flutter#169097)

Removes things left over from refactoring in
flutter@5a9fa1e

Add documentation for experimental branches, update artifacts. (flutter#169109)

I still need to get the Firebase short URL, but PTAL.

[native assets] Roll dependencies (flutter#169073)

Roll deps to the ones released today.

Fix the issue with Tooltip (flutter#168546)

Fixes flutter#168545.
Fixes flutter#168445.

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Roll pub packages (flutter#169181)

This PR was generated by `flutter update-packages --force-upgrade`.

Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter#169156)

This flag has been enabled by default for quite some time in `master`,
and in the current `stable`.

This is the first of many PRs to get rid of the flag and the deprecated
code it is guarding.

Fix dart format for asset.dart

Fix an issue about tool_tests_general
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 21, 2025
Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…r#9305)

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9305)

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions)

flutter/flutter@9a78af5...33cdd8e

2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524)
2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273)
2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194)
2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153)
2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890)
2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079)
2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952)
2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156)
2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181)
2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546)
2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073)
2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109)
2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097)
2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007)
2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113)
2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106)
2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099)
2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718)
2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095)
2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031)
2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518)
2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901)
2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395)
2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018)
2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031)
2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736)
2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075)
2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443)
2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789)
2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053)
2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959)
2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024)
2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484)
2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955)
2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567)
2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939)
2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011)
2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881)
2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310)
2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009)
2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307)
2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999)
2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991)
2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073)
2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989)
2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597)
...
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](#168546) and [Delay
showing tooltip during page
transition](#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](#169741)
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 11, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](flutter#168546) and [Delay
showing tooltip during page
transition](flutter#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](flutter#169741)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](flutter#168546) and [Delay
showing tooltip during page
transition](flutter#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](flutter#169741)
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](flutter#168546) and [Delay
showing tooltip during page
transition](flutter#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](flutter#169741)
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](flutter#168546) and [Delay
showing tooltip during page
transition](flutter#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](flutter#169741)
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Makes the tooltip interactive if the route is the current route and the
route is not animating out.

Added `_route` to cache `ModalRoute.of(context)`.

Consolidates [Fix the issue with
Tooltip](flutter#168546) and [Delay
showing tooltip during page
transition](flutter#167614)

Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not
laid out -
TooltipState._buildTooltipOverlay](flutter#169741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Tooltip inside the ModalBottomSheet cannot be displayed after showMenu. [Google3 Bug]: Back button causes crash

5 participants