Fix ListTile overwriting parent IconButtonTheme for its children (#167727) #168480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
QuncCccccc
reviewed
May 7, 2025
QuncCccccc
reviewed
May 8, 2025
QuncCccccc
reviewed
May 9, 2025
QuncCccccc
approved these changes
May 9, 2025
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution:)
QuncCccccc
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 11, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 11, 2025
flutter/flutter@83082c1...992ad74 2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
9 tasks
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…r#9239) flutter/flutter@83082c1...992ad74 2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…r#9239) flutter/flutter@83082c1...992ad74 2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ListTile was recreating its own IconButtonThemeData—discarding any styles inherited from an existing IconButtonTheme above it. This change makes ListTile merge its theme data with the inherited one instead of replacing it, so child IconButtons now correctly pick up parent styling
issue: #167727
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.