-
Notifications
You must be signed in to change notification settings - Fork 29.7k
WebParagraph (bidi, styles, placeholders, decorations, etc) #168412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moving the test file
Test still not working
Drawing paragraph on Canvas2D (not working)
Drawing paragraph on Canvas2D (not working)
Drawing paragraph on Canvas2D (not working)
on DrawImage
No bidi, no hard line breaks
(Required flattening the style ranges)
(it breaks but somewhere down the road)
All tests workin
(just started)
All existing tests are passing
|
Hey @Rusino! Greetings from stale PR triage 👋 |
|
This PR is used to settle the merge with the main branch. Once it's done we are going to move to another PR quickly. |
|
@Rusino would you like some real world stress tests for Flutter text layout? At Super Editor we support browsers and we'd be happy to try out any new text layout system in a document editing context. Please let me know. Super Editor: https://github.com/superlistapp/super_editor |
It would be really nice but keep in mind that this is the initial version that should be updated soon (maybe a week? or two). |
|
@Rusino will this require a custom engine build to try out? Or will it propagate to the framework so that we can try it on |
I am not entirely sure what is the state right now (@mdebbar may know more) but you will have to use experimental flag in Chrome browser for now (and the other browsers are not supporting it...yet). The plan though is to have it in the framework eventually. |
|
@matthew-carroll it's still not ready to be used in a Flutter app. Please follow the issues that I just created: #172561. I'll post instructions there when things are ready for testing! |
|
Closing in favor of #172853 |
Part of #172561