Skip to content

Conversation

@chinmaygarde
Copy link
Member

Fixes #168393
Fixes #168394

@chinmaygarde chinmaygarde requested a review from jason-simmons May 6, 2025 18:27
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 6, 2025
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
@chinmaygarde chinmaygarde force-pushed the libimpellerusability branch from af8f55c to eae2ad7 Compare May 7, 2025 17:46
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented May 7, 2025

autosubmit label was removed for flutter/flutter/168397, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde chinmaygarde force-pushed the libimpellerusability branch from eae2ad7 to 2228d50 Compare May 7, 2025 19:04
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 9, 2025
Merged via the queue into flutter:master with commit e3d5758 May 9, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 11, 2025
flutter/flutter@83082c1...992ad74

2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…r#9239)

flutter/flutter@83082c1...992ad74

2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9239)

flutter/flutter@83082c1...992ad74

2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633)
2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616)
2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624)
2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621)
2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491)
2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362)
2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614)
2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351)
2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561)
2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609)
2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600)
2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397)
2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480)
2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569)
2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524)
2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587)
2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Impeller] libImpeller: Make the impeller.hpp classes non-final. [Impeller] libImpeller: Prefer out arguments over struct returns in the C API.

2 participants