Respect `calendarDelegate` in `showDateRangePicker` #168290

sarbagyastha · 2025-05-04T13:19:02Z

This PR fixes an issue where the calendarDelegate parameter was not respected by showDateRangePicker. Although support forcalendarDelegate was added in PR #161874, it was inadvertently omitted from showDateRangePicker, causing inconsistencies in behavior compared to showDatePicker.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-05-04T15:07:12Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168290 at sha 4ce5a7e

sarbagyastha · 2025-05-19T04:34:47Z

@MitchellGoodwin

MitchellGoodwin

Apologies for the late review. I think making _CalendarDateRangePicker public makes sense, but would involve a not insignificant amount of effort. It would need better documentation, and new tests added for that widget. The issue tracking it is #65108.

Besides that, the code LGTM. Could you remove making the _CalendarDateRangePicker public from this PR? It would need more work to get that part ready, and the rest doesn't have to wait. Having them be in separate PRs would be better as well for github history.

…tency and encapsulation

sarbagyastha · 2025-05-21T18:18:41Z

Apologies for the late review. I think making _CalendarDateRangePicker public makes sense, but would involve a not insignificant amount of effort. It would need better documentation, and new tests added for that widget. The issue tracking it is #65108.

Besides that, the code LGTM. Could you remove making the _CalendarDateRangePicker public from this PR? It would need more work to get that part ready, and the rest doesn't have to wait. Having them be in separate PRs would be better as well for github history.

@MitchellGoodwin Reverted the CalendarDateRangePicker change.

MitchellGoodwin

LGTM! Thank you for following up with this change. I'll ask around for a secondary review.

justinmc

LGTM 👍. Thanks for fixing this!

…r/flutter#168290)

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…r#9315) Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…r/flutter#168290)

sarbagyastha added 5 commits March 27, 2025 11:49

Add calendarDelegate parameter to showDateRangePicker

8183349

Made CalendarDateRangePicker public for consistency

6132dad

Add calendarDelegate parameter to date range picker tests

548cd48

Merge remote-tracking branch 'upstream/master' into date-range-picker

d4dbddf

Add test for showDateRangePicker with default calendar delegate

5e538ed

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 4, 2025

sarbagyastha changed the title ~~Respect calendarDelegate in showDateRangePicker (missed in #161874)~~ Respect calendarDelegate in showDateRangePicker May 4, 2025

sarbagyastha changed the title ~~Respect calendarDelegate in showDateRangePicker~~ Respect calendarDelegate in showDateRangePicker and make CalendarDateRangePicker public May 4, 2025

sarbagyastha changed the title ~~Respect calendarDelegate in showDateRangePicker and make CalendarDateRangePicker public~~ Respect calendarDelegate in showDateRangePicker and make CalendarDateRangePicker public May 4, 2025

sarbagyastha changed the base branch from main to master May 4, 2025 13:26

sarbagyastha added 2 commits May 4, 2025 19:22

Update date_range_picker_test.dart

1ac7074

Refactor showDateRangePicker test for improved readability

4ce5a7e

flutter-dashboard bot added the will affect goldens Changes to golden files label May 4, 2025

Merge branch 'master' into date-range-picker

2025ccb

dkwingsmt requested a review from MitchellGoodwin May 7, 2025 18:41

MitchellGoodwin reviewed May 21, 2025

View reviewed changes

Rename CalendarDateRangePicker to _CalendarDateRangePicker for consis…

2def69e

…tency and encapsulation

sarbagyastha changed the title ~~Respect calendarDelegate in showDateRangePicker and make CalendarDateRangePicker public~~ Respect calendarDelegate in showDateRangePicker May 21, 2025

Merge branch 'master' into date-range-picker

6be294e

MitchellGoodwin approved these changes May 21, 2025

View reviewed changes

justinmc approved these changes May 21, 2025

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

auto-submit bot added this pull request to the merge queue May 21, 2025

Merged via the queue into flutter:master with commit b7e0dd6 May 21, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

15eb3cb

…r/flutter#168290)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to e78b434e8f08 (12 revisions) flutter/packages#9307

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

30c72da

…r/flutter#168290)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to cb3150f99848 (13 revisions) flutter/packages#9308

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

1682b14

…r/flutter#168290)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to 5fd7aa2ed70d (16 revisions) flutter/packages#9309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

7c68d62

…r/flutter#168290)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to d5ae7839620b (38 revisions) flutter/packages#9314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

6ea7503

…r/flutter#168290)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/packages#9315

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

d875fbe

…r/flutter#168290)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

fe79e4a

…r/flutter#168290)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

d4387e5

…r/flutter#168290)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

9a541bf

…r/flutter#168290)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

b7e0dd6ff Respect calendarDelegate in showDateRangePicker (flutte…

d808ed9

…r/flutter#168290)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Respect `calendarDelegate` in `showDateRangePicker` #168290

Respect `calendarDelegate` in `showDateRangePicker` #168290

Uh oh!

sarbagyastha commented May 4, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented May 4, 2025

Uh oh!

sarbagyastha commented May 19, 2025

Uh oh!

MitchellGoodwin left a comment

Uh oh!

sarbagyastha commented May 21, 2025

Uh oh!

MitchellGoodwin left a comment

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Respect calendarDelegate in showDateRangePicker #168290

Respect calendarDelegate in showDateRangePicker #168290

Uh oh!

Conversation

sarbagyastha commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 4, 2025

Uh oh!

sarbagyastha commented May 19, 2025

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

sarbagyastha commented May 21, 2025

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Respect `calendarDelegate` in `showDateRangePicker` #168290

Respect `calendarDelegate` in `showDateRangePicker` #168290

sarbagyastha commented May 4, 2025 •

edited

Loading