Skip to content

Change FGP unit test expect to match on process result instead of exit code #168278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 5, 2025
Merged

Change FGP unit test expect to match on process result instead of exit code #168278

auto-submit merged 1 commit into from
May 5, 2025
+1 −1

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented May 3, 2025 •
edited
Loading

Change FGP unit test expect to match on process result instead of exit code. Should give actionable logs on failure.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 3, 2025
@gmackall gmackall marked this pull request as ready for review May 3, 2025 20:30
@gmackall gmackall requested a review from a team May 5, 2025 16:13
reidbaker
reidbaker approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default for ProcessResultMatcher() something that ensures the task was a success?

camsim99
camsim99 approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99
Copy link
Contributor

camsim99 commented May 5, 2025 •
edited
Loading

Is the default for ProcessResultMatcher() something that ensures the task was a success?

Wondered the same thing:

flutter/packages/flutter_tools/test/integration.shard/test_utils.dart

Line 134 in cfa9859

/// The default for [exitCode] will be 0 while

@gmackall
Copy link
Member Author

gmackall commented May 5, 2025

Yes, you can see its conditions here
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/test_utils.dart#L184
Where it fails if the exit code is non zero (or if it can't find the stderr or stdout (not if they exist, just if it can't find it))

The reason it is better is because of how it describes a mismatch
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/test_utils.dart#L188

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 5, 2025
Merged via the queue into flutter:master with commit ce4aae7 May 5, 2025
143 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
de1bd5a 
…stead of exit code (flutter/flutter#168278)
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request May 5, 2025
@gmackall @ash2moon
Change FGP unit test expect to match on process result instead of e…
e9b8539 
…xit code (flutter#168278)

Change FGP unit test `expect` to match on process result instead of exit
code. Should give actionable logs on failure.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Gray Mackall <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
b2c6929 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
ca12659 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
420c4bb 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
44771d8 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
adb1686 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
fead2bf 
…stead of exit code (flutter/flutter#168278)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@gmackall @mboetger
Change FGP unit test expect to match on process result instead of e…
cdac126 
…xit code (flutter#168278)

Change FGP unit test `expect` to match on process result instead of exit
code. Should give actionable logs on failure.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Gray Mackall <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
4cfa7e7 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
5261eca 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
eaf87f7 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
221f42f 
…stead of exit code (flutter/flutter#168278)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
56aadaf 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
d17eb48 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
7164664 
…stead of exit code (flutter/flutter#168278)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (#9223)
1392e8c 
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
cf1d157 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
aed46c7 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
c32f7c3 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
2cb6319 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
3094ab7 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
50d6950 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
78aa6ac 
…stead of exit code (flutter/flutter#168278)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
ce4aae7fa Change FGP unit test expect to match on process result in…
a591c60 
…stead of exit code (flutter/flutter#168278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@camsim99 camsim99 camsim99 approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmackall @camsim99 @reidbaker