Skip to content

fix FadeForwardsTransitionBuilder input irresponsive during return animation #164241 #168277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheLastFlame wants to merge 7 commits into from
Closed

fix FadeForwardsTransitionBuilder input irresponsive during return animation #164241 #168277

TheLastFlame wants to merge 7 commits into from

Conversation

@TheLastFlame
Copy link
Contributor

@TheLastFlame TheLastFlame commented May 3, 2025 •
edited
Loading

Depends on: #167032

Fix: #164241

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. labels May 3, 2025
@TheLastFlame
Copy link
Contributor Author

TheLastFlame commented May 3, 2025

Only the last 2 commits apply to this pr 😅

@TheLastFlame TheLastFlame force-pushed the fix_fade_forwards_blocking_interaction branch from 2247738 to 94a7889 Compare May 6, 2025 06:52
@dkwingsmt dkwingsmt requested a review from justinmc May 7, 2025 18:43
@justinmc justinmc mentioned this pull request May 16, 2025
Merged
9 tasks
justinmc
justinmc reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fixed now as of #168425?

Sorry if there was overlap there and I didn't notice this PR. If so it looks like we solved the problem in different ways, I wonder if this one has any advantage?

@TheLastFlame
Copy link
Contributor Author

TheLastFlame commented May 17, 2025

@justinmc, yes, your pr fixes this problem. I don't think there is any fundamental difference. You can close this pr and the issue that is associated with it.

@dkwingsmt
Copy link
Contributor

dkwingsmt commented May 21, 2025

I'm closing this PR then. Feel free to open other ones if there are remaining problems. :)

@dkwingsmt dkwingsmt closed this May 21, 2025
@dkwingsmt dkwingsmt mentioned this pull request May 21, 2025
Closed
@justinmc
Copy link
Contributor

justinmc commented May 29, 2025

Thanks @TheLastFlame and sorry again for stepping on your toes here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc left review comments

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FadeForwardsTransitionBuilder input irresponsive during return animation

4 participants

@TheLastFlame @dkwingsmt @justinmc @rkishan516